Moodle
  1. Moodle
  2. MDL-31109

Bad url in link to turn off (disable) maintenance mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.2.2
    • Component/s: Installation
    • Labels:
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      1/ enable maintenance mode
      2/ go to admin notification page
      3/ click on "disable maintenance mode" link

      Show
      1/ enable maintenance mode 2/ go to admin notification page 3/ click on "disable maintenance mode" link
    • Workaround:
      Hide

      Disable Maintenance mode in the usual way via:

      Home > Site administration > Server > Maintenance mode

      Show
      Disable Maintenance mode in the usual way via: Home > Site administration > Server > Maintenance mode
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w03_MDL-31109_m23_maintenance
    • Rank:
      37537

      Description

      I have just successfully upgraded from 2.1 to Moodle 2.2.1 (Build: 20120109) via CVS.

      During the upgrade I turned on Maintenance mode. As expected, on completion of the upgrade, I was faced with the following message:

      Your site is currently in maintenance mode (only admins can log in). To return this site to normal operation, disable maintenance mode.

      BUT, the text "disable maintenance mode" has a bad URL, as follows:

      http://music.c.fun.ac.jp/moodle/admin/%7B$a%7D

      which is the same as

      http://music.c.fun.ac.jp/moodle/admin/{$@}

      Disabling Maintenance mode in the usual way via:

      Home > Site administration > Server > Maintenance mode

      works as expected, so not a serious problem, but one that could confuse new Moodlers.

      Replication steps:
      1) Turn on (enable) Maintenance mode
      2) Upgrade to Moodle 2.2.1 (Build: 20120109)
      3) Let upgrade run
      4) click on the "disable maintenance mode" link in the final screen

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting that.

          Show
          Michael de Raadt added a comment - Thanks for reporting that.
          Hide
          Petr Škoda added a comment -

          Thanks a lot for the report.

          Show
          Petr Škoda added a comment - Thanks a lot for the report.
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Petr - this has been integrated now.
          Hide
          Jason Fowler added a comment -

          Test worked as expected

          Show
          Jason Fowler added a comment - Test worked as expected
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is now available in the git and cvs repositories.

          Consider the responsibility of your fingerprints engraved there for future generations!

          Thanks for the work, closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This is now available in the git and cvs repositories. Consider the responsibility of your fingerprints engraved there for future generations! Thanks for the work, closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: