Moodle
  1. Moodle
  2. MDL-31110

Loading animation remains after error message in file area

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to a course -> Forum
      2. Create a new post
      3. In attachment area see if 'You can drag and drop files...'
      4. Change the course settings to set max file size of only 10KB
      5. Go to forum and drag and drop a file more than 10KB
      6. Error message will be displayed, click ok
      7. Loading image should not be visible.
      8. Add another big file
      9. Error will pop-up again. After clicking ok, there should not be any loading images.
      Show
      Go to a course -> Forum Create a new post In attachment area see if 'You can drag and drop files...' Change the course settings to set max file size of only 10KB Go to forum and drag and drop a file more than 10KB Error message will be displayed, click ok Loading image should not be visible. Add another big file Error will pop-up again. After clicking ok, there should not be any loading images.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-31110_loading_animation

      Description

      While dragging and dropping a big file then max allowed (in file manager), an error message pop-up. Clicking ok leaves loading animation. Try adding another big file leaves two loading images and keeps increasing as you try adding more big files.

      1. Go to a course -> Forum
      2. Create a new post
      3. In attachment area see if 'You can drag and drop files...'
      4. Change the course settings to set max file size of only 10KB
      5. Go to forum and drag and drop a file more than 10KB
      6. Error message will be displayed, click ok
      7. Loading image remains, try adding another big file
      8. Error will pop-up again. After clicking ok, there are two loading images.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Davo Smith added a comment -

            There is now a patch for this available here:
            https://github.com/davosmith/moodle/tree/MDL-31110_loading_animation
            Diff here:
            https://github.com/davosmith/moodle/commit/1a8cf49d9b7ff8fe744f4da07a1caf1ea2d5025c

            This hides the loading spinner before the 'file too big' message is shown. It also hides the spinner as soon as the AJAX call completes (whether or not it is successful) and, for good measure, shows an error message if there was a server connection problem.

            Show
            Davo Smith added a comment - There is now a patch for this available here: https://github.com/davosmith/moodle/tree/MDL-31110_loading_animation Diff here: https://github.com/davosmith/moodle/commit/1a8cf49d9b7ff8fe744f4da07a1caf1ea2d5025c This hides the loading spinner before the 'file too big' message is shown. It also hides the spinner as soon as the AJAX call completes (whether or not it is successful) and, for good measure, shows an error message if there was a server connection problem.
            Hide
            Sam Hemelryk added a comment -

            Hi Davo,
            Changes look spot on thanks, feel free to put it up for integration when you're ready.
            If you can't let me know and I'll put it up for integration for you and try to remember to do so next time.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Hi Davo, Changes look spot on thanks, feel free to put it up for integration when you're ready. If you can't let me know and I'll put it up for integration for you and try to remember to do so next time. Cheers Sam
            Hide
            Davo Smith added a comment -

            I don't appear to be able to put issues up for integration (I've only been able to claim issues and ask for peer reviews since Saturday, so one step at a time ...)

            Show
            Davo Smith added a comment - I don't appear to be able to put issues up for integration (I've only been able to claim issues and ask for peer reviews since Saturday, so one step at a time ...)
            Hide
            Sam Hemelryk added a comment -

            Up for integration, thanks Davo!

            Show
            Sam Hemelryk added a comment - Up for integration, thanks Davo!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Davo Smith added a comment -

            Rebased as requested

            Show
            Davo Smith added a comment - Rebased as requested
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            Rajesh Taneja added a comment -

            Works Great.
            Thanks for fixing this Davo. Awesome work

            Show
            Rajesh Taneja added a comment - Works Great. Thanks for fixing this Davo. Awesome work
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

            Nah, joking, many thanks! Closing this a fixed, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: