Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Go to course -> forum
      3. Add new discussion (note: For this test to happen the maximum number of attachments needs to be set to 1 so that dragging 2 files are one too many)
      4. Select two files on desktop and drag them to file area
      5. Color and text should change in file area while the mouse button is pressed
      6. Drop the files on file area
      7. Error message should be displayed, and one file will be attached.
      8. Delete the attached file and now drag and drop one file
      9. check for color and text on file area (it should be changed) and file should be attached.
      10. delete the file

      supplemental test: try to break thsi awesome dnd and report/comment about any issues.

      Show
      Log in as admin Go to course -> forum Add new discussion (note: For this test to happen the maximum number of attachments needs to be set to 1 so that dragging 2 files are one too many) Select two files on desktop and drag them to file area Color and text should change in file area while the mouse button is pressed Drop the files on file area Error message should be displayed, and one file will be attached. Delete the attached file and now drag and drop one file check for color and text on file area (it should be changed) and file should be attached. delete the file supplemental test: try to break thsi awesome dnd and report/comment about any issues.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31114_dnd_ui_improvements
    • Rank:
      37543

      Description

      1. Currently Drag and drop show colour change, it will be nice to change text stating "Drop the files in this area" (Like gmail)
      2. After maximum file upload is reached (for file manager), DND event should show error message that you can't upload more then x files

        Issue Links

          Activity

          Rajesh Taneja created issue -
          Rajesh Taneja made changes -
          Field Original Value New Value
          Link This issue discovered while testing MDL-29766 [ MDL-29766 ]
          Michael de Raadt made changes -
          Summary Few improvement in Drag and drop Improvements in drag-and-drop
          Fix Version/s DEV backlog [ 10464 ]
          Description # Currently Drag and drop show color change, it will be nice to change text stating "Drop the files in this area" (Like gmail)
          # After maximum file upload is reached (for file manager), DND event should show error message that you can't upload more then x files
          # Currently Drag and drop show colour change, it will be nice to change text stating "Drop the files in this area" (Like gmail)
          # After maximum file upload is reached (for file manager), DND event should show error message that you can't upload more then x files
          Labels triaged
          Davo Smith made changes -
          Assignee moodle.com [ moodle.com ] Davo Smith [ davosmith ]
          Davo Smith made changes -
          Pull Master Diff URL https://github.com/davosmith/moodle/compare/master...MDL-31114_dnd_ui_improvements
          Pull Master Branch MDL-31114_dnd_ui_improvements
          Pull from Repository https://github.com/davosmith/moodle
          Labels triaged patch triaged
          Component/s Forms Library [ 10091 ]
          Component/s Files API [ 10305 ]
          Davo Smith made changes -
          Status Open [ 1 ] Waiting for peer review [ 10012 ]
          Sam Hemelryk made changes -
          Original Estimate 0 minutes [ 0 ]
          Remaining Estimate 0 minutes [ 0 ]
          Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
          Peer reviewer samhemelryk
          Sam Hemelryk made changes -
          Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
          Davo Smith made changes -
          Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
          Rajesh Taneja made changes -
          Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
          Testing Instructions # Log in as admin
          # Go to course -> forum
          # Add new discussion
          # Select two files on desktop and drag them to file area
          # Color and text should change in file area while the mouse button is pressed
          # Drop the files on file area
          # Error message should be displayed, and one file will be attached.
          # Delete the attached file and now drag and drop one file
          # check for color and text on file area (it should be changed) and file should be attached.
          # delete the file
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Aparup Banerjee made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator nebgor
          Aparup Banerjee made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.3 [ 10657 ]
          Affects Version/s 2.2.1 [ 11456 ]
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s DEV backlog [ 10464 ]
          Aparup Banerjee made changes -
          Testing Instructions # Log in as admin
          # Go to course -> forum
          # Add new discussion
          # Select two files on desktop and drag them to file area
          # Color and text should change in file area while the mouse button is pressed
          # Drop the files on file area
          # Error message should be displayed, and one file will be attached.
          # Delete the attached file and now drag and drop one file
          # check for color and text on file area (it should be changed) and file should be attached.
          # delete the file
          # Log in as admin
          # Go to course -> forum
          # Add new discussion
          # Select two files on desktop and drag them to file area
          # Color and text should change in file area while the mouse button is pressed
          # Drop the files on file area
          # Error message should be displayed, and one file will be attached.
          # Delete the attached file and now drag and drop one file
          # check for color and text on file area (it should be changed) and file should be attached.
          # delete the file

          supplemental test: try to break thsi awesome dnd and report/comment about any issues.
          Andrew Davis made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester andyjdavis
          Andrew Davis made changes -
          Status Testing in progress [ 10011 ] Waiting for testing [ 10005 ]
          Andrew Davis made changes -
          Tester andyjdavis
          Rajesh Taneja made changes -
          Link This issue caused a regression MDL-31639 [ MDL-31639 ]
          Aparup Banerjee made changes -
          Testing Instructions # Log in as admin
          # Go to course -> forum
          # Add new discussion
          # Select two files on desktop and drag them to file area
          # Color and text should change in file area while the mouse button is pressed
          # Drop the files on file area
          # Error message should be displayed, and one file will be attached.
          # Delete the attached file and now drag and drop one file
          # check for color and text on file area (it should be changed) and file should be attached.
          # delete the file

          supplemental test: try to break thsi awesome dnd and report/comment about any issues.
          # Log in as admin
          # Go to course -> forum
          # Add new discussion (note: For this test to happen the maximum number of attachments needs to be set to 1 so that dragging 2 files are one too many)
          # Select two files on desktop and drag them to file area
          # Color and text should change in file area while the mouse button is pressed
          # Drop the files on file area
          # Error message should be displayed, and one file will be attached.
          # Delete the attached file and now drag and drop one file
          # check for color and text on file area (it should be changed) and file should be attached.
          # delete the file

          supplemental test: try to break thsi awesome dnd and report/comment about any issues.
          Andrew Davis made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester andyjdavis
          Andrew Davis made changes -
          Link This issue testing discovered MDL-31641 [ MDL-31641 ]
          Andrew Davis made changes -
          Link This issue testing discovered MDL-31642 [ MDL-31642 ]
          Andrew Davis made changes -
          Link This issue testing discovered MDL-31643 [ MDL-31643 ]
          Andrew Davis made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Eloy Lafuente (stronk7) made changes -
          Integration date 17/Feb/12

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: