Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31130

"Show all X/Show Y per page" in questions list does not toggle

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4
    • Fix Version/s: 2.0.8, 2.1.5, 2.2.2
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      1. Find (or create) a course with more than 20 questions in the question bank.

      2. Make sure the Show all / show 20 and paging links work.

      Show
      1. Find (or create) a course with more than 20 questions in the question bank. 2. Make sure the Show all / show 20 and paging links work.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      In 'Question bank > Questions' with a question count of greater than DEFAULT_QUESTIONS_PER_PAGE (20), click the 'Show all X' link at the bottom the page and then click the 'Show 20 per page' link after the page refresh. Note that nothing changes; the qperpage URL parameter still indicates 1000. Attached patch fixes this.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            I will try to take a look soon. Thanks for the suggested fix.

            Show
            timhunt Tim Hunt added a comment - I will try to take a look soon. Thanks for the suggested fix.
            Hide
            timhunt Tim Hunt added a comment -

            Thanks for the fix Jonathon.

            For future reference, it is helpful if you can:

            1. Submit your patch using the git format-patch command. That way, I can apply it using git am.

            2. Write a commit message that follows the Moodle standard. http://docs.moodle.org/dev/Commit_cheat_sheet#Provide_clear_commit_messages

            Show
            timhunt Tim Hunt added a comment - Thanks for the fix Jonathon. For future reference, it is helpful if you can: 1. Submit your patch using the git format-patch command. That way, I can apply it using git am. 2. Write a commit message that follows the Moodle standard. http://docs.moodle.org/dev/Commit_cheat_sheet#Provide_clear_commit_messages
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys - this has been integrated now
            Hide
            abgreeve Adrian Greeve added a comment -

            I created a list of quiz questions (22) and checked to make sure that when clicking on the 'Show all / Show 22' link that it did actually display all of the questions.
            Test passed.

            Show
            abgreeve Adrian Greeve added a comment - I created a list of quiz questions (22) and checked to make sure that when clicking on the 'Show all / Show 22' link that it did actually display all of the questions. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            This is now available in the git and cvs repositories.

            Consider the responsibility of your fingerprints engraved there for future generations!

            Thanks for the work, closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - This is now available in the git and cvs repositories. Consider the responsibility of your fingerprints engraved there for future generations! Thanks for the work, closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12