Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Calendar
    • Labels:
    • Rank:
      37563

      Description

      Location: /calendar/lib.php

      remove the following deprecated define

      define('CALENDAR_STARTING_WEEKDAY', CALENDAR_DEFAULT_STARTING_WEEKDAY);
      

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          sending for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - sending for integration. Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.

          Show
          Dan Poltawski added a comment - Delaying till the start of the 2.4 dev cycle. We don't want any more big changes for now.
          Hide
          Ankit Agarwal added a comment -

          adding to sprint 22, so that this doesnt get forgotten.
          Thanks

          Show
          Ankit Agarwal added a comment - adding to sprint 22, so that this doesnt get forgotten. Thanks
          Hide
          Ankit Agarwal added a comment -

          submitting for integration. As removing deprecated code is now done early in the dev cycle.

          Show
          Ankit Agarwal added a comment - submitting for integration. As removing deprecated code is now done early in the dev cycle.
          Hide
          Sam Hemelryk added a comment -

          Sneaking this into integration... shhh...

          Show
          Sam Hemelryk added a comment - Sneaking this into integration... shhh...
          Hide
          Sam Hemelryk added a comment -

          and in it goes, thanks Ankit, good to get this sort of thing landing early in the dev cycle.

          Show
          Sam Hemelryk added a comment - and in it goes, thanks Ankit, good to get this sort of thing landing early in the dev cycle.
          Hide
          Frédéric Massart added a comment -

          What a test! Passes. Thanks !

          Show
          Frédéric Massart added a comment - What a test! Passes. Thanks !
          Hide
          Dan Poltawski added a comment -

          *Notice*: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26

          Congratulations

          {tracker.user.name}

          !

          You've made into Moodle

          {tracker.fixversion-1}

          +

          I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world.

          cheers!

          {tracker.friendlyintegrator}
          Show
          Dan Poltawski added a comment - * Notice *: Undefined variable: friendlyintegrator in /Users/danp/git/tokenintegrationthanks.php on line 26 Congratulations {tracker.user.name} ! You've made into Moodle {tracker.fixversion-1} + I would like to personally thank you for this contribution on behalf of all Moodle users throughout the world. cheers! {tracker.friendlyintegrator}

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: