Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29561 Pulling together all outstanding issues with Anomaly
  3. MDL-31144

DOCKED Navigation block sub-level menu items are hidden in all CORE themes

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2.1
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Environment:
      MacOS Server 10.6
    • Database:
      Any
    • Testing Instructions:
      Hide

      As this affects the sub-levels of the Navigation block tree it is necessary to have at least four levels or more, in the navigation menu before you can see any appreciable change in the width of the docked panel.But as each link is selected the panel should expand to allow the user to view them, which was not possible previously.

      1. Test ALL CORE themes which have DOCK enabled
      2. Dock Navigation block
      3. Test to see if the docked content panel expands (width ways) as each sub-level is selected.
      4. Repeat this in all notable browsers. Particularly the minimum supported versions of the browsers. (ie IE8 )
      Show
      As this affects the sub-levels of the Navigation block tree it is necessary to have at least four levels or more, in the navigation menu before you can see any appreciable change in the width of the docked panel.But as each link is selected the panel should expand to allow the user to view them, which was not possible previously. Test ALL CORE themes which have DOCK enabled Dock Navigation block Test to see if the docked content panel expands (width ways) as each sub-level is selected. Repeat this in all notable browsers. Particularly the minimum supported versions of the browsers. (ie IE8 )
    • Workaround:
      Hide

      The fix is easy but will need you to change a value in the anomaly/style/dock.css

      At about line: 75 you should see this CSS mark-up...where you should change the value from width: 180px; to min-width: 200px; as indicated below.

      /*
      Docked Item Panel
      -----------------------*/
      #dockeditempanel {
          width: 180px;
          min-width: 200px;
          position: relative;
          z-index: 12000;
          left: 100%;
      }

      Show
      The fix is easy but will need you to change a value in the anomaly/style/dock.css At about line: 75 you should see this CSS mark-up...where you should change the value from width: 180px; to min-width: 200px; as indicated below. /* Docked Item Panel -----------------------*/ #dockeditempanel { width: 180px; min-width: 200px; position: relative; z-index: 12000; left: 100%; }
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      After an upgrade to 2.2 from 2.1 when a Navigation block is docked and hovered over for access, the right side is cut off. This impacts at least the Serenity and Anomoly themes. It really only impacts the words of the results section of a quiz, but could impact future additions like this to the Navigation block.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for reporting this and suggesting a solution.

              Show
              salvetore Michael de Raadt added a comment - Thanks for reporting this and suggesting a solution.
              Hide
              lazydaisy Mary Evans added a comment -

              That's because I told Jim how to fix this!

              However this look like a global bug as it affects all themes, so I may just make the alteration in Base theme and remove the width setting in all the themes that have dock.css.

              Cheers
              Mary

              Show
              lazydaisy Mary Evans added a comment - That's because I told Jim how to fix this! However this look like a global bug as it affects all themes, so I may just make the alteration in Base theme and remove the width setting in all the themes that have dock.css. Cheers Mary
              Hide
              weathertation Jim Peterson added a comment -

              Sorry Mary. I should have given you credit in the workaround. I only get credit for reporting the bug, and not much at that because I had a teacher report it to me and I could not fix it or find a fix.

              Show
              weathertation Jim Peterson added a comment - Sorry Mary. I should have given you credit in the workaround. I only get credit for reporting the bug, and not much at that because I had a teacher report it to me and I could not fix it or find a fix.
              Hide
              lazydaisy Mary Evans added a comment -

              LOL...don't worry about it. No offence taken.

              Show
              lazydaisy Mary Evans added a comment - LOL...don't worry about it. No offence taken.
              Hide
              lazydaisy Mary Evans added a comment -

              Hi Jim this turned out to be easier than I thought. You will like the effect of this fix.

              Cheers
              Mary

              Show
              lazydaisy Mary Evans added a comment - Hi Jim this turned out to be easier than I thought. You will like the effect of this fix. Cheers Mary
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Mary - I've integrated this now. I'm back working from HQ office presently. I've tested this in the latest Chrome and FF, however I can't test in older browsers and importantly IE8 (as we don't support IE7 in 2.3 Hoorah!)

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Mary - I've integrated this now. I'm back working from HQ office presently. I've tested this in the latest Chrome and FF, however I can't test in older browsers and importantly IE8 (as we don't support IE7 in 2.3 Hoorah!)
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Noticed the issue still occurs in afterburner theme. Creating new tracker - MDL-31231.
              Other themes are fine.

              Currently, I can't access my IE's VM. Will ask other developer to test this on IE8.

              Show
              rwijaya Rossiani Wijaya added a comment - Noticed the issue still occurs in afterburner theme. Creating new tracker - MDL-31231 . Other themes are fine. Currently, I can't access my IE's VM. Will ask other developer to test this on IE8.
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Thank you Jason for fixing my IE's VM.

              Tested this in IE8, the patch works great in all themes except for afterburner theme.

              Passing this issue.

              Show
              rwijaya Rossiani Wijaya added a comment - Thank you Jason for fixing my IE's VM. Tested this in IE8, the patch works great in all themes except for afterburner theme. Passing this issue.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              This is now available in the git and cvs repositories.

              Consider the responsibility of your fingerprints engraved there for future generations!

              Thanks for the work, closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - This is now available in the git and cvs repositories. Consider the responsibility of your fingerprints engraved there for future generations! Thanks for the work, closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12