Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31147

META: Collect together deprecated code changes for Moodle 2.3

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE

      Description

      There are a number of parts of the Moodle codebase that have been marked as deprecated as a warning to developers not to use these functions as they will be removed in future. Many have a deadline of 2.3.

      Each of these deprecated functions, especially those in Moodle core code, should have an MDL issue associated with it.

      In order to time the removal of these deprecated functio issues and not lose sight of them, this issue will be used to collect them together.2

        Gliffy Diagrams

          Issue Links

          1.
          Remove deprecated calendar_get_link_tag() function in calendar/lib.php Sub-task Closed Ankit Agarwal
           
          2.
          Remove deprecated function in calendar/lib.php Sub-task Closed Ankit Agarwal
           
          3.
          remove deprecated define in calendar/lib.php Sub-task Closed Ankit Agarwal
           
          4.
          Remove the deprecated functions and classes from lib/pagelib.php Sub-task Closed Rajesh Taneja
           
          5.
          remove message_get_my_providers() from lib/messagelib.php Sub-task Closed Rajesh Taneja
           
          6.
          Clear out /message/send_form.php Sub-task Closed Andrew Davis
           
          7.
          Remove deprecated functions in moodle_database Sub-task Closed Aparup Banerjee
           
          8.
          Deprecated PARAM_INTEGER should be replaced with PARAM_INT Sub-task Closed Rajesh Taneja
           
          9.
          remove deprecated functions for string api Sub-task Closed moodle.com
           
          10.
          Remove deprecated functions in lib/formslib.php Sub-task Closed Rajesh Taneja
           
          11.
          Remove deprecated function for old file manager Sub-task Closed Rossiani Wijaya
           
          12.
          Delete deprecated message_get_participants() in message/lib.php Sub-task Closed Andrew Davis
           
          13.
          Delete deprecated assignment_get_participants() in assignment/lib.php Sub-task Closed Ankit Agarwal
           
          14.
          remove chat_get_participants() from chat/lib.php Sub-task Closed Rajesh Taneja
           
          15.
          remove choice_get_participants() from code Sub-task Closed Dan Marsden
           
          16.
          remove data_get_participants() from code as its deprecated Sub-task Closed Ankit Agarwal
           
          17.
          remove feedback_get_participants() from code Sub-task Closed Ankit Agarwal
           
          18.
          delete folder_get_participants() from the core code Sub-task Closed Ankit Agarwal
           
          19.
          remove forum_get_participants() from forum/lib.php Sub-task Closed Ankit Agarwal
           
          20.
          glossary_get_participants needs to be removed from the code Sub-task Closed Jason Fowler
           
          21.
          shoot imscp_get_participants() out of the core code Sub-task Closed Jason Fowler
           
          22.
          kill label_get_participants() Sub-task Closed Jason Fowler
           
          23.
          remove lesson_get_participants() Sub-task Closed Rossiani Wijaya
           
          24.
          put page_get_participants() to rest Sub-task Closed Jason Fowler
           
          25.
          remove resource_get_participants() from core Sub-task Closed Jason Fowler
           
          26.
          Delete deprecated stuff that was supposed to be deleted before 2.2 Sub-task Closed Ankit Agarwal
           
          27.
          Deprecated PARAM_NUMBER should be replaced with PARAM_FLOAT Sub-task Closed Rajesh Taneja
           
          28.
          Deprecated PARAM_ACTION and PARAM_FORMAT should be replaced with PARAM_ALPHANUMEXT Sub-task Closed Rajesh Taneja
           
          29.
          Deprecated PARAM_MULTILANG should be replaced with PARAM_TEXT Sub-task Closed Rajesh Taneja
           

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            We can probably bump the rest of these to 2.4, given the amount of other important stuff for 2.3.

            Show
            dougiamas Martin Dougiamas added a comment - We can probably bump the rest of these to 2.4, given the amount of other important stuff for 2.3.
            Hide
            salvetore Michael de Raadt added a comment -

            After discussing this with Dan, we decided on a policy for this. We will start removing deprecated code a lot earlier in the Major version cycle. We will start working on deprecations for 2.4 soon after 2.3 is released. Obviously these changes will be limited to master and will only come into affect in a public release when 2.4 is released.

            Show
            salvetore Michael de Raadt added a comment - After discussing this with Dan, we decided on a policy for this. We will start removing deprecated code a lot earlier in the Major version cycle. We will start working on deprecations for 2.4 soon after 2.3 is released. Obviously these changes will be limited to master and will only come into affect in a public release when 2.4 is released.
            Hide
            salvetore Michael de Raadt added a comment -

            Shifting this to a sprint after 2.3.1.

            Show
            salvetore Michael de Raadt added a comment - Shifting this to a sprint after 2.3.1.
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks Ankit for managing this issue.

            I'm assigning this to Eloy as he has the last remaining sub-task.

            Show
            salvetore Michael de Raadt added a comment - Thanks Ankit for managing this issue. I'm assigning this to Eloy as he has the last remaining sub-task.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Finally closing this. The pending task (old-filters, MDL-29996) has been moved to deprecation on MDL-31207 (2.5). Petr has implemented it together with some cleanup.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Finally closing this. The pending task (old-filters, MDL-29996 ) has been moved to deprecation on MDL-31207 (2.5). Petr has implemented it together with some cleanup. Ciao
            Hide
            marina Marina Glancy added a comment -

            $ git grep MDL-31147
            lib/ddl/mssql_sql_generator.php:     * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL()
            lib/ddl/mysql_sql_generator.php:     * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL()
            lib/ddl/oracle_sql_generator.php:     * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL()
            lib/ddl/postgres_sql_generator.php:     * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL()
            lib/ddl/sql_generator.php:     * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL()
            lib/ddl/sqlite_sql_generator.php:     * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL()
            

            Please note that all issues that are closed as resolved or won't fix but still have remaining TODO or @todo in core are linked to MDL-47779 as "causing regressions".

            The link will be removed when all TODOs are removed (under another issue)

            Show
            marina Marina Glancy added a comment - $ git grep MDL-31147 lib/ddl/mssql_sql_generator.php: * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL() lib/ddl/mysql_sql_generator.php: * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL() lib/ddl/oracle_sql_generator.php: * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL() lib/ddl/postgres_sql_generator.php: * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL() lib/ddl/sql_generator.php: * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL() lib/ddl/sqlite_sql_generator.php: * @todo MDL-31147 Moodle 2.1 - Drop getDropDefaultSQL() Please note that all issues that are closed as resolved or won't fix but still have remaining TODO or @todo in core are linked to MDL-47779 as "causing regressions". The link will be removed when all TODOs are removed (under another issue)

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12