Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31152

tag/lib.php todo: Check if commented out piece of code "helps performance without breaking anything"

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.2
    • Fix Version/s: None
    • Component/s: Tags
    • Labels:

      Description

      This issue is creating an associated MDL for an orphan TODO in tag/lib.php, which I came across while working on [MDL-30992]...

      tag/lib.php

      //TODO: test this and see if it helps performance without breaking anything
      //foreach($tags as $key => $tag) {
      //    $clean_tag = moodle_strtolower($tag);
      //    if ( array_key_exists($clean_tag), $tag_id_cache) ) {
      //        $result[$clean_tag] = $tag_id_cache[$clean_tag];
      //        $tags[$key] = ''; // prevent further processing for this one.
      //    }
      //}

      The above code is an extract from the tag_get_id() function in tag/lib.php. The todo comment pretty much says it all.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              gerry Gerard Caulfield
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: