Moodle
  1. Moodle
  2. MDL-31153

Drag and drop upload - awesome feature, but long text is long

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      1. Go to the 'Add a resource / File' form.
      + Check that the text next to the file upload is reasonably short. Example:

      Maximum size for new files: 110MB - drag and drop available

      2. Go to the course 'Restore' form.
      + Check that the text is reasonably short. Example:

      No files attached - drag and drop available

      Show
      1. Go to the 'Add a resource / File' form. + Check that the text next to the file upload is reasonably short. Example: Maximum size for new files: 110MB - drag and drop available 2. Go to the course 'Restore' form. + Check that the text is reasonably short. Example: No files attached - drag and drop available
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-31153-master
    • Rank:
      37594

      Description

      The text for d+d upload is:

      'You can drag and drop files into this box to upload them'

      Then it has a help button.

      The help button makes the long text unnecessary on every form. It should be replaced with shorter text while maintaining the help button. In addition, because this text appears as part of a 'sentence'...

      Maximum size for new files: 110MB - You can drag and drop files into this box to upload them

      ...it should be lower-case rather than upper-case. (Upper case should be retained for the help button.)

        Activity

        Hide
        Sam Marshall added a comment - - edited

        My suggested changes are attached. Rationale:

        1) Shorter: reduced clutter, simpler. (Detailed text still available via help button for multi drag/drop; 'drag and drop available' is enough to tell you that the feature is turned on, and if you're unsure how to use it, to indicate that you should click the help button.)

        2) I redefined the meaning of the two strings, which were 'single vs multi' and are now just 'in middle of a sentence vs. used as a heading'.
        a) I didn't see a large benefit in telling you how many files you can drag/drop (one vs many); it is generally obvious and there is a 'Choose a file...' (singular) button just above.
        b) The capital letter in middle of sentence looked pretty ugly.

        Submitting for review. From an OU point of view I don't care whether this change is made or not. Just noticed it, and trying to make Moodle a teeensy bit better.

        by the way - much respect to the people who got this feature implemented in the first place, no doubt they are going to be celebrated in street parties and probably will become next presidents of their respective countries based on the popularity gained by this feature.

        Show
        Sam Marshall added a comment - - edited My suggested changes are attached. Rationale: 1) Shorter: reduced clutter, simpler. (Detailed text still available via help button for multi drag/drop; 'drag and drop available' is enough to tell you that the feature is turned on, and if you're unsure how to use it, to indicate that you should click the help button.) 2) I redefined the meaning of the two strings, which were 'single vs multi' and are now just 'in middle of a sentence vs. used as a heading'. a) I didn't see a large benefit in telling you how many files you can drag/drop (one vs many); it is generally obvious and there is a 'Choose a file...' (singular) button just above. b) The capital letter in middle of sentence looked pretty ugly. Submitting for review. From an OU point of view I don't care whether this change is made or not. Just noticed it, and trying to make Moodle a teeensy bit better. by the way - much respect to the people who got this feature implemented in the first place, no doubt they are going to be celebrated in street parties and probably will become next presidents of their respective countries based on the popularity gained by this feature.
        Hide
        Davo Smith added a comment -

        The text of the original version of my patch read 'Drag and drop upload enabled': https://github.com/davosmith/moodle/commit/e74580a09dec272e4d7ca789d4b06fe89333a35d#diff-2
        (for exactly the reason you stated - to avoid it being too long).

        But it was argued that this did not make the functionality clear enough to new users, so the longer text was added instead (an argument I can also agree with).

        I'm not personally worried about it either way, but you can see the full discussion at MDL-29766

        As for street parties, I'm too busy trying to work out if I can get drag and drop working onto course pages (like my block, but integrated into core and better implemented)

        Show
        Davo Smith added a comment - The text of the original version of my patch read 'Drag and drop upload enabled': https://github.com/davosmith/moodle/commit/e74580a09dec272e4d7ca789d4b06fe89333a35d#diff-2 (for exactly the reason you stated - to avoid it being too long). But it was argued that this did not make the functionality clear enough to new users, so the longer text was added instead (an argument I can also agree with). I'm not personally worried about it either way, but you can see the full discussion at MDL-29766 As for street parties, I'm too busy trying to work out if I can get drag and drop working onto course pages (like my block, but integrated into core and better implemented)
        Hide
        Sam Marshall added a comment -

        Interesting. Yeah, I disagree with (the other) Sam. The feature is perfectly discoverable with the shorter text; it would be more questionable without the help button, but since it has one...

        I don't think the longer text adds anything at all: if you know how to drag and drop things (which both long and short text requires) then you are good to go. Or at least to know whether you should probably click the help button for more info, or not; if you don't know what drag and drop is and whether it might be any use, then you're still screwed.

        Show
        Sam Marshall added a comment - Interesting. Yeah, I disagree with (the other) Sam. The feature is perfectly discoverable with the shorter text; it would be more questionable without the help button, but since it has one... I don't think the longer text adds anything at all: if you know how to drag and drop things (which both long and short text requires) then you are good to go. Or at least to know whether you should probably click the help button for more info, or not; if you don't know what drag and drop is and whether it might be any use, then you're still screwed.
        Hide
        Sam Marshall added a comment -

        By the way, to note - we do have professional editors here if anyone wants me to ask one.

        Show
        Sam Marshall added a comment - By the way, to note - we do have professional editors here if anyone wants me to ask one.
        Hide
        Davo Smith added a comment -

        I don't want to get into the middle of a fight between two Sams!

        If you want to bring in a professional editor or user experience expert, be my guest.

        I don't have any authority to accept or reject your patch anyway, so I can't help either way (so I'll just get back to all the minor bugs that showed up during testing).

        Show
        Davo Smith added a comment - I don't want to get into the middle of a fight between two Sams! If you want to bring in a professional editor or user experience expert, be my guest. I don't have any authority to accept or reject your patch anyway, so I can't help either way (so I'll just get back to all the minor bugs that showed up during testing).
        Hide
        Sam Hemelryk added a comment -

        Let the war begin! (jokes )

        Show
        Sam Hemelryk added a comment - Let the war begin! (jokes )
        Hide
        Sam Hemelryk added a comment -

        Gets my +1 for integration. Certainly good rationale behind it thanks guys.

        Still the coolest feature to land in 2012 so far!

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Gets my +1 for integration. Certainly good rationale behind it thanks guys. Still the coolest feature to land in 2012 so far! Cheers Sam
        Hide
        Sam Marshall added a comment -

        thanks Sam, I guess this is a ceasefire then. Submitting.

        And yes, definitely coolest feature.

        Show
        Sam Marshall added a comment - thanks Sam, I guess this is a ceasefire then. Submitting. And yes, definitely coolest feature.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Marshall added a comment -

        Rebased

        Show
        Sam Marshall added a comment - Rebased
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Rajesh Taneja added a comment -

        Thanks for fixing this Sam,
        Text is short and sweet

        Show
        Rajesh Taneja added a comment - Thanks for fixing this Sam, Text is short and sweet
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

        Nah, joking, many thanks! Closing this a fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: