Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: STABLE backlog
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select Sky High theme
      2. Try printing off an Activity Report (Todays Logs) from within MyDashboard Navigation Menu (you can view as a Print Preview to save printing)
      3. Test with ALL side blocks DOCKED
      4. Test to see if printing truncates after a few lines and that there are no dock titles on the side.
      5. UN-DOCK all blocks and TEST as (4) above checkig to see that no side block text is visible.
      Show
      Select Sky High theme Try printing off an Activity Report (Todays Logs) from within MyDashboard Navigation Menu (you can view as a Print Preview to save printing) Test with ALL side blocks DOCKED Test to see if printing truncates after a few lines and that there are no dock titles on the side. UN-DOCK all blocks and TEST as (4) above checkig to see that no side block text is visible.
    • Workaround:
      Hide

      Change theme to Standard theme.

      Show
      Change theme to Standard theme.
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
    • Rank:
      37606

      Description

      This seems to be an ongoing problem with Sky High, because of it's particular page layout, that tends to truncate some report types.

        Activity

        Hide
        Mary Evans added a comment -

        @Dietmar
        I have added you as a watcher.

        I have just set up this sub-task issue with the view of fixing this, this weekend. I'm going to attempt to change the footer in all Sky High layout files and maybe create an Admin layout page, or change config.php to use report.php for Admin and add CSS like we did in MDL-30500. This will depend largely on the result of what the report.php looks like as an Admin page.

        Cheers
        Mary

        Show
        Mary Evans added a comment - @Dietmar I have added you as a watcher. I have just set up this sub-task issue with the view of fixing this, this weekend. I'm going to attempt to change the footer in all Sky High layout files and maybe create an Admin layout page, or change config.php to use report.php for Admin and add CSS like we did in MDL-30500 . This will depend largely on the result of what the report.php looks like as an Admin page. Cheers Mary
        Hide
        Dietmar Wagner added a comment -

        Hi Mary,

        the main difference between pagelayout-admin (which is a side-pre-only general.php)
        and pagelayout-report is maximum usability (width:100%; smaller fonts) and print results.

        As a time saver I've attached a tested report.css that contains the necessary CSS for pagelayout-admin.

        Cheers
        Dietmar

        Show
        Dietmar Wagner added a comment - Hi Mary, the main difference between pagelayout-admin (which is a side-pre-only general.php) and pagelayout-report is maximum usability (width:100%; smaller fonts) and print results. As a time saver I've attached a tested report.css that contains the necessary CSS for pagelayout-admin. Cheers Dietmar
        Hide
        Mary Evans added a comment -

        Hi Dietmar,

        I already made an admin.css to keep the styles separate, I thought it was easier for integration, saves confusion.

        I also added one more line to the @media for both .pagelayout-report and .pagelayout-admin for selector #report-region-pre

        {display: none;}

        because if a user forgets to dock the side blocks, especially if they are rushing to print off a copy for a meeting when they are already late...the side block text gets written over the report text!

        Prints a perfect copy with no truncation! The only drawback is that there is not corporate logo. However, this I can do as a separate item later, perhaps even add it as a settings option maybe

        Anyway I'm halfway getting this done now.

        Cheers
        Mary

        Show
        Mary Evans added a comment - Hi Dietmar, I already made an admin.css to keep the styles separate, I thought it was easier for integration, saves confusion. I also added one more line to the @media for both .pagelayout-report and .pagelayout-admin for selector #report-region-pre {display: none;} because if a user forgets to dock the side blocks, especially if they are rushing to print off a copy for a meeting when they are already late...the side block text gets written over the report text! Prints a perfect copy with no truncation! The only drawback is that there is not corporate logo. However, this I can do as a separate item later, perhaps even add it as a settings option maybe Anyway I'm halfway getting this done now. Cheers Mary
        Hide
        Mary Evans added a comment -

        @Julian

        I've added you as a watcher to keep you in the loop!

        Show
        Mary Evans added a comment - @Julian I've added you as a watcher to keep you in the loop!
        Hide
        Dietmar Wagner added a comment -

        Great, Mary!
        I too yesterday discovered that #region-pre

        {display:none;}

        could be a good idea!
        Did you make any changes for the footer?

        A header logo might be important in some situations (corporate identity)!

        Please keep me current!

        Cheers
        Dietmar

        Show
        Dietmar Wagner added a comment - Great, Mary! I too yesterday discovered that #region-pre {display:none;} could be a good idea! Did you make any changes for the footer? A header logo might be important in some situations (corporate identity)! Please keep me current! Cheers Dietmar
        Hide
        Mary Evans added a comment -

        Hi Dietmar,
        Yes I did do the changes for the footer, but have not added them yet. I was going to start a new MDL for that based on the fact that Sky High does not show Performance Info in footer.

        This will make it a legitimate opportunity to fix Sky High for good I rewrote the footer and added another div with id footer-links to take care of the problem and it works great now.

        I'll send you the css and the layout files for you to look at.

        Cheers
        Mary

        Show
        Mary Evans added a comment - Hi Dietmar, Yes I did do the changes for the footer, but have not added them yet. I was going to start a new MDL for that based on the fact that Sky High does not show Performance Info in footer. This will make it a legitimate opportunity to fix Sky High for good I rewrote the footer and added another div with id footer-links to take care of the problem and it works great now. I'll send you the css and the layout files for you to look at. Cheers Mary
        Hide
        Dietmar Wagner added a comment -

        Thanks in advance, Mary!
        Dietmar

        Show
        Dietmar Wagner added a comment - Thanks in advance, Mary! Dietmar
        Hide
        Sam Hemelryk added a comment -

        Thanks Mary - this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Mary - this has been integrated now
        Hide
        Rajesh Taneja added a comment -

        Thanks for fixing this, Mary.
        Nothing truncates.

        Few issues found, while testing:

        1. On report pages (Comments, bacups, logs etc) all blocks are appearing on left-hand side, whereas on other pages they appear on right-hand side.
        2. Background and footer image is not visible.

        Above issues are visible on 21, 22 and master. Please let me know if you want me to create new issues for the same.

        FYI: Passing this, as it is a different issue then reported.

        Show
        Rajesh Taneja added a comment - Thanks for fixing this, Mary. Nothing truncates. Few issues found, while testing: On report pages (Comments, bacups, logs etc) all blocks are appearing on left-hand side, whereas on other pages they appear on right-hand side. Background and footer image is not visible. Above issues are visible on 21, 22 and master. Please let me know if you want me to create new issues for the same. FYI: Passing this, as it is a different issue then reported.
        Hide
        Mary Evans added a comment -

        Thanks Rajesh for testing this.

        I am currently still working on Sky High theme MDL-31189 as there is another issue with the page footer. When I have fixed that, there is a possibility this report page will not be used.

        I'm hoping to get this next lot of changes up for integration this weekend.

        Cheers
        Mary

        Show
        Mary Evans added a comment - Thanks Rajesh for testing this. I am currently still working on Sky High theme MDL-31189 as there is another issue with the page footer. When I have fixed that, there is a possibility this report page will not be used. I'm hoping to get this next lot of changes up for integration this weekend. Cheers Mary
        Hide
        Rajesh Taneja added a comment -

        Thanks Mary

        Show
        Rajesh Taneja added a comment - Thanks Mary
        Hide
        Dietmar Wagner added a comment -

        Hi Mary,

        I know you are busy with several theme issues.

        So only some thoughts on this issue for the weekend or later .

        It seems as if we have to combine two functional requirements for the report pages:
        maximum usability and a consitent appearance related to colours, backgrounds, borders and so on!

        Can this be managed with a "centralized" report.php? [I am doubtful!]

        Should we favour the idea of a theme specific modified general.php which is really side-pre (that means has all the blocks at the left side)? [Much work for blog and side-post-only layouts]

        Is there any other option?

        Cheers
        Dietmar

        Show
        Dietmar Wagner added a comment - Hi Mary, I know you are busy with several theme issues. So only some thoughts on this issue for the weekend or later . It seems as if we have to combine two functional requirements for the report pages: maximum usability and a consitent appearance related to colours, backgrounds, borders and so on! Can this be managed with a "centralized" report.php? [I am doubtful!] Should we favour the idea of a theme specific modified general.php which is really side-pre (that means has all the blocks at the left side)? [Much work for blog and side-post-only layouts] Is there any other option? Cheers Dietmar
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This is now available in the git and cvs repositories.

        Consider the responsibility of your fingerprints engraved there for future generations!

        Thanks for the work, closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - This is now available in the git and cvs repositories. Consider the responsibility of your fingerprints engraved there for future generations! Thanks for the work, closing, ciao
        Hide
        Mary Evans added a comment -

        @Dietmar,

        Hi...yes it would be better to think of something to solve the problem with the Report/Report and the Admin/Report as this is getting crazy.

        It would make things much easier if there was a mechanism that sent ALL pagelayout-report/reports and pagelayout-admin/reports to a single report.php. Then restyle ADMIN dashboard and give it a NEWLOOK (new theme?) which was simple but stylish, that has three equal columns which could contain easy to identify block areas they need to access, with a toggle view of the site in FULL THEME view.

        I also think the Admin theme (if there was one or with options to change colour scheme) should be fixed and not an option after installation. In other words it should be part of Moodle CORE.

        Does this sound crazy?

        Show
        Mary Evans added a comment - @Dietmar, Hi...yes it would be better to think of something to solve the problem with the Report/Report and the Admin/Report as this is getting crazy. It would make things much easier if there was a mechanism that sent ALL pagelayout-report/reports and pagelayout-admin/reports to a single report.php. Then restyle ADMIN dashboard and give it a NEWLOOK (new theme?) which was simple but stylish, that has three equal columns which could contain easy to identify block areas they need to access, with a toggle view of the site in FULL THEME view. I also think the Admin theme (if there was one or with options to change colour scheme) should be fixed and not an option after installation. In other words it should be part of Moodle CORE. Does this sound crazy?
        Hide
        Dietmar Wagner added a comment -

        Hi Mary,

        all these report, admin and print layout related issues should be fixed asap.
        The idea to do this by developing an admin theme is not crazy at all!

        My problem: I do not yet completely understand how it should work!
        What should happen in your eyes when you log in as an administrator?

        Cheers
        Dietmar

        Show
        Dietmar Wagner added a comment - Hi Mary, all these report, admin and print layout related issues should be fixed asap. The idea to do this by developing an admin theme is not crazy at all! My problem: I do not yet completely understand how it should work! What should happen in your eyes when you log in as an administrator? Cheers Dietmar
        Hide
        Mary Evans added a comment - - edited

        Hi Dietmar,

        OK...I will try to explain my weltanschauungen on this topic.

        Have you ever used Joomla? In that case you will know that the Admin Dashboard looks different from the other areas of the main 'template'.

        I would like to see a dashboard where the Site Administrator can go directly into the settings, which would be grouped in order of relationship to each other, where these settings are accessed by clicking various icons similar to the types you see used on iPAD and for social media like Twitter & Facebook etc. In other words it would be a giant settings page of all the options an Admin needs to use to look after Moodle, to put it another way, it would be a GUI rather than the Settings block we have now with its complex tree menu system and scroll of death!

        Editing teachers would have a similar but smaller selection of these icons based on their privileges.

        When a Site Administrator wants to make changes to the look of the site, they can do this via the main theme settings' page, and toggle the view from Admin to User similar to role changing now.

        The Admin theme would be set in the Admin Profile similar to what you can do now. It would be no different than changing the way MyDashboard works now to simplify it.

        So perhaps this could be done by making a mydashboard.php which would be defined in config.php $THEME->layout and then all that needs to be done is work out how to build the component parts needed for the Admin Dashboard to work, write up the CSS and the jobs done!

        It's hard to describe perhaps I should make an image of what I see in my minds eye!

        Cheers
        Mary

        Show
        Mary Evans added a comment - - edited Hi Dietmar, OK...I will try to explain my weltanschauungen on this topic. Have you ever used Joomla? In that case you will know that the Admin Dashboard looks different from the other areas of the main 'template'. I would like to see a dashboard where the Site Administrator can go directly into the settings, which would be grouped in order of relationship to each other, where these settings are accessed by clicking various icons similar to the types you see used on iPAD and for social media like Twitter & Facebook etc. In other words it would be a giant settings page of all the options an Admin needs to use to look after Moodle, to put it another way, it would be a GUI rather than the Settings block we have now with its complex tree menu system and scroll of death! Editing teachers would have a similar but smaller selection of these icons based on their privileges. When a Site Administrator wants to make changes to the look of the site, they can do this via the main theme settings' page, and toggle the view from Admin to User similar to role changing now. The Admin theme would be set in the Admin Profile similar to what you can do now. It would be no different than changing the way MyDashboard works now to simplify it. So perhaps this could be done by making a mydashboard.php which would be defined in config.php $THEME->layout and then all that needs to be done is work out how to build the component parts needed for the Admin Dashboard to work, write up the CSS and the jobs done! It's hard to describe perhaps I should make an image of what I see in my minds eye! Cheers Mary

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: