Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31165

MySQL engine conversion tool does not work with mysql 5.5

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Environment:
      Linux 3.1.2
      PHP 5.3.8
      Mysql 5.5.19
      Apache 2
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      1/ install moodle on mysql 5.5 forcing myisam via dboptions in config.php $CFG->dboptions = array('dbengine'=>'MyISAM');
      2/ try conversion to innodb

      Show
      1/ install moodle on mysql 5.5 forcing myisam via dboptions in config.php $CFG->dboptions = array('dbengine'=>'MyISAM'); 2/ try conversion to innodb
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w03_MDL-31165_m23_innodbconv

      Description

      When I try to run mysql_engine.php --engine=InnoDB I got 'You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'TYPE = InnoDB' at line 1'

      The reason is, that I have MySQL 5.5 and it doesn't support "TYPE" table option. We have to use ENGINE option instead, but I don't know where to set it.

        Gliffy Diagrams

          Activity

          Hide
          skodak Petr Skoda added a comment -

          Thanks a lot for the report. This should be fixed in the next weekly build.

          Petr

          Show
          skodak Petr Skoda added a comment - Thanks a lot for the report. This should be fixed in the next weekly build. Petr
          Hide
          petko81 Peter Svec added a comment -

          Thanks for the patch. You should also modify admin/cli/mysql_engine.php on line 82

          Show
          petko81 Peter Svec added a comment - Thanks for the patch. You should also modify admin/cli/mysql_engine.php on line 82
          Hide
          skodak Petr Skoda added a comment -

          ah, I forgot we have that, thanks!

          Show
          skodak Petr Skoda added a comment - ah, I forgot we have that, thanks!
          Hide
          skodak Petr Skoda added a comment -

          fixed, thanks a lot again

          Show
          skodak Petr Skoda added a comment - fixed, thanks a lot again
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          My only point about this is why do we have one both scripts to perform the same task into different places. IMO it would be better to have tool/innodb/cli/innodb.php and done (I know current cli allows to specify instead of harcoding but perhaps it would be a matter of allow to specify in both).

          For your consideration, feel free to create new issue about such homogenization. I'm going to integrate this now. Thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - My only point about this is why do we have one both scripts to perform the same task into different places. IMO it would be better to have tool/innodb/cli/innodb.php and done (I know current cli allows to specify instead of harcoding but perhaps it would be a matter of allow to specify in both). For your consideration, feel free to create new issue about such homogenization. I'm going to integrate this now. Thanks!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          phalacee Jason Fowler added a comment -

          Passed perfectly

          Show
          phalacee Jason Fowler added a comment - Passed perfectly
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          This is now available in the git and cvs repositories.

          Consider the responsibility of your fingerprints engraved there for future generations!

          Thanks for the work, closing, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - This is now available in the git and cvs repositories. Consider the responsibility of your fingerprints engraved there for future generations! Thanks for the work, closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12