Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.3
    • Component/s: General
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE

      Description

      This is a meta issue for PHP strict related problems, see also for MDL-31004 for issues that are PHP 5.4 specific (some strict issues become notices which breaks debug mode in Moodle 2.2).

      Please create subtasks as necessary, the target is to get everything fixed before 2.3 release.

        Gliffy Diagrams

          Attachments

            Issue Links

            1.
            include E_STRICT in DEBUG_DEVELOPER starting in 2.3 Sub-task Closed Petr Skoda
             
            2.
            fix strict PHP notices - part 1 Sub-task Closed Petr Skoda
             
            3.
            fix strict PHP notices - part 2 Sub-task Closed Petr Skoda
             
            4.
            fix strict PHP notices - part 3 Sub-task Closed Petr Skoda
             
            5.
            Consider updating to simpletest 1.1.0 for 2.3 and upwards Sub-task Closed Petr Skoda
             
            6.
            Error reported with PHP Strict for menu custom profile fields Sub-task Closed Petr Skoda
             
            7.
            E_STRICT issue logging in when custom field are defined Sub-task Closed Petr Skoda
             
            8.
            Accessing non-static methods in repository class as static (PHP meta STRICT) Sub-task Closed Marina Glancy
             
            9.
            fix strict PHP notices - part 4 Sub-task Closed Petr Skoda
             
            10.
            HTML Block Strict Warning on Home/My home Sub-task Closed Petr Skoda
             
            11.
            MNet Peers moodleform validators fail strict standards Sub-task Closed Andrew Nicols
             
            12.
            Wiki module notices for page creation Sub-task Closed Petr Skoda
             
            13.
            fix strict PHP notices - part 5 Sub-task Closed Petr Skoda
             
            14.
            Strict error when editing a post in a forum Sub-task Closed Petr Skoda
             
            15.
            While uninstallling a message processor I got a strict standards warning Sub-task Closed Ruslan Kabalin
             
            16.
            Strict standards error in Feedback edit page Sub-task Closed Petr Skoda
             
            17.
            Strict standards warning on My Moodle page Sub-task Closed Petr Skoda
             
            18.
            E_STRICT warning when adding a new web service Sub-task Closed Eloy Lafuente (stronk7)
             
            19.
            Strict standards warning on My Moodle page for SCORM module Sub-task Closed Petr Skoda
             
            20.
            repository uses PHP4 style calling of instance_config_form methods Sub-task Closed Dan Poltawski
             
            21.
            Strict Standards Notice in Gradebook exports Sub-task Closed Frédéric Massart
             
            22.
            Fix PHP notices on database import of records from CSV Sub-task Closed Petr Skoda
             
            23.
            mnet enrollment plugin strict error Sub-task Closed Petr Skoda
             
            24.
            Strict warning in Shibboleth plugin Sub-task Closed Michael Aherne
             
            25.
            Strict standards validation in flexible_table defined in lib/tablelib.php Sub-task Closed Marina Glancy
             
            26.
            Strict standards when adding field in database activity Sub-task Closed Petr Skoda
             
            27.
            Strict standards in multianswer question type Sub-task Closed Tim Hunt
             
            28.
            Strict standards warning when enabling the file download portfolio plugin Sub-task Closed Dan Poltawski
             
            29.
            While exporting a database entry to the file download portfolio plugin I got a strict standards warning Sub-task Closed Petr Skoda
             
            30.
            Strict standards while configuring an Alfresco repository Sub-task Closed moodle.com
             
            31.
            Strict standards warnings in Glossary Sub-task Closed Petr Skoda
             
            32.
            E_STRICT warning when deleting one course category Sub-task Closed Eloy Lafuente (stronk7)
             
            33.
            Strict standards notice in RADIUS Server authentication settings Sub-task Closed Unassigned
             
            34.
            Strict standards: Non-static method grade_report_grader::process_action() Sub-task Closed Tim Hunt
             
            35.
            Strict standard error on tags block and when editing tags Sub-task Closed Petr Skoda
             
            36.
            E_STRICT problem in stats Sub-task Closed Dan Poltawski
             
            37.
            Strict standard errors in lesson Sub-task Closed Rossiani Wijaya
             
            38.
            E_STRICT in upload user group creation Sub-task Closed Petr Skoda
             
            39.
            Strict Standards for glossary deletion Sub-task Closed Petr Skoda
             
            40.
            PHP Strict Standards error: graph.php on line 194 Sub-task Closed Matteo Scaramuccia
             

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              Strict Standards: Only variables should be passed by reference in /Users/danp/git/moodle/blocks/edit_form.php on line 175

              Show
              poltawski Dan Poltawski added a comment - Strict Standards: Only variables should be passed by reference in /Users/danp/git/moodle/blocks/edit_form.php on line 175
              Hide
              marina Marina Glancy added a comment -

              Strict Standards: Redefining already defined constructor for class flexible_table in /var/www/repositories/master/moodle/lib/tablelib.php on line 139 Strict Standards: Redefining already defined constructor for class table_sql in /var/www/repositories/master/moodle/lib/tablelib.php on line 1278

              Show
              marina Marina Glancy added a comment - Strict Standards: Redefining already defined constructor for class flexible_table in /var/www/repositories/master/moodle/lib/tablelib.php on line 139 Strict Standards: Redefining already defined constructor for class table_sql in /var/www/repositories/master/moodle/lib/tablelib.php on line 1278
              Hide
              marina Marina Glancy added a comment -

              Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method repository_filesystem::instance_config_form() should not be called statically in /var/www/repositories/master/moodle/repository/lib.php on line 954

              Show
              marina Marina Glancy added a comment - Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method repository_filesystem::instance_config_form() should not be called statically in /var/www/repositories/master/moodle/repository/lib.php on line 954
              Hide
              marina Marina Glancy added a comment -

              Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method repository_webdav::instance_config_form() should not be called statically in /var/www/repositories/master/moodle/repository/lib.php on line 954

              Show
              marina Marina Glancy added a comment - Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method repository_webdav::instance_config_form() should not be called statically in /var/www/repositories/master/moodle/repository/lib.php on line 954
              Hide
              skodak Petr Skoda added a comment -

              the blocks and tablelib is fixed, I have created new issue for the repository API issue, thanks

              Show
              skodak Petr Skoda added a comment - the blocks and tablelib is fixed, I have created new issue for the repository API issue, thanks
              Hide
              marina Marina Glancy added a comment -

              Strict Standards: Declaration of portfolio_export_form::validation() should be compatible with that of moodleform::validation() in .../lib/portfolio/forms.php on line 46
              Strict Standards: Declaration of portfolio_admin_form::validation() should be compatible with that of moodleform::validation() in .../lib/portfolio/forms.php on line 142
              Strict Standards: Declaration of portfolio_user_form::validation() should be compatible with that of moodleform::validation() in .../lib/portfolio/forms.php on line 266

              Show
              marina Marina Glancy added a comment - Strict Standards: Declaration of portfolio_export_form::validation() should be compatible with that of moodleform::validation() in .../lib/portfolio/forms.php on line 46 Strict Standards: Declaration of portfolio_admin_form::validation() should be compatible with that of moodleform::validation() in .../lib/portfolio/forms.php on line 142 Strict Standards: Declaration of portfolio_user_form::validation() should be compatible with that of moodleform::validation() in .../lib/portfolio/forms.php on line 266
              Hide
              marina Marina Glancy added a comment -

              Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method portfolio_plugin_googledocs::admin_config_validation() should not be called statically in .../lib/portfoliolib.php on line 813

              Show
              marina Marina Glancy added a comment - Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method portfolio_plugin_googledocs::admin_config_validation() should not be called statically in .../lib/portfoliolib.php on line 813
              Hide
              poltawski Dan Poltawski added a comment -

              I have a fix to the issues Marina reported in: MDL-29857

              Show
              poltawski Dan Poltawski added a comment - I have a fix to the issues Marina reported in: MDL-29857
              Hide
              marina Marina Glancy added a comment -

              This notice was really annoying:
              Strict Standards: Redefining already defined constructor for class flexible_table in /var/www/repositories/master/moodle/lib/tablelib.php on line 139

              here is the fix:

              https://github.com/marinaglancy/moodle/compare/master...wip-tablelib

              Show
              marina Marina Glancy added a comment - This notice was really annoying: Strict Standards: Redefining already defined constructor for class flexible_table in /var/www/repositories/master/moodle/lib/tablelib.php on line 139 here is the fix: https://github.com/marinaglancy/moodle/compare/master...wip-tablelib
              Hide
              marina Marina Glancy added a comment -

              Strict Standards: Creating default object from empty value in .../mod/lesson/view.php on line 341

              Show
              marina Marina Glancy added a comment - Strict Standards: Creating default object from empty value in .../mod/lesson/view.php on line 341
              Hide
              mattgibson Matt Gibson added a comment -

              I'm getting shedloads of errors in third party plugins due to missing access modifiers in the forms library, as outlined above. If I remove the public/protected/private in the plugin form, it fails codechecker validation.

              Show
              mattgibson Matt Gibson added a comment - I'm getting shedloads of errors in third party plugins due to missing access modifiers in the forms library, as outlined above. If I remove the public/protected/private in the plugin form, it fails codechecker validation.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Matt,

              Could you give some examples?

              Show
              poltawski Dan Poltawski added a comment - Hi Matt, Could you give some examples?
              Hide
              mattgibson Matt Gibson added a comment -

              Hi Dan

              This sort of thing:
              Strict standards: Declaration of phpunit_selenium_settings_mform::set_data() should be compatible with that of moodleform::set_data() in /Applications/MAMP/htdocs/23moodev/docroot/local/phpunit_selenium/settings_mform.php

              Comes up for all overridden methods. I think quickforms leaves out 'public' by default.

              Show
              mattgibson Matt Gibson added a comment - Hi Dan This sort of thing: Strict standards: Declaration of phpunit_selenium_settings_mform::set_data() should be compatible with that of moodleform::set_data() in /Applications/MAMP/htdocs/23moodev/docroot/local/phpunit_selenium/settings_mform.php Comes up for all overridden methods. I think quickforms leaves out 'public' by default.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Petr,

              I suppose we can close this now, since new issues will live on their own merit?

              Show
              poltawski Dan Poltawski added a comment - Hi Petr, I suppose we can close this now, since new issues will live on their own merit?
              Hide
              skodak Petr Skoda added a comment -

              Ah, yes, thanks everybody for reports and fixes, ciao!

              Show
              skodak Petr Skoda added a comment - Ah, yes, thanks everybody for reports and fixes, ciao!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12