Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31169

In Base theme, add a clearfix class so that the body isn't 0 (zero) height

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Turn theme designer mode on
      2. Select Base theme in normal way using theme selector
      3. Using 'Firebug' right click the main body of the page and choose 'Inspect Element', then go to the layout tab and ensure that the height is something greater than 0.
      Show
      Turn theme designer mode on Select Base theme in normal way using theme selector Using 'Firebug' right click the main body of the page and choose 'Inspect Element', then go to the layout tab and ensure that the height is something greater than 0.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31169_master

      Description

      In Moodle 2 base theme the body is 0 height due to floated contents. The solution is to add a clearfix div just before the closing body div. However, this is an annoyance when working with the base theme and could be fixed.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12