Moodle™ is a registered trademark.
Site policy | Contact
This issue does not require testing, see comments
in the current usage of advanced grading it is only used in assignment submission and function get_controller is called after the grading method is set which means after function set_active_method() is invoked. In the later the property areacache is populated.
It means that the code accessing $DB in get_controller is unreachable.
Although in the future it may be possible for module to have several grading methods and the function get_controller may be called for non-active method
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
thanks for the detailed evaluation and fix!
Integrated, thanks (22 and master).
nobody tested this as far as it is unreachable right now.
Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.
Nah, joking, many thanks! Closing this a fixed, ciao