Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31180

/lib/simpletest/testcompletionlib.php fake_recordset class uses $closed instead of $this->closed

    Details

      Gliffy Diagrams

        Attachments

          Activity

          Hide
          skodak Petr Skoda added a comment -

          to integrators: please cherry pick if you think it is necessary, I do not know if it solves anything, the tests complete fine for me as before

          Show
          skodak Petr Skoda added a comment - to integrators: please cherry pick if you think it is necessary, I do not know if it solves anything, the tests complete fine for me as before
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated (21, 22 and master), thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 and master), thanks!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Tests continue passing, surely it does not matter much (it's a fake recordset), but better if apparently using the close() ok.

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Tests continue passing, surely it does not matter much (it's a fake recordset), but better if apparently using the close() ok.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

          Nah, joking, many thanks! Closing this a fixed, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12