Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31182

/message/lib.php translate_message_default_setting() missing global $OUTPUT

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Messages
    • Labels:

      Gliffy Diagrams

        Activity

        Hide
        skodak Petr Skoda added a comment - - edited

        we should not use OUTPUT at this level, I am going to use debugging() instead there, looks like another useless lang string because nobody reported this fatal problem before...

        Show
        skodak Petr Skoda added a comment - - edited we should not use OUTPUT at this level, I am going to use debugging() instead there, looks like another useless lang string because nobody reported this fatal problem before...
        Hide
        samhemelryk Sam Hemelryk added a comment -

        Thanks Petr - certainly avoiding the use of OUTPUT there is a win. This has been integrated now.
        Cheers
        Sam

        Show
        samhemelryk Sam Hemelryk added a comment - Thanks Petr - certainly avoiding the use of OUTPUT there is a win. This has been integrated now. Cheers Sam
        Hide
        rajeshtaneja Rajesh Taneja added a comment -

        Thanks for fixing this, Petr,

        No testing was required, although tried with modifying if statement (to let it pass in debug message) and calling message_update_providers and it worked fine.

        Show
        rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this, Petr, No testing was required, although tried with modifying if statement (to let it pass in debug message) and calling message_update_providers and it worked fine.
        Hide
        stronk7 Eloy Lafuente (stronk7) added a comment -

        Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

        Nah, joking, many thanks! Closing this a fixed, ciao

        Show
        stronk7 Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Mar/12