Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31184

mulitple problems when reseting individual glossary types

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Glossary
    • Labels:
    • Testing Instructions:
      Hide

      1/ create main and secondary glossaries with entries
      2/ try resetting only main glossaries
      3/ try resetting only secondary glossaries

      Show
      1/ create main and secondary glossaries with entries 2/ try resetting only main glossaries 3/ try resetting only secondary glossaries
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w04_MDL-31184_m23_glosreset

      Description

      When reseting individual glossary types:
      1/ /mod/glossary/lib.php in glossary_reset_userdata() uses undefined $allentries
      2/ invalid sql - missing closing } in table name
      3/ missing "main glossary" in delete operation description
      4/ reset all glossaries

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks, this has been integrated.

            Show
            nebgor Aparup Banerjee added a comment - Thanks, this has been integrated.
            Hide
            phalacee Jason Fowler added a comment -

            all good Petr

            Show
            phalacee Jason Fowler added a comment - all good Petr
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

            Nah, joking, many thanks! Closing this a fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12