Moodle
  1. Moodle
  2. MDL-31189

Sky High theme does not show validator or other perfomance info details in footer when enabled

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3, 2.2.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Themes
    • Labels:
    • Rank:
      37630

      Description

      None of the debugging info options (performance/validators/page info) work in Sky High because the footer is not coded correctly.

        Issue Links

          Activity

          Hide
          Mary Evans added a comment -

          @Dietmar

          I've just set this up and added you as a watcher.
          Please let me have some feedback, from the files I sent you for this fix, when you have time. There is no big rush.

          Cheers
          Mary

          Show
          Mary Evans added a comment - @Dietmar I've just set this up and added you as a watcher. Please let me have some feedback, from the files I sent you for this fix, when you have time. There is no big rush. Cheers Mary
          Hide
          Michael de Raadt added a comment -

          Hi, Mary.

          I've just triaged this, but please keep working on it.

          Show
          Michael de Raadt added a comment - Hi, Mary. I've just triaged this, but please keep working on it.
          Hide
          Dietmar Wagner added a comment -

          Hi Mary,

          I tested your files and performance info is now shown in the footer. Great!

          There's one minor issue left as I have different layouts on different pages.
          Please have look at the attached images.

          Perhaps it would make sense to add something like

          #page-footer .performanceinfo span

          {display: inline;}

          or

          #page-footer .performanceinfo span

          {display: block;}

          to core.css for a consistent layout!

          Cheers
          Dietmar

          Show
          Dietmar Wagner added a comment - Hi Mary, I tested your files and performance info is now shown in the footer. Great! There's one minor issue left as I have different layouts on different pages. Please have look at the attached images. Perhaps it would make sense to add something like #page-footer .performanceinfo span {display: inline;} or #page-footer .performanceinfo span {display: block;} to core.css for a consistent layout! Cheers Dietmar
          Hide
          Mary Evans added a comment -

          Hi Dietmar,

          Thanks for this suggestion, I'll test it later when I am fixing the theme, which I plan to do after dinner this evening! Perhaps with a bottle of vino too!

          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi Dietmar, Thanks for this suggestion, I'll test it later when I am fixing the theme, which I plan to do after dinner this evening! Perhaps with a bottle of vino too! Cheers Mary
          Hide
          Mary Evans added a comment -

          @Dietmar,

          This took me longer than I thought it would...because halfway through doing the changes, I realised that the css I was adding for the performance info et al, should actually be styled by Base theme. As a result ended up restyling the footer again with a better results this time and less css.

          Cheers
          Mary

          Show
          Mary Evans added a comment - @Dietmar, This took me longer than I thought it would...because halfway through doing the changes, I realised that the css I was adding for the performance info et al, should actually be styled by Base theme. As a result ended up restyling the footer again with a better results this time and less css. Cheers Mary
          Hide
          Sam Hemelryk added a comment -

          Hi Mary,

          I've just been looking at this now.
          This one certainly looks like it should be backported to 22 and 21.
          I've attempted to cherry-pick however it does not apply cleanly.
          Could you please confirm this needs to be backported and produce branches for me.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Mary, I've just been looking at this now. This one certainly looks like it should be backported to 22 and 21. I've attempted to cherry-pick however it does not apply cleanly. Could you please confirm this needs to be backported and produce branches for me. Cheers Sam
          Hide
          Mary Evans added a comment -

          @ Sam,
          Yes please, this needs back porting to 21 & 22.
          Now M21 & M22 branches are in place are good to go.

          Cheers
          Mary

          Show
          Mary Evans added a comment - @ Sam, Yes please, this needs back porting to 21 & 22. Now M21 & M22 branches are in place are good to go. Cheers Mary
          Hide
          Sam Hemelryk added a comment -

          Thanks for cleaning things up Mary, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks for cleaning things up Mary, this has been integrated now
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Note I've performed one bulk whitespace fix to the theme on 21_STABLE, 22_STABLE and master, as far as this was adding new incorrect whitespace.

          Show
          Eloy Lafuente (stronk7) added a comment - Note I've performed one bulk whitespace fix to the theme on 21_STABLE, 22_STABLE and master, as far as this was adding new incorrect whitespace.
          Hide
          Jason Fowler added a comment -

          It's all there now, looks fine

          Show
          Jason Fowler added a comment - It's all there now, looks fine
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

          Nah, joking, many thanks! Closing this a fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: