Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31193

Security keys page: 'valid until' information is not matching the user language

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1, 2.2.9, 2.3.6, 2.4.3, 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      To do this test you'll need to create a token with a valid until date for a manager.

      Go to Admin > Plugins > Web service > Manage token
      Check that a token with a "Valid until" date has the correct date displayed in the correct user language.

      Connect as Manager
      Go to Edit profile > My security keys
      Check that a token with a "Valid until" date has the correct date displayed in the correct user language.

      Show
      To do this test you'll need to create a token with a valid until date for a manager. Go to Admin > Plugins > Web service > Manage token Check that a token with a "Valid until" date has the correct date displayed in the correct user language. Connect as Manager Go to Edit profile > My security keys Check that a token with a "Valid until" date has the correct date displayed in the correct user language.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31193-master
    • Pull Master Diff URL:

      Description

      webservice/renderer.php: user_webservice_tokens_box()

      Fix the following TODO:

      if (!empty($token->validuntil)) {
      		 
          $validuntil = date("F j, Y"); //TODO: language support (look for moodle function)
      		 
      }

      To see the 'valid until' information on your security keys page: you need to be a non admin user who has a token. The admin need to have set you up as an authorised user, and to have also set you up a 'valid until'.

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30227 Manage token page display wrong valid date when token date validation is set.

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              jerome Jérôme Mouneyrac
              Reporter:
              jerome Jérôme Mouneyrac
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Damyon Wiese
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/13