Moodle

The string 'Table of contents' can not be translated

Details

  • Testing Instructions:
    Hide

    Verify that the wiki displays a text string 'Table of contents'
    Create a page in a wiki with text and headers. Add text and headers until the wiki automatically create a TOC

    Search for the string on the Language customization page (or in AMOS, lang.moodle.org)

    Show
    Verify that the wiki displays a text string 'Table of contents' Create a page in a wiki with text and headers. Add text and headers until the wiki automatically create a TOC Search for the string on the Language customization page (or in AMOS, lang.moodle.org)
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

When a wiki auto create a Table of contents it displays a header 'Table of contents'. This text string can not be translated, it can not be found in the language pack.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-25930 Auto generated wiki page table of content not transalted

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
will help resolve

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32023 Hard coded lang strings in wiki module, missing lang strings

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29129 unlocalized strings in wiki

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael de Raadt added a comment -

Thanks for reporting this.

I've put that on the backlog.

In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.

Show
Michael de Raadt added a comment - Thanks for reporting this. I've put that on the backlog. In the meantime feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.
Hide
Permalink
Sunner Sun added a comment - - edited

I just made the patch:

Pull from Repository: git://github.com/sunner/moodle.git
Pull 2.1 Branch: MDL-31201-m21
Pull 2.1 Diff URL: https://github.com/sunner/moodle/compare/MOODLE_21_STABLE...MDL-31201-m21
Pull 2.2 Branch: MDL-31201-m22
Pull 2.2 Diff URL: https://github.com/sunner/moodle/compare/MOODLE_22_STABLE...MDL-31201-m22
Pull Master Branch: MDL-31201-master
Pull Master Diff URL: https://github.com/sunner/moodle/compare/master...MDL-31201-master

Wish they are helpful

Show
Sunner Sun added a comment - - edited I just made the patch: Pull from Repository: git://github.com/sunner/moodle.git Pull 2.1 Branch: MDL-31201 -m21 Pull 2.1 Diff URL: https://github.com/sunner/moodle/compare/MOODLE_21_STABLE...MDL-31201-m21 Pull 2.2 Branch: MDL-31201 -m22 Pull 2.2 Diff URL: https://github.com/sunner/moodle/compare/MOODLE_22_STABLE...MDL-31201-m22 Pull Master Branch: MDL-31201 -master Pull Master Diff URL: https://github.com/sunner/moodle/compare/master...MDL-31201-master Wish they are helpful
Hide
Permalink
Dan Poltawski added a comment -

Thanks for the patches Sunner - assigning to myself to push through integration.

Show
Dan Poltawski added a comment - Thanks for the patches Sunner - assigning to myself to push through integration.
Hide
Permalink
Dan Poltawski added a comment -

Thanks Sun!

Putting your patch up for peer review.

Show
Dan Poltawski added a comment - Thanks Sun! Putting your patch up for peer review.
Hide
Permalink
Ankit Agarwal added a comment -

Looks simple enough.
+1 for integration.
Thanks

Show
Ankit Agarwal added a comment - Looks simple enough. +1 for integration. Thanks
Hide
Permalink
Dan Poltawski added a comment -

Thanks Ankit.

To Integrator: can be cherry-picked to 23, 22, 21

Show
Dan Poltawski added a comment - Thanks Ankit. To Integrator: can be cherry-picked to 23, 22, 21
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated (21, 22, 23 & master), thanks!

PS: Note 21_STABLE is already out of support so we are stopping bug fixes to land there along the next days...

Show
Eloy Lafuente (stronk7) added a comment - Integrated (21, 22, 23 & master), thanks! PS: Note 21_STABLE is already out of support so we are stopping bug fixes to land there along the next days...
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Passing, the TOC is now using the string as expected.

Show
Eloy Lafuente (stronk7) added a comment - Passing, the TOC is now using the string as expected.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Closing this as fixed, changes are now available upstream.

Big thanks!

Show
Eloy Lafuente (stronk7) added a comment - Closing this as fixed, changes are now available upstream. Big thanks!

People

Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: