Details

    • Testing Instructions:
      Hide

      This should be tested on multiple browsers, at least IE (multiple versions if possible), Firefox, Chrome.

      • Enable AJAX & AJAX course editing
      • Visit a course with multiple activies/resources
      • Check that you get the the 'drag and drop' controls for moving activities around
      • Try moving activites around to different sections, rearranging - try your best to break it and confused it
      • At different stages visit the page in another browser/tab and ensure that the changes you've made are refected in the page (i.e. that they are saved on the server)
      • Try dragging and dropping 'sections' around and do similar things to try and break it
        • Once you've dragged sections around, try adding new resources in that moved section and ensure its been moved correctly
      Show
      This should be tested on multiple browsers, at least IE (multiple versions if possible), Firefox, Chrome. Enable AJAX & AJAX course editing Visit a course with multiple activies/resources Check that you get the the 'drag and drop' controls for moving activities around Try moving activites around to different sections, rearranging - try your best to break it and confused it At different stages visit the page in another browser/tab and ensure that the changes you've made are refected in the page (i.e. that they are saved on the server) Try dragging and dropping 'sections' around and do similar things to try and break it Once you've dragged sections around, try adding new resources in that moved section and ensure its been moved correctly
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Rank:
      37666

      Description

      Drag/drop

        Issue Links

          Activity

          Hide
          Ruslan Kabalin added a comment -

          Ready to be reviewed

          Show
          Ruslan Kabalin added a comment - Ready to be reviewed
          Hide
          Ankit Agarwal added a comment -

          Hi Ruslan,
          just noticing there is no code to be reviewed, Did you forgot to add a link to your git ?
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Ruslan, just noticing there is no code to be reviewed, Did you forgot to add a link to your git ? Thanks
          Hide
          Ruslan Kabalin added a comment -

          Hi Ankit, the link to git is in the parent task. As this is a complex feature, posting commits individually makes little sense, as they depend on each other.

          Show
          Ruslan Kabalin added a comment - Hi Ankit, the link to git is in the parent task. As this is a complex feature, posting commits individually makes little sense, as they depend on each other.
          Hide
          Dan Poltawski added a comment -

          Hi Ruslan,

          Understood, but this is making it is difficult for us to work out what is 'waiting for review'.

          Going through the workflow to move off waiting for review.

          Show
          Dan Poltawski added a comment - Hi Ruslan, Understood, but this is making it is difficult for us to work out what is 'waiting for review'. Going through the workflow to move off waiting for review.
          Hide
          Dan Poltawski added a comment -

          Putting this in the 'waiting for testing' stage. It needs testing instructions.

          Show
          Dan Poltawski added a comment - Putting this in the 'waiting for testing' stage. It needs testing instructions.
          Hide
          Rossiani Wijaya added a comment -

          This looks great.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This looks great. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This has been near becoming rejected, because it's not the best code you are able to produce.

          But, luckily, at the end, it has landed and has been spread to all repos out there.

          Many thanks and, don't forget it, keep improving your skills, you can!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: