Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31220

Deleting Assignment submissions isn't adequately logged

    Details

    • Testing Instructions:
      Hide

      Create assignment
      Set Maximum number of uploaded files = 2
      (NB Listed logs created excludes 'view' type logs)

      Login as student
      Add file test1.txt
      Logs created:
      assign submit Submission status: Submitted for grading. The number of file(s) : 1 file(s).
      assign file add Add: /test1.txt (dba7673010f19a94af4345453005933fd511bea9)

      Add file test2.txt
      Logs created:
      assign submit Submission status: Submitted for grading. The number of file(s) : 2 file(s).
      assign add file Add: /test2.txt (9054fbe0b622c638224d50d20824d2ff6782e308)

      Delete file test1.txt
      Edit file test1.txt
      Add file test1.txt
      Logs created:
      assign add file Add: /test1.txt (aa6de490c7f3168cceebf533a08ea0f0a8a5c7fe)
      assign delete file Delete: /test1.txt (dba7673010f19a94af4345453005933fd511bea9)
      assign submit Submission status: Submitted for grading. The number of file(s) : 2 file(s).

      Update license for file test1.txt
      Delete file test2.txt
      Add file test3.txt
      Logs created:
      assign add file Add: /test3.txt (41c5985fc771b6ecfe8feaa99f8fa9b77ac7d6ce)
      assign update file Update: /test1.txt (aa6de490c7f3168cceebf533a08ea0f0a8a5c7fe)
      assign delete file Delete: /test2.txt (9054fbe0b622c638224d50d20824d2ff6782e308)
      assign submit Submission status: Submitted for grading. The number of file(s) : 2 file(s).

      Delete all the files
      Logs created:
      assign submit update (empty) Submission status: Submitted for grading. The number of file(s) : 0 file(s).
      assign delete file Delete: /test3.txt (41c5985fc771b6ecfe8feaa99f8fa9b77ac7d6ce)
      assign delete file Delete: /test1.txt (aa6de490c7f3168cceebf533a08ea0f0a8a5c7fe)

      Show
      Create assignment Set Maximum number of uploaded files = 2 (NB Listed logs created excludes 'view' type logs) Login as student Add file test1.txt Logs created: assign submit Submission status: Submitted for grading. The number of file(s) : 1 file(s). assign file add Add: /test1.txt (dba7673010f19a94af4345453005933fd511bea9) Add file test2.txt Logs created: assign submit Submission status: Submitted for grading. The number of file(s) : 2 file(s). assign add file Add: /test2.txt (9054fbe0b622c638224d50d20824d2ff6782e308) Delete file test1.txt Edit file test1.txt Add file test1.txt Logs created: assign add file Add: /test1.txt (aa6de490c7f3168cceebf533a08ea0f0a8a5c7fe) assign delete file Delete: /test1.txt (dba7673010f19a94af4345453005933fd511bea9) assign submit Submission status: Submitted for grading. The number of file(s) : 2 file(s). Update license for file test1.txt Delete file test2.txt Add file test3.txt Logs created: assign add file Add: /test3.txt (41c5985fc771b6ecfe8feaa99f8fa9b77ac7d6ce) assign update file Update: /test1.txt (aa6de490c7f3168cceebf533a08ea0f0a8a5c7fe) assign delete file Delete: /test2.txt (9054fbe0b622c638224d50d20824d2ff6782e308) assign submit Submission status: Submitted for grading. The number of file(s) : 2 file(s). Delete all the files Logs created: assign submit update (empty) Submission status: Submitted for grading. The number of file(s) : 0 file(s). assign delete file Delete: /test3.txt (41c5985fc771b6ecfe8feaa99f8fa9b77ac7d6ce) assign delete file Delete: /test1.txt (aa6de490c7f3168cceebf533a08ea0f0a8a5c7fe)
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-31220-logging-assignment-submissions

      Description

      Whilst investigating an issue where a user had deleted their submission, we discovered that this is inadequately logged.
      If a user deletes a file attachment, then saves changes, it is logged as 'assignment upload'.

      To Reproduce

      • Create a new upload assignment
      • Log in as a user on the course
      • Upload a submission
      • Save Changes
      • View the Assignment again
      • Choose 'Edit these files'
      • From the dropdown menu choose 'Delete' and confirm
      • Choose 'Save Changes'
      • Log in as administrator
      • View the logs for the user
      • Notice that the user has two log entries for 'assignment upload' but in reality the assignment files were removed.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14