Moodle
  1. Moodle
  2. MDL-31221

Assignment setting 'Send for Marking' is required to update assignment_submissions.data2

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Duplicate
    • Affects Version/s: 2.2
    • Fix Version/s: None
    • Component/s: Assignment (2.2)
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE
    • Rank:
      37672

      Description

      Changing assignment setting prevents finalisation of submissions

      Replication steps:

      1. Set up an advanced upload assignment activity with 'Send for marking ' set to yes
      2. Have some students upload files but not click the send for marking button
      3. Teacher views assignment and sees 'No attempts have been made on this assignment' but can see the files marked 'Draft:'
      4. Teacher changes the setting 'Send for marking ' to no
      5. Teacher views assignment and sees 'No attempts have been made on this assignment' but can see the files
      6. The submissions are not finalised

      Similarly

      1. Set up an advanced upload assignment activity with 'Send for marking ' set to no
      2. Have some students upload files
      3. Teacher views assignment and sees 'No attempts have been made on this assignment' but can see the files

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Is it the case that the teacher cannot mark the assignments? Or is it that the submissions just have not been updated as being submitted when the setting changes?

          Show
          Michael de Raadt added a comment - Is it the case that the teacher cannot mark the assignments? Or is it that the submissions just have not been updated as being submitted when the setting changes?
          Hide
          Amanda Doughty added a comment -

          The message 'No attempts have been made on this assignment' is the problem I'm reporting here. We will carry out further testing to see if the missing 'submitted' value prevents grading or has any other effect. I'll report back when we know more.

          Show
          Amanda Doughty added a comment - The message 'No attempts have been made on this assignment' is the problem I'm reporting here. We will carry out further testing to see if the missing 'submitted' value prevents grading or has any other effect. I'll report back when we know more.
          Hide
          Helen Foster added a comment -

          Linking to a very similar assignment issue I came across.

          Show
          Helen Foster added a comment - Linking to a very similar assignment issue I came across.
          Hide
          Helen Foster added a comment -

          Another very similar issue.

          Show
          Helen Foster added a comment - Another very similar issue.
          Hide
          Doug Moody added a comment -

          This is all about advanced uploading of files. I first noticed it with the new rubric capabilities in 2.2, but it apparently has been around for a long time in other trackers, namely assignment: MDL-29419 and MDL-26969.

          I created a thread with some graphics of how this could be easily resolved, but I am no programmer. I would appreciate someone working on this soon. It is very easy for students to miss the final crucial step of "send for marking" If they miss it, then they will be graded down by a teacher that is not on top of this bug.

          My discussion can be found at http://moodle.org/mod/forum/discuss.php?d=193911, in which the post dated 1/20/2012 proposes a screen that would solve most problems.

          Show
          Doug Moody added a comment - This is all about advanced uploading of files. I first noticed it with the new rubric capabilities in 2.2, but it apparently has been around for a long time in other trackers, namely assignment: MDL-29419 and MDL-26969 . I created a thread with some graphics of how this could be easily resolved, but I am no programmer. I would appreciate someone working on this soon. It is very easy for students to miss the final crucial step of "send for marking" If they miss it, then they will be graded down by a teacher that is not on top of this bug. My discussion can be found at http://moodle.org/mod/forum/discuss.php?d=193911 , in which the post dated 1/20/2012 proposes a screen that would solve most problems.
          Hide
          Michael de Raadt added a comment -

          This seems to be an issue that is being reported in different ways.

          I'm increasing the priority of this.

          Show
          Michael de Raadt added a comment - This seems to be an issue that is being reported in different ways. I'm increasing the priority of this.
          Hide
          Doug Moody added a comment -

          Thanks for upping the priority. Whoever does work on it should look at my mockup page at the link above. Thanks.

          Show
          Doug Moody added a comment - Thanks for upping the priority. Whoever does work on it should look at my mockup page at the link above. Thanks.
          Hide
          Gerard Caulfield added a comment - - edited

          It seems this issue revolves around the definition of the word "attempt". We have taken the perspective that an assignment needs to be submitted before it is classified as an attempt. Therefor a draft (where the student has not hit the submit button) should not really show up in a number which represents the number of attempts.

          Perhaps the best solution is to change the text to say "There are no finalised submissions and 5 drafts" or something along those lines?

          The "send for marking" button also needs to be made far more obvious, but MDL-29419 should addressing that.

          Show
          Gerard Caulfield added a comment - - edited It seems this issue revolves around the definition of the word "attempt". We have taken the perspective that an assignment needs to be submitted before it is classified as an attempt. Therefor a draft (where the student has not hit the submit button) should not really show up in a number which represents the number of attempts. Perhaps the best solution is to change the text to say "There are no finalised submissions and 5 drafts" or something along those lines? The "send for marking" button also needs to be made far more obvious, but MDL-29419 should addressing that.
          Hide
          Gerard Caulfield added a comment -

          Hi Michael, just saw somebody reference this bug as a problem for them and saw that it was assigned to me. You probably want to reassign this bug and any others which are still open in my name. Thanks

          Show
          Gerard Caulfield added a comment - Hi Michael, just saw somebody reference this bug as a problem for them and saw that it was assigned to me. You probably want to reassign this bug and any others which are still open in my name. Thanks
          Hide
          Rossiani Wijaya added a comment -

          Hmm.. I think it make sense to not counting draft as submitted.

          If student click on send for marking button, then it indicates they wanted their assignment to be graded. On the other hand, if user just want to show their draft copy to be looked by teacher, then their assignment can be consider as not yet submitted.

          Show
          Rossiani Wijaya added a comment - Hmm.. I think it make sense to not counting draft as submitted. If student click on send for marking button, then it indicates they wanted their assignment to be graded. On the other hand, if user just want to show their draft copy to be looked by teacher, then their assignment can be consider as not yet submitted.
          Hide
          Michael de Raadt added a comment -

          Hi, Rosie.

          If the "Send for marking button" setting is set to "No" then there is no draft state. All submissions are final submissions are fully submitted when this is the case. This setting needs to be checked when counting submissions.

          Show
          Michael de Raadt added a comment - Hi, Rosie. If the "Send for marking button" setting is set to "No" then there is no draft state. All submissions are final submissions are fully submitted when this is the case. This setting needs to be checked when counting submissions.
          Hide
          Rossiani Wijaya added a comment -

          This issue is duplicate and will be fixed through MDL-31987.

          Show
          Rossiani Wijaya added a comment - This issue is duplicate and will be fixed through MDL-31987 .

            People

            • Votes:
              4 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: