Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31235

Support text format for marking guide criteria and levels

XMLWordPrintable

    • MOODLE_23_STABLE, MOODLE_34_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_402_STABLE
    • MDL-31235-master
    • Hide

      Setup Test

      1. Create a new course as Admin
      2. Enrol a student and a teacher to the course
      3. Via Site Administration -> Courses -> Restore Course: upload the attached file backup-assignment-for-mdl-31235.mbz and select the just created course where the activity is restored into. Just click next on all the restore steps until the restore has been finished.
      4. Add the french language pack to your site (via Site Administration -> Language Packs)
      5. Make sure Moodle multilang plugin is enabled content and headings (in admin/filters.php - (see screenshot md-31235-filter.png))
      6. Optional but recommended: Install the https://moodle.org/plugins/filter_multilang2 plugin. Enable the filter for content and headings.

      Run the test as student

      1. Login as the student, that you have enrolled to the course. Proceed to the Assignment.
      2. At the page "Submission of presentation and report" page, check that all the labels are in english. The expected output should look like in screenshot mdl-31235-student-en.png
      3. Switch the language to french, check again that now the labels must be in french. The expected output should look like in screenshot mdl-31235-student-fr.png. (Note that there are a few labels in English at the bottom - thats ok, because in the 3rd criteria there are some HTML test cases - see screenshot)
      4. Click the button "Ajouter un travail" to ge to the submission form. Expected output: the form is completely in french, no english labels are at the page.
      5. Switch back to english. Expected output is the submission form now with english labels only.
      6. Submit some work and logout.

      Run the test as teacher

      1. Login as teacher/admin and go to the assignment activity.
      2. Got to the Advanced grading tab. The expected output should look like in screenshot mdl-31235-teacher-en.png.
      3. Switch the language to french. The expected output should look like in screenshot mdl-31235-teacher-fr.png.
      4. Click on the image with the pen to modify the criteria. Expected output is here that you see the HTML and the {mlang} tags together with both, english and french labels. Edit some labels just to see that everything works and no input is tampered when saving the data.
      5. Save the form (you might switch back to english if that's easier).
      6. Go back to the assignment activity by clicking the "Assignment" in the activity navigation.
      7. Click the "Grade" button to start evaluating the submission of student1.
      8. Click the "Insert frequently used comment" button below the first field. Expected output is that here are english labels only (expect the last, 'kou').
      9. Click cancel, click the "Assignment: Submission of presentation and report" in the top left to go back to the activity so that you are able to switch the language to french. Then start the grading process again and repeat step 8. Expected output is that all comment labels are in french now (except the last, 'kou').
      10. Click on one of the comments to insert it into the text field.
      11. Send the form. You should get an error message. Important here that the denoted field names are in french (e.g. it reads like: Le score donné à « Solution » n'est pas valide: ...) for all three criteria fields.
      12. Again repeat this for english (see step 9) and then repeat step 11. The expected error messages read like: The score given to 'Problem solution' is not valid,... for all three criteria fields.
      Show
      Setup Test Create a new course as Admin Enrol a student and a teacher to the course Via Site Administration -> Courses -> Restore Course: upload the attached file backup-assignment-for-mdl-31235.mbz and select the just created course where the activity is restored into. Just click next on all the restore steps until the restore has been finished. Add the french language pack to your site (via Site Administration -> Language Packs) Make sure Moodle multilang plugin is enabled content and headings (in admin/filters.php - (see screenshot md-31235-filter.png )) Optional but recommended: Install the https://moodle.org/plugins/filter_multilang2 plugin. Enable the filter for content and headings. Run the test as student Login as the student, that you have enrolled to the course. Proceed to the Assignment. At the page "Submission of presentation and report" page, check that all the labels are in english. The expected output should look like in screenshot mdl-31235-student-en.png Switch the language to french, check again that now the labels must be in french. The expected output should look like in screenshot mdl-31235-student-fr.png . (Note that there are a few labels in English at the bottom - thats ok, because in the 3rd criteria there are some HTML test cases - see screenshot) Click the button "Ajouter un travail" to ge to the submission form. Expected output: the form is completely in french, no english labels are at the page. Switch back to english. Expected output is the submission form now with english labels only. Submit some work and logout. Run the test as teacher Login as teacher/admin and go to the assignment activity. Got to the Advanced grading tab. The expected output should look like in screenshot mdl-31235-teacher-en.png . Switch the language to french. The expected output should look like in screenshot mdl-31235-teacher-fr.png . Click on the image with the pen to modify the criteria. Expected output is here that you see the HTML and the {mlang} tags together with both, english and french labels. Edit some labels just to see that everything works and no input is tampered when saving the data. Save the form (you might switch back to english if that's easier). Go back to the assignment activity by clicking the "Assignment" in the activity navigation. Click the "Grade" button to start evaluating the submission of student1. Click the "Insert frequently used comment" button below the first field. Expected output is that here are english labels only (expect the last, 'kou'). Click cancel, click the "Assignment: Submission of presentation and report" in the top left to go back to the activity so that you are able to switch the language to french. Then start the grading process again and repeat step 8. Expected output is that all comment labels are in french now (except the last, 'kou'). Click on one of the comments to insert it into the text field. Send the form. You should get an error message. Important here that the denoted field names are in french (e.g. it reads like: Le score donné à « Solution » n'est pas valide: ...) for all three criteria fields. Again repeat this for english (see step 9) and then repeat step 11. The expected error messages read like: The score given to 'Problem solution' is not valid,... for all three criteria fields.

      Do one of those:

      1. either support different formats for rubric criteria and levels (and remarks), i.e. to allow teacher to use html editor and insert images

      2. or decide that we don't want to support formats and expect text only. In this case remove fields from database and their usage in code

      Also possible combinations that we support formats for criteria only or for criteria&levels but not remarks

        1. backup-assignment-for-mdl-31235.mbz
          5 kB
        2. master_student.gif
          master_student.gif
          1.29 MB
        3. master_teacher-1.gif
          master_teacher-1.gif
          1.68 MB
        4. master_teacher-2.gif
          master_teacher-2.gif
          1.03 MB
        5. mdl-31235-filter.png
          mdl-31235-filter.png
          14 kB
        6. mdl-31235-student-en.png
          mdl-31235-student-en.png
          90 kB
        7. mdl-31235-student-fr.png
          mdl-31235-student-fr.png
          92 kB
        8. mdl-31235-teacher-en.png
          mdl-31235-teacher-en.png
          92 kB
        9. mdl-31235-teacher-fr.png
          mdl-31235-teacher-fr.png
          103 kB
        10. Screenshot from 2023-02-15 15-33-53.png
          Screenshot from 2023-02-15 15-33-53.png
          64 kB
        11. Screenshot from 2023-02-15 15-34-26.png
          Screenshot from 2023-02-15 15-34-26.png
          81 kB

            strobotta Stephan Robotta
            marina Marina Glancy
            Luca Bösch Luca Bösch
            Ilya Tregubov Ilya Tregubov
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            15 Vote for this issue
            Watchers:
            19 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 31 minutes
                1h 31m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.