Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: General
    • Labels:
    • Rank:
      37699

      Description

      1/ concentrate on false returned from get_config() when plugin does not have any entries yet - it is a bit similar to old get_records()

        Activity

        Hide
        Petr Škoda added a comment -

        to integrators: I have carefully reviewed all places that use get_config('componentname') and it does not seem there could be any regressions caused by the NULL-->stdClass change

        Show
        Petr Škoda added a comment - to integrators: I have carefully reviewed all places that use get_config('componentname') and it does not seem there could be any regressions caused by the NULL-->stdClass change
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (21, 22 & master). Thanks! I've been performing some searches and have not been able to find more uses dependent of the change.

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 & master). Thanks! I've been performing some searches and have not been able to find more uses dependent of the change.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        About to run install & upgrade in all versions, will look for any notice/warn/error.

        Show
        Eloy Lafuente (stronk7) added a comment - About to run install & upgrade in all versions, will look for any notice/warn/error.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Passing, I've reviewed all install and upgrade combinations between 2.x versions and none throws notices/warns.

        Show
        Eloy Lafuente (stronk7) added a comment - Passing, I've reviewed all install and upgrade combinations between 2.x versions and none throws notices/warns.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

        Nah, joking, many thanks! Closing this a fixed, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: