Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 2.1.5, 2.2.2
Affects Version/s: 2.0.8, 2.1.5, 2.2.2, 2.3
Component/s: Themes
Labels:
- patch
- triaged

Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://git.luns.net.uk/moodle.git
Pull Main Branch:
~~MDL-31242~~-master-2
Pull Main Diff URL:
https://git.luns.net.uk/?p=moodle.git;a=commitdiff;h=a486e9cb9e59a51a8abf6af12d7123ec4236c750
Difficulty:
Easy
Testing Instructions:

Hide

0) Enable debug developer

1) try: http://YOURMOODLE/theme/yui_combo.php?moodle/-1/calendar/eventmanager/eventmanager.js&moodle/-1/enrol/notification/notification.js

2) TEST: You get pure javascript output starting "YUI.add( ....."
3) TEST: No warning/notices are shown in the page (or in the webserver error logs). Specially the "MOODLE_INTERNAL already defined" one.

Show
0) Enable debug developer 1) try: http://YOURMOODLE/theme/yui_combo.php?moodle/-1/calendar/eventmanager/eventmanager.js&moodle/-1/enrol/notification/notification.js 2) TEST: You get pure javascript output starting "YUI.add( ....." 3) TEST: No warning/notices are shown in the page (or in the webserver error logs). Specially the "MOODLE_INTERNAL already defined" one.

Noticed whilst writing additional Moodle YUI modules.
If you have more than one Moodle YUI module (e.g. you require two moodle yui modules) then MOODLE_INTERNAL is redefined

To test, visit:
http://<yourmoodlehere>/theme/yui_combo.php?moodle/-1/calendar/eventmanager/eventmanager.js&moodle/-1/enrol/notification/notification.js

This currently doesn't affect anything in core, but any third party libs, or the work that Ruslan and I have been doing in ~~MDL-31052~~ will be hit by this

This is caused by redefining moodle internal in theme/yui_combo.php - it's probably not really a theme issue, but it's in the theme directory and I couldn't find a better component

blocks

MDL-31052 update Course AJAX/javascript to YUI3 and replace section_classes.js

Closed

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: Andrew Lyons, Eloy Lafuente (stronk7), Petr Skoda

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Created:: 19/Jan/12 4:25 AM

Updated:: 20/Jan/12 6:33 AM

Resolved:: 20/Jan/12 6:33 AM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify