Moodle
  1. Moodle
  2. MDL-31242

Multiple Moodle YUI modules result cause MOODLE_INTERNAL to be redefined

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.8, 2.1.5, 2.2.2, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Themes
    • Labels:
    • Rank:
      37702

      Description

      Noticed whilst writing additional Moodle YUI modules.
      If you have more than one Moodle YUI module (e.g. you require two moodle yui modules) then MOODLE_INTERNAL is redefined

      To test, visit:
      http://<yourmoodlehere>/theme/yui_combo.php?moodle/-1/calendar/eventmanager/eventmanager.js&moodle/-1/enrol/notification/notification.js

      This currently doesn't affect anything in core, but any third party libs, or the work that Ruslan and I have been doing in MDL-31052 will be hit by this

      This is caused by redefining moodle internal in theme/yui_combo.php - it's probably not really a theme issue, but it's in the theme directory and I couldn't find a better component

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          Cherry picks cleanly to:

          • MOODLE_21_STABLE
          • MOODLE_22_STABLE
          Show
          Andrew Nicols added a comment - Cherry picks cleanly to: MOODLE_21_STABLE MOODLE_22_STABLE
          Hide
          Andrew Nicols added a comment -

          By the way, it also cherry-picks cleanly to MOODLE_20_STABLE if you feel so inclined

          Show
          Andrew Nicols added a comment - By the way, it also cherry-picks cleanly to MOODLE_20_STABLE if you feel so inclined
          Hide
          Petr Škoda added a comment -

          please fix the missing space after IF, the rest is perfect, +10, sorry for the trouble

          Show
          Petr Škoda added a comment - please fix the missing space after IF, the rest is perfect, +10, sorry for the trouble
          Hide
          Andrew Nicols added a comment -

          Corrected whitespace issues pointed out by Petr

          Show
          Andrew Nicols added a comment - Corrected whitespace issues pointed out by Petr
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sending it to integration, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Sending it to integration, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (21, 22 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 & master), thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passed. All branched were throwing the warn/notices and, once the patch was applied, it returns pristine JS.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Passed. All branched were throwing the warn/notices and, once the patch was applied, it returns pristine JS. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This is now available in the git and cvs repositories.

          Consider the responsibility of your fingerprints engraved there for future generations!

          Thanks for the work, closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This is now available in the git and cvs repositories. Consider the responsibility of your fingerprints engraved there for future generations! Thanks for the work, closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: