Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31242

Multiple Moodle YUI modules result cause MOODLE_INTERNAL to be redefined

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.0.8, 2.1.5, 2.2.2, 2.3
    • 2.1.5, 2.2.2
    • Themes

    Description

      Noticed whilst writing additional Moodle YUI modules.
      If you have more than one Moodle YUI module (e.g. you require two moodle yui modules) then MOODLE_INTERNAL is redefined

      To test, visit:
      http://<yourmoodlehere>/theme/yui_combo.php?moodle/-1/calendar/eventmanager/eventmanager.js&moodle/-1/enrol/notification/notification.js

      This currently doesn't affect anything in core, but any third party libs, or the work that Ruslan and I have been doing in MDL-31052 will be hit by this

      This is caused by redefining moodle internal in theme/yui_combo.php - it's probably not really a theme issue, but it's in the theme directory and I couldn't find a better component

      Attachments

        Issue Links

          Activity

            People

              dobedobedoh Andrew Lyons
              dobedobedoh Andrew Lyons
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Mar/12