[MDL-31243] Refactor similar SQL generation code from get_users_by_capability & get_enrolled_uses to make get_with_capability_sql - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.2.1, 3.2
Fix Version/s: 3.2
Component/s: Enrolments, Libraries
Labels:
- CatalystIT
- Partner
- api_change
- ci
- dev_docs_required
- release_notes
- triaged

Affected Branches:
MOODLE_22_STABLE, MOODLE_32_STABLE
Fixed Branches:
MOODLE_32_STABLE
Pull from Repository:
https://github.com/Beedell/moodle.git
Pull Master Branch:
wip-~~MDL-31243~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...Beedell:wip-MDL-31243-master
Testing Instructions:

Hide

Please note as this is just a refactoring of current code, there is no specific manual test. Automated tests should suffice. This issue will be used extensively within ~~MDL-27072~~ where there will be manual and automated tests.

Show
Please note as this is just a refactoring of current code, there is no specific manual test. Automated tests should suffice. This issue will be used extensively within MDL-27072 where there will be manual and automated tests.

Description

These two library functions contain very similar code that should be refactored out to avoid duplication.

In addition, the proposed get_with_capability_sql will be useful in other places, for example the quiz reports.

Attachments

Issue Links

blocks

MDL-27072 Quiz reports should use enroled users code, not get_users_by_capability

Closed

Activity

People

Assignee:: John Beedell

Reporter:: Tim Hunt

Peer reviewer:: Tim Hunt

Integrator:: Andrew Lyons

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, David Monllaó, Eloy Lafuente (stronk7), John Beedell, John Okely, Marina Glancy, Matt Clarkson, Rajesh Taneja, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 12 Start watching this issue

Dates

Created:: 19/Jan/12 4:44 AM

Updated:: 15/Nov/16 8:07 PM

Resolved:: 07/Oct/16 5:26 AM

Fix Release Date:: 5/Dec/16