Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31244

Problem with images in question bank and quiz if algebra filter is enabled

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2.4, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Questions, Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1. Enable the algebra filter.

      2. Type in some maths some where (e.g. a forum post). Suitable maths might be @@1 + 1 = 2@@.

      3. Also copy in paste in a diff inside <pre> tags (not that the pre tags are really important). E.g. the one below http://tracker.moodle.org/browse/MDL-31244?focusedCommentId=174752&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-174752

      4. Submit the post, and ensure the maths is displayed as maths, but the diff is not messed up.

      Show
      1. Enable the algebra filter. 2. Type in some maths some where (e.g. a forum post). Suitable maths might be @@1 + 1 = 2@@. 3. Also copy in paste in a diff inside <pre> tags (not that the pre tags are really important). E.g. the one below http://tracker.moodle.org/browse/MDL-31244?focusedCommentId=174752&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-174752 4. Submit the post, and ensure the maths is displayed as maths, but the diff is not messed up.
    • Workaround:
      Hide

      deactivate algebra filter (why are people still using this now that we have so many wonderfull tools for math is beyond my understanding !)

      Show
      deactivate algebra filter (why are people still using this now that we have so many wonderfull tools for math is beyond my understanding !)
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      See discussion here : http://moodle.org/mod/forum/discuss.php?d=192615
      The problem is that on several pages, text filters are called with texts containing undecoded images urls, so if the algebra filter is activated the algebra2tex.pl script is called with wrong data, that seems to result in a 500 server error.
      urls should be decoded before calling text filters.
      the problem seems to affect at least
      question/preview.php in all cases if for instance the question text contain an image or for a MC question if any answer contain an image
      mod/quiz/edit.php if the question bank content is displayed and at least a question text contain an image.
      But as my tests weren't extensive ones maybe other pages are also affected. In the forum discussion linked above Robert Fransen report that mod/quiz/startattempt.php can exhibit the same problem

      Of course I have listed Quiz in the Component field because it is affected but this is a Questions bug.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  3 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Sep/12