Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31245

Incorrect horizontal alignment of 'highlight' icon in topic format

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Course
    • Labels:

      Description

      Caused by a missing 'icon' class on the image

      With Javascript disabled, the horizontal alignment of the showonly, highlight, show/hide, up, and down icons is inconsistent with the highlight icon being a slightly different size. This causes it to appear slightly to the right of all of the others.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            dobedobedoh Andrew Nicols added a comment -

            This cherry picks cleanly to:

            • MOODLE_22_STABLE
            • MOODLE_21_STABLE
            Show
            dobedobedoh Andrew Nicols added a comment - This cherry picks cleanly to: MOODLE_22_STABLE MOODLE_21_STABLE
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Looks spot on to me thanks Andrew, feel free to put this up for integration when you are ready.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Looks spot on to me thanks Andrew, feel free to put this up for integration when you are ready. Cheers Sam
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Up for integration it goes!

            Show
            samhemelryk Sam Hemelryk added a comment - Up for integration it goes!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (21, 22 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (21, 22 & master), thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Passing, as far as it aligns the icons properly with JS disabled, but...

            what happens with JS enabled? It seems that all them are right aligned.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Passing, as far as it aligns the icons properly with JS disabled, but... what happens with JS enabled? It seems that all them are right aligned.
            Hide
            dobedobedoh Andrew Nicols added a comment -

            With JS Enabled, all of those icons are removed, and then re-added with JS.
            See MDL-31052 for a complete rewrite of the JS enabled versions from YUI2 code to YUI3, which also happens to address the alignment issue in the JS enabled case.

            Show
            dobedobedoh Andrew Nicols added a comment - With JS Enabled, all of those icons are removed, and then re-added with JS. See MDL-31052 for a complete rewrite of the JS enabled versions from YUI2 code to YUI3, which also happens to address the alignment issue in the JS enabled case.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

            Nah, joking, many thanks! Closing this a fixed, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12