Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31255

Moving course section when JavaScript is off does not update highlighted section

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Course
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Note to testers: Please test this under 21 and 22, that will make testing under master unnecessary (100% = 22_STABLE) and bring us good safety for incoming minor stable releases.

      1. Turn Javascript off
      2. Highlight the section
      3. Move either the highlighted section up or down or the section that replaces highlighted one on the move.
      Show
      Note to testers: Please test this under 21 and 22, that will make testing under master unnecessary (100% = 22_STABLE) and bring us good safety for incoming minor stable releases. Turn Javascript off Highlight the section Move either the highlighted section up or down or the section that replaces highlighted one on the move.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31255-master-3

      Description

      It appeared that the highlighted section remain on the same section number and not being updated on the section move when Javascript is off.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              kabalin Ruslan Kabalin added a comment -

              This can be cleanly cherry-picked to 2.2, 2.1

              Show
              kabalin Ruslan Kabalin added a comment - This can be cleanly cherry-picked to 2.2, 2.1
              Hide
              salvetore Michael de Raadt added a comment -

              Thanks for reporting that and providing a solution.

              Show
              salvetore Michael de Raadt added a comment - Thanks for reporting that and providing a solution.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Ruslan,

              Do you have permission to send things for peer review? If so, please do this in future as it'll speed up our review.

              Show
              poltawski Dan Poltawski added a comment - Hi Ruslan, Do you have permission to send things for peer review? If so, please do this in future as it'll speed up our review.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Ruslan,

              The basic idea looks good but we strongly discourage passing function variables by reference unless there is no other way as it breaks the 'self contained' nature of a function.

              So i'd suggest coming up with another solution which doesn't require passing by reference.

              Show
              poltawski Dan Poltawski added a comment - Hi Ruslan, The basic idea looks good but we strongly discourage passing function variables by reference unless there is no other way as it breaks the 'self contained' nature of a function. So i'd suggest coming up with another solution which doesn't require passing by reference.
              Hide
              kabalin Ruslan Kabalin added a comment -

              Hi Dan, thanks a lot for reviewing. I have re-factored it a little. See updated version.

              Show
              kabalin Ruslan Kabalin added a comment - Hi Dan, thanks a lot for reviewing. I have re-factored it a little. See updated version.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Ruslan,

              Looks great - my only comment is on the added phpdoc:

              @return boolean Result

              It would be good to give an indication what the result is represented as, e.g.

              @return boolean true if section moved successfully

              Show
              poltawski Dan Poltawski added a comment - Hi Ruslan, Looks great - my only comment is on the added phpdoc: @return boolean Result It would be good to give an indication what the result is represented as, e.g. @return boolean true if section moved successfully
              Hide
              kabalin Ruslan Kabalin added a comment -

              Hi Dan, I have fixed the phpdoc string.

              Show
              kabalin Ruslan Kabalin added a comment - Hi Dan, I have fixed the phpdoc string.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated, thanks (21, 22 & master).

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks (21, 22 & master).
              Hide
              phalacee Jason Fowler added a comment -

              All good in 2.2 and 2.1

              Show
              phalacee Jason Fowler added a comment - All good in 2.2 and 2.1
              Hide
              kabalin Ruslan Kabalin added a comment -

              Thanks a lot

              Show
              kabalin Ruslan Kabalin added a comment - Thanks a lot
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

              icao_reverse('arreis olik rebemevon afla letoh ognat');

              Closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao
              Hide
              kabalin Ruslan Kabalin added a comment -

              icao_reverse('arreis olik rebemevon afla letoh ognat');

              .-- . ... -.. — – .

              Show
              kabalin Ruslan Kabalin added a comment - icao_reverse('arreis olik rebemevon afla letoh ognat'); .-- . . .. -. . — – .

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/Mar/12