Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31262

Problem with review permissions when previewing a quiz with an unusual combination of permissions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1, 2.5.5, 2.6.2, 2.7
    • Fix Version/s: 2.5.6, 2.6.3
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. You need a course with a Student and Non-editing Teacher enrolled.
      2. Create a quiz. Set the Review options to something quite permissive.
      3. Add one TF question to the quiz.
      4. Attempt the quiz as the student verify that after Submit all and finish, you get to see a reveiw of your attempt.
      5. Attempt (preview) the quiz as the non-editing-teacher verify that after Submit all and finish, you get to see a reveiw of your attempt.
      6. As N-ET go to quiz admin -> Results -> Grades, and click the link to review the Student's attempt. Verify that is allowed.
      7. Override the N-ET role in the course, and remove the mod/quiz:viewreports capability.
      8. Verify that you can sitll preview the quiz, and see the review at the end.
      9. As N-ET go to quiz admin -> Results -> Grades, and click the link to review the Student's attempt. Verify that is not permitted.
      10. Override the N-ET role in the course. Add back the mod/quiz:viewreports capability, and remove mod/quz:preview.
      11. As N-ET go to quiz admin -> Results -> Grades, and click the link to review the Student's attempt. Verify that is permitted.

      (You may want to undo the overrides not, so you don't get confused later.)

      Show
      You need a course with a Student and Non-editing Teacher enrolled. Create a quiz. Set the Review options to something quite permissive. Add one TF question to the quiz. Attempt the quiz as the student verify that after Submit all and finish, you get to see a reveiw of your attempt. Attempt (preview) the quiz as the non-editing-teacher verify that after Submit all and finish, you get to see a reveiw of your attempt. As N-ET go to quiz admin -> Results -> Grades, and click the link to review the Student's attempt. Verify that is allowed. Override the N-ET role in the course, and remove the mod/quiz:viewreports capability. Verify that you can sitll preview the quiz, and see the review at the end. As N-ET go to quiz admin -> Results -> Grades, and click the link to review the Student's attempt. Verify that is not permitted. Override the N-ET role in the course. Add back the mod/quiz:viewreports capability, and remove mod/quz:preview. As N-ET go to quiz admin -> Results -> Grades, and click the link to review the Student's attempt. Verify that is permitted. (You may want to undo the overrides not, so you don't get confused later.)
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Define a role similar to non-editing teacher, but without the mod/quiz:viewreports.

      Preview a quiz. When you click Submit all and finish, the quiz submits, and you get redirected to review.php, and then a fatal error is displayed, saying you don't have permission to do that.

      That error should not occur. The review should be allowed.

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Petr Skoda
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Andrew Davis
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/May/14