Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Rank:
      37732

      Description

      Updates mymobile theme for new login page CSS from base theme.

        Activity

        Hide
        Mary Evans added a comment - - edited

        @John

        If you take a look at MDL-29724 you will see why this issue has been raised.

        I've assigned this to you. I hope that's OK?

        Cheers
        Mary

        Show
        Mary Evans added a comment - - edited @John If you take a look at MDL-29724 you will see why this issue has been raised. I've assigned this to you. I hope that's OK? Cheers Mary
        Hide
        John Stabinger added a comment -

        I looked at MDL-29724 but I'm not sure what I'm looking for. Is MDL-29724 in the latest weekly release so I can download and test or is this for 2.3?

        Show
        John Stabinger added a comment - I looked at MDL-29724 but I'm not sure what I'm looking for. Is MDL-29724 in the latest weekly release so I can download and test or is this for 2.3?
        Hide
        Mary Evans added a comment - - edited

        Basically, because Canvas was overriding most themes the Login menu was still showing the old set up. By removing the Login CSS from Canvas the login menu displays properly.

        But to answer your question about where the fix is, it is currently only in Master.
        So if you update your GitHub with...

        git checkout master (make sure you are on master branch)

        git fetch upstream
        for BRANCH in MOODLE_20_STABLE MOODLE_21_STABLE MOODLE_22_STABLE master; do
        git push origin refs/remotes/upstream/$BRANCH:$BRANCH
        done
        Then after each branch is updated in your GitHub you can do

        git status

        to find out what the state of your local repo is in relation to your github
        you should be able to Fast-Forward in which case to update master in your local
        repository do this...

        git pull origin

        this pulls all the newly updated files and folders in your local Moodle which you can access using your computer file manager.

        You can then extract a copy of Canvas, Arialist & Splash and check them out on your local server. All the other themes work find except Formal White, Magazine and MyMobile according to Rosi.

        Hope this helps?
        Mary

        Show
        Mary Evans added a comment - - edited Basically, because Canvas was overriding most themes the Login menu was still showing the old set up. By removing the Login CSS from Canvas the login menu displays properly. But to answer your question about where the fix is, it is currently only in Master. So if you update your GitHub with... git checkout master (make sure you are on master branch) git fetch upstream for BRANCH in MOODLE_20_STABLE MOODLE_21_STABLE MOODLE_22_STABLE master; do git push origin refs/remotes/upstream/$BRANCH:$BRANCH done Then after each branch is updated in your GitHub you can do git status to find out what the state of your local repo is in relation to your github you should be able to Fast-Forward in which case to update master in your local repository do this... git pull origin this pulls all the newly updated files and folders in your local Moodle which you can access using your computer file manager. You can then extract a copy of Canvas, Arialist & Splash and check them out on your local server. All the other themes work find except Formal White, Magazine and MyMobile according to Rosi. Hope this helps? Mary
        Hide
        John Stabinger added a comment -

        Yes it does help! I see the changes and will commit an update this afternoon. Thanks again.

        Show
        John Stabinger added a comment - Yes it does help! I see the changes and will commit an update this afternoon. Thanks again.
        Hide
        John Stabinger added a comment -

        I also removed a small slice of css that was outdated and made it somewhat difficult for users to re-style the theme.

        Show
        John Stabinger added a comment - I also removed a small slice of css that was outdated and made it somewhat difficult for users to re-style the theme.
        Hide
        Mary Evans added a comment -

        It appears to be OK so I'll set it for Integration Review.
        Thanks

        Show
        Mary Evans added a comment - It appears to be OK so I'll set it for Integration Review. Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (master only), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (master only), thanks!
        Hide
        Rossiani Wijaya added a comment -

        This looks great.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This looks great. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many thanks for your collaboration, this code has been integrated upstream and it's available in all the repositories.

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Many thanks for your collaboration, this code has been integrated upstream and it's available in all the repositories. Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: