Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Cannot Reproduce
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      1. Select Formal White theme and logout.
      2. Select login and test to see that pagelayout displays all elements of login page
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE

      Gliffy Diagrams

        Attachments

          Issue Links

            Activity

            Hide
            lazydaisy Mary Evans added a comment -

            @Daniele
            I have added you as a watcher to keep you in the loop.
            This is in ready for Monday's integration process

            Ciao

            Mary

            Show
            lazydaisy Mary Evans added a comment - @Daniele I have added you as a watcher to keep you in the loop. This is in ready for Monday's integration process Ciao Mary
            Hide
            daniss Daniele Cordella added a comment - - edited

            I just tested this sub-issue. All seems to be fine.
            Thanks Mary!

            Show
            daniss Daniele Cordella added a comment - - edited I just tested this sub-issue. All seems to be fine. Thanks Mary!
            Hide
            lazydaisy Mary Evans added a comment -

            Thanks Daniele!

            Show
            lazydaisy Mary Evans added a comment - Thanks Daniele!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Mary,

            I need a bit more information about this one.
            These changes do they need to be applied to the MOODLE_22_STABLE, and MOODLE_21_STABLE branches (e.g. are those branches affected).
            If they are could you please produce branches for each of them. The changes cherry-pick cleanly to 22 however there are conflicts with 21.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Mary, I need a bit more information about this one. These changes do they need to be applied to the MOODLE_22_STABLE, and MOODLE_21_STABLE branches (e.g. are those branches affected). If they are could you please produce branches for each of them. The changes cherry-pick cleanly to 22 however there are conflicts with 21. Cheers Sam
            Hide
            lazydaisy Mary Evans added a comment - - edited

            @Sam,
            No need to update 21 as there was a fix by Daniele between 21 & 22 which I have, in effect, wiped out.

            All CORE themes now use Base for Login as I removed the CSS from Canvas last week in a previous issue which Rosi dealt with. Formal White & Magazine & MyMobile needed more tweeking hence this and Magazine which you have just approved.

            John Stabinger is looking into MDL-31267 - MyMobile login as this needs a slightly different approach.

            Cheers
            Mary

            Show
            lazydaisy Mary Evans added a comment - - edited @Sam, No need to update 21 as there was a fix by Daniele between 21 & 22 which I have, in effect, wiped out. All CORE themes now use Base for Login as I removed the CSS from Canvas last week in a previous issue which Rosi dealt with. Formal White & Magazine & MyMobile needed more tweeking hence this and Magazine which you have just approved. John Stabinger is looking into MDL-31267 - MyMobile login as this needs a slightly different approach. Cheers Mary
            Hide
            lazydaisy Mary Evans added a comment -

            I inadvertently deleted the branch I had in master for this. Also in trying to re-base a branch last week my git-flow in master is all messed up!

            Show
            lazydaisy Mary Evans added a comment - I inadvertently deleted the branch I had in master for this. Also in trying to re-base a branch last week my git-flow in master is all messed up!
            Hide
            lazydaisy Mary Evans added a comment -

            Ciao Daniele,
            Can you check this and see if it needs any changes? If not this can be closed.
            Thanks
            Mary

            Show
            lazydaisy Mary Evans added a comment - Ciao Daniele, Can you check this and see if it needs any changes? If not this can be closed. Thanks Mary
            Hide
            daniss Daniele Cordella added a comment -

            I am sorry Mary. I love to say: "It is better to remain silent leaving people thinking you may be silly than speaking and giving them the certainty you really are silly". (sorry if my English is not correct)
            I can not see any problem with login page... and I have never seen it and I do not understand this issue. Maybe it is better I remain silent!

            Anyway, serious again, I would change
            .loginbox .loginform .form-input #username,
            .loginbox .loginform .form-input #password {
            width: 50%;
            color: #000;
            }
            to
            .loginbox .loginform .form-input #username,
            .loginbox .loginform .form-input #password {
            width: 100%;
            color: #000;
            }
            to allow people to see what they type during login. This is specially helpful for LDAP user that may have long company compliant userid and password. (as it is for me )

            Show
            daniss Daniele Cordella added a comment - I am sorry Mary. I love to say: "It is better to remain silent leaving people thinking you may be silly than speaking and giving them the certainty you really are silly". (sorry if my English is not correct) I can not see any problem with login page... and I have never seen it and I do not understand this issue. Maybe it is better I remain silent! Anyway, serious again, I would change .loginbox .loginform .form-input #username, .loginbox .loginform .form-input #password { width: 50%; color: #000; } to .loginbox .loginform .form-input #username, .loginbox .loginform .form-input #password { width: 100%; color: #000; } to allow people to see what they type during login. This is specially helpful for LDAP user that may have long company compliant userid and password. (as it is for me )
            Hide
            daniss Daniele Cordella added a comment -

            I just added and submitted for integration MDL-31786

            Show
            daniss Daniele Cordella added a comment - I just added and submitted for integration MDL-31786
            Hide
            lazydaisy Mary Evans added a comment -

            That's OK Daniele...I must admit I could not see any problem as you had already changed the login to allow the new "remember name" feature some months ago.

            I've closed this now.

            Ciao

            Show
            lazydaisy Mary Evans added a comment - That's OK Daniele...I must admit I could not see any problem as you had already changed the login to allow the new "remember name" feature some months ago. I've closed this now. Ciao
            Hide
            daniss Daniele Cordella added a comment -

            That's fine. Thanks Mary. Ciao.

            Show
            daniss Daniele Cordella added a comment - That's fine. Thanks Mary. Ciao.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12