Details

    • Database:
      Any
    • Testing Instructions:
      Hide

      test features described here :
      http://docs.moodle.org/dev/Assignment_Team_Based_Submissions#Features

      copied to below:
      Features
      There will be a setting that says that students will be submitting assignments as part of a team. There will be an option to specify the grouping for student teams. A team submission will be visible and updatable by any member of the group. If a student is not a member of any group, or if they are a member of multiple groups they will belong to a default team. There may be options to require all team members to confirm submission of the assignment for marking. The grading table will display one row per student, but will contain a column indicating the team and the status of the team submission. The single grading interface will allow grading and feedback to be sent to either the whole team or just the current student. The student submission summary will indicate the team and the list of students who have not yet submitted (if required).

      Show
      test features described here : http://docs.moodle.org/dev/Assignment_Team_Based_Submissions#Features copied to below: Features There will be a setting that says that students will be submitting assignments as part of a team. There will be an option to specify the grouping for student teams. A team submission will be visible and updatable by any member of the group. If a student is not a member of any group, or if they are a member of multiple groups they will belong to a default team. There may be options to require all team members to confirm submission of the assignment for marking. The grading table will display one row per student, but will contain a column indicating the team and the status of the team submission. The single grading interface will allow grading and feedback to be sent to either the whole team or just the current student. The student submission summary will indicate the team and the list of students who have not yet submitted (if required).
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-31284-POST23
    • Rank:
      37749

      Description

      This feature allows a group of students to submit an assignment as a team. Uses the course module groups settings to define the teams.

        Issue Links

          Activity

          Hide
          Michael Hughes added a comment -

          Could the grading table for this take in to account users that have been assigned in to a group with "grading" capabilities and display just the "students" in the group that the user belongs.

          This would potentially modify the normal behaviour of the groups menu's "All Participants" option. All participants would be re-defined as "all students in groups that the (viewing)user is assigned to in a role that has "grade" capability"

          Show
          Michael Hughes added a comment - Could the grading table for this take in to account users that have been assigned in to a group with "grading" capabilities and display just the "students" in the group that the user belongs. This would potentially modify the normal behaviour of the groups menu's "All Participants" option. All participants would be re-defined as "all students in groups that the (viewing)user is assigned to in a role that has "grade" capability"
          Hide
          Damyon Wiese added a comment -

          Hi Michael,

          There are some other features planned around allocating graders either manually or via groups. The spec is a work in progress and needs updating but we are working on it here:

          http://docs.moodle.org/dev/Assignment_Advanced_Marking

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Hi Michael, There are some other features planned around allocating graders either manually or via groups. The spec is a work in progress and needs updating but we are working on it here: http://docs.moodle.org/dev/Assignment_Advanced_Marking Regards, Damyon
          Hide
          Damyon Wiese added a comment -

          This patch is on a branch that has MDL-31295 integrated already - so that issue will block this but Martin said to post all these outstanding assignment features in parallel (scary git rebases are in my future).

          Show
          Damyon Wiese added a comment - This patch is on a branch that has MDL-31295 integrated already - so that issue will block this but Martin said to post all these outstanding assignment features in parallel (scary git rebases are in my future).
          Hide
          Damyon Wiese added a comment -

          Ready for review.

          Show
          Damyon Wiese added a comment - Ready for review.
          Hide
          Damyon Wiese added a comment -

          Rebased.

          Show
          Damyon Wiese added a comment - Rebased.
          Hide
          Damyon Wiese added a comment -

          Martin said to send this for integration.

          Show
          Damyon Wiese added a comment - Martin said to send this for integration.
          Hide
          Adrian Greeve added a comment - - edited

          Hi Damyon,

          In general things look good.

          Things to consider:

          1. At the moment. After an initial submission has been made, If a different student in the same team tries to update or submit new material to the group assignment an error is show.
            Argument 2 passed to assign_submission_plugin_submission::__construct() must be an instance of stdClass, boolean given, called in /var/www/repositories/master/moodle/mod/assign/renderer.php on line 561 and defined
            Error code: codingerror
            Stack trace:
            
                line 397 of /lib/setuplib.php: coding_exception thrown
                line 215 of /mod/assign/renderable.php: call to default_error_handler()
                line 561 of /mod/assign/renderer.php: call to assign_submission_plugin_submission->__construct()
                line 215 of /lib/outputrenderers.php: call to mod_assign_renderer->render_assign_submission_status()
                line 2374 of /mod/assign/locallib.php: call to plugin_renderer_base->render()
                line 2480 of /mod/assign/locallib.php: call to assign->view_student_summary()
                line 388 of /mod/assign/locallib.php: call to assign->view_submission_page()
                line 53 of /mod/assign/view.php: call to assign->view()
            
          2. There are minor presentation issues scattered through out the code. If you run the code checker plugin you can check out the list yourself and decide which items you would like to change.
          3. Please include some testing instructions.

          Thanks again.

          p.s. Sorry I didn't notice that this had been moved to integration review.

          Show
          Adrian Greeve added a comment - - edited Hi Damyon, In general things look good. Things to consider: At the moment. After an initial submission has been made, If a different student in the same team tries to update or submit new material to the group assignment an error is show. Argument 2 passed to assign_submission_plugin_submission::__construct() must be an instance of stdClass, boolean given, called in / var /www/repositories/master/moodle/mod/assign/renderer.php on line 561 and defined Error code: codingerror Stack trace: line 397 of /lib/setuplib.php: coding_exception thrown line 215 of /mod/assign/renderable.php: call to default_error_handler() line 561 of /mod/assign/renderer.php: call to assign_submission_plugin_submission->__construct() line 215 of /lib/outputrenderers.php: call to mod_assign_renderer->render_assign_submission_status() line 2374 of /mod/assign/locallib.php: call to plugin_renderer_base->render() line 2480 of /mod/assign/locallib.php: call to assign->view_student_summary() line 388 of /mod/assign/locallib.php: call to assign->view_submission_page() line 53 of /mod/assign/view.php: call to assign->view() There are minor presentation issues scattered through out the code. If you run the code checker plugin you can check out the list yourself and decide which items you would like to change. Please include some testing instructions. Thanks again. p.s. Sorry I didn't notice that this had been moved to integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Damyon Wiese added a comment -

          Rebased and applied a set of backported fixes from testing.

          Show
          Damyon Wiese added a comment - Rebased and applied a set of backported fixes from testing.
          Hide
          Damyon Wiese added a comment -

          Rebase again to remove a merge commit that was undoing changes.

          Show
          Damyon Wiese added a comment - Rebase again to remove a merge commit that was undoing changes.
          Hide
          Aparup Banerjee added a comment -

          Thanks this has been integrated into master.
          Testing hasn't revealed any issues for this but perhaps we could formalise some test instructions for QA.

          Show
          Aparup Banerjee added a comment - Thanks this has been integrated into master. Testing hasn't revealed any issues for this but perhaps we could formalise some test instructions for QA.
          Hide
          Aparup Banerjee added a comment -

          passed. now onto test MDL-31291

          Show
          Aparup Banerjee added a comment - passed. now onto test MDL-31291
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work.

          These changes have been spread upstream and are already available in the git and cvs repositories.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work. These changes have been spread upstream and are already available in the git and cvs repositories. Ciao
          Hide
          Helen Foster added a comment -

          Attaching doc from Grette Wilkinson which may help as a starting point for documenting this new feature.

          Show
          Helen Foster added a comment - Attaching doc from Grette Wilkinson which may help as a starting point for documenting this new feature.
          Hide
          Mary Cooch added a comment -

          Removing the qa_test_required label as this issue now has QA tests: MDLQA-4582, MDLQA-4583, MDLQA-4584, MDLQA-4585 and MDLQA-4586 (Note that these are QA test master copies which will be cloned
          for upcoming QA cycles.)

          Show
          Mary Cooch added a comment - Removing the qa_test_required label as this issue now has QA tests: MDLQA-4582 , MDLQA-4583 , MDLQA-4584 , MDLQA-4585 and MDLQA-4586 (Note that these are QA test master copies which will be cloned for upcoming QA cycles.)
          Hide
          Mary Cooch added a comment -

          Damyon/Grette - while writing tests I realised I didn't understand the functionality of "grouping for student teams/groups" - or else I couldn't get it to do anything. So if either of you could provide further details I'd be grateful.

          Show
          Mary Cooch added a comment - Damyon/Grette - while writing tests I realised I didn't understand the functionality of "grouping for student teams/groups" - or else I couldn't get it to do anything. So if either of you could provide further details I'd be grateful.
          Hide
          Damyon Wiese added a comment -

          Hi Mary,

          If you choose a "grouping for student groups" then the students will be divided into the groups provided by that grouping - if not then all the available groups for the course will be used.

          The reason this setting exists is so you can have different groups for different assignments within the same course.

          Does that help?

          Show
          Damyon Wiese added a comment - Hi Mary, If you choose a "grouping for student groups" then the students will be divided into the groups provided by that grouping - if not then all the available groups for the course will be used. The reason this setting exists is so you can have different groups for different assignments within the same course. Does that help?
          Hide
          Mary Cooch added a comment -

          Thanks Damyon. I am still not sure while writing the documentation but I will add my comments to a forum post here rather than on this tracker (not sure where is best) https://moodle.org/mod/forum/discuss.php?d=216399

          Show
          Mary Cooch added a comment - Thanks Damyon. I am still not sure while writing the documentation but I will add my comments to a forum post here rather than on this tracker (not sure where is best) https://moodle.org/mod/forum/discuss.php?d=216399
          Hide
          Mary Cooch added a comment -

          Removing docs_required label as these features are now documented here: http://docs.moodle.org/24/en/Assignment_settings. All hail Social Constructionism

          Show
          Mary Cooch added a comment - Removing docs_required label as these features are now documented here: http://docs.moodle.org/24/en/Assignment_settings . All hail Social Constructionism

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: