Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Create an instance of the assignment module
      2. Enable the Blind Marking setting.
      3. Click "View/grade all submissions"
      4. Verify the student names have been replaced with Participant X where X is a randomly allocated number.
      5. Create a submission as a student
      6. The "Blind marking" setting should now be locked for this assignment.
      7. Mark the submission as a grader - you should not be able to see the identity of the student anywhere in Moodle (e.g. logs, gradebook).
      8. Click "Reveal identities" in the navigation drop down.
      9. The student names should now be revealed and the marks and feedback should be released to the gradebook
      Show
      Create an instance of the assignment module Enable the Blind Marking setting. Click "View/grade all submissions" Verify the student names have been replaced with Participant X where X is a randomly allocated number. Create a submission as a student The "Blind marking" setting should now be locked for this assignment. Mark the submission as a grader - you should not be able to see the identity of the student anywhere in Moodle (e.g. logs, gradebook). Click "Reveal identities" in the navigation drop down. The student names should now be revealed and the marks and feedback should be released to the gradebook
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-31291-POST23
    • Rank:
      37756

      Description

      Blind marking is a feature that hides the identity of the student from the marker until a specified date (optional).

        Issue Links

          Activity

          Hide
          Grette Wilkinson added a comment -

          This also needs to be considered in relation to MDL-31276 in that MsWord files often contain author meta-data.

          Show
          Grette Wilkinson added a comment - This also needs to be considered in relation to MDL-31276 in that MsWord files often contain author meta-data.
          Hide
          Minh-Tam Nguyen added a comment -

          I would consider fiddling with Word metadata way out of scope for the moment. And once Moodle touches the file, one could make the case that the file is not the same as the file submitted, which could give reason to contest a grade.

          Show
          Minh-Tam Nguyen added a comment - I would consider fiddling with Word metadata way out of scope for the moment. And once Moodle touches the file, one could make the case that the file is not the same as the file submitted, which could give reason to contest a grade.
          Hide
          Grette Wilkinson added a comment -

          Agree - but we do need to be aware of this if implementing 'blind' marking...that and the fact that students may put identifying details within the document.

          Show
          Grette Wilkinson added a comment - Agree - but we do need to be aware of this if implementing 'blind' marking...that and the fact that students may put identifying details within the document.
          Hide
          Minh-Tam Nguyen added a comment -

          Maybe if "blind" marking is turned on, there could be a warning message on the submission (file upload) screen along the lines of:

          "This assignment will be blind marked. Please ensure that the document you submit does not contain any information identifying you as the student. Do not write your name or ID number in the header or on the first page of the document or in the file name or in the metadata associated with the file."

          Hmm, I was almost not able to write those last five words with a clean conscience. I think that mentioning metadata will likely cause more confusion than it solves. In an ideal world one could make markers promise not to peek at the metadata.

          Show
          Minh-Tam Nguyen added a comment - Maybe if "blind" marking is turned on, there could be a warning message on the submission (file upload) screen along the lines of: "This assignment will be blind marked. Please ensure that the document you submit does not contain any information identifying you as the student. Do not write your name or ID number in the header or on the first page of the document or in the file name or in the metadata associated with the file." Hmm, I was almost not able to write those last five words with a clean conscience. I think that mentioning metadata will likely cause more confusion than it solves. In an ideal world one could make markers promise not to peek at the metadata.
          Hide
          Grette Wilkinson added a comment -

          Good idea. You're right, we might need to work on the actual wording of that statement, but I like the premise.

          Show
          Grette Wilkinson added a comment - Good idea. You're right, we might need to work on the actual wording of that statement, but I like the premise.
          Hide
          Michael Hughes added a comment -

          A small comment on blind marking affecting the behaviour of the download as a zip function. I've noted the current code (which I'm sure is changing) outputs a name & moodle user id prepended to the files that are zipped.

          We have users that would review offline (via download) and the user identifiers are typically replaced with (slightly) more opaque identifiers (in our case an 11 digit registration number).

          Show
          Michael Hughes added a comment - A small comment on blind marking affecting the behaviour of the download as a zip function. I've noted the current code (which I'm sure is changing) outputs a name & moodle user id prepended to the files that are zipped. We have users that would review offline (via download) and the user identifiers are typically replaced with (slightly) more opaque identifiers (in our case an 11 digit registration number).
          Hide
          Damyon Wiese added a comment -

          Rebased and ready for review.

          This patch depends on MDL-31284 and MDL-31295 which are also in review (so those should be integrated first).

          Show
          Damyon Wiese added a comment - Rebased and ready for review. This patch depends on MDL-31284 and MDL-31295 which are also in review (so those should be integrated first).
          Hide
          Adrian Greeve added a comment - - edited

          I just noticed that MDL-31284 needs to be integrated before this issue. I'm going to go have a look at that first.

          Show
          Adrian Greeve added a comment - - edited I just noticed that MDL-31284 needs to be integrated before this issue. I'm going to go have a look at that first.
          Hide
          Damyon Wiese added a comment -

          Pushing this back into peer review as that is how Martin suggested to handle this round of changes.

          Show
          Damyon Wiese added a comment - Pushing this back into peer review as that is how Martin suggested to handle this round of changes.
          Hide
          Damyon Wiese added a comment -

          Martin said to send this for integration.

          Show
          Damyon Wiese added a comment - Martin said to send this for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Damyon Wiese added a comment -

          Rebased and backported a fix to hide student names from graders when teamassignments and blind marking are both enabled.

          Show
          Damyon Wiese added a comment - Rebased and backported a fix to hide student names from graders when teamassignments and blind marking are both enabled.
          Hide
          Aparup Banerjee added a comment -

          Thanks, thats integrated into master.

          I've tested this and have managed to spot some log like :
          Grade student: (id=7, fullname=user1 user1). Grade: 12.34 / 100.00.
          before actually hitting the "reveal identities" at one point.
          so this may need to be handled in another issue. however i couldn't replicate it so just noting it here.

          Show
          Aparup Banerjee added a comment - Thanks, thats integrated into master. I've tested this and have managed to spot some log like : Grade student: (id=7, fullname=user1 user1). Grade: 12.34 / 100.00. before actually hitting the "reveal identities" at one point. so this may need to be handled in another issue. however i couldn't replicate it so just noting it here.
          Hide
          Aparup Banerjee added a comment -

          passes for me.

          This may need to be tested further for username data leaks here for mod_assange.. thanks and ciao!

          Show
          Aparup Banerjee added a comment - passes for me. This may need to be tested further for username data leaks here for mod_assange.. thanks and ciao!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Hi Damyon, it has been detected by the CI server that this is leading to different DB structures comparing one installed site versus an upgraded one. The errors are these:

            Number of errors: 4
          
            Column assignment of table assign_user_mapping difference found in has_default: true !== false
            Column assignment of table assign_user_mapping difference found in default_value: 0 !== null
            Column userid of table assign_user_mapping difference found in has_default: true !== false
            Column userid of table assign_user_mapping difference found in default_value: 0 !== null
          

          Looking at code, it seems that you've defined those columns with default = 0 in install.xml, but have missed such a default in the corresponding upgrade.php steps (surely because of copying them from another place).

          So I'm going to add one commit to fix those differences. Please, please, use the XMLDB editor to produce both the install.xml definitions and the upgrade steps.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Hi Damyon, it has been detected by the CI server that this is leading to different DB structures comparing one installed site versus an upgraded one. The errors are these: Number of errors: 4 Column assignment of table assign_user_mapping difference found in has_default: true !== false Column assignment of table assign_user_mapping difference found in default_value: 0 !== null Column userid of table assign_user_mapping difference found in has_default: true !== false Column userid of table assign_user_mapping difference found in default_value: 0 !== null Looking at code, it seems that you've defined those columns with default = 0 in install.xml, but have missed such a default in the corresponding upgrade.php steps (surely because of copying them from another place). So I'm going to add one commit to fix those differences. Please, please, use the XMLDB editor to produce both the install.xml definitions and the upgrade steps. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work.

          These changes have been spread upstream and are already available in the git and cvs repositories.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work. These changes have been spread upstream and are already available in the git and cvs repositories. Ciao
          Hide
          Helen Foster added a comment -

          Attaching doc from Grette Wilkinson which may help as a starting point for documenting this new feature.

          Show
          Helen Foster added a comment - Attaching doc from Grette Wilkinson which may help as a starting point for documenting this new feature.
          Hide
          Mary Cooch added a comment - - edited

          Removing the qa_test_required label as this issue now has QA test: MDLQA-4589
          (Note that this is a QA test master copy which will be cloned
          for upcoming QA cycles.)

          Show
          Mary Cooch added a comment - - edited Removing the qa_test_required label as this issue now has QA test: MDLQA-4589 (Note that this is a QA test master copy which will be cloned for upcoming QA cycles.)
          Hide
          Mary Cooch added a comment -

          Removing the docs_required label as this is documented in http://docs.moodle.org/24/en/Assignment_settings

          Show
          Mary Cooch added a comment - Removing the docs_required label as this is documented in http://docs.moodle.org/24/en/Assignment_settings
          Hide
          Paul A. Vitagliano added a comment -

          You know, this tool is really not useful - and it's just another thing to confuse faculty with.

          Show
          Paul A. Vitagliano added a comment - You know, this tool is really not useful - and it's just another thing to confuse faculty with.

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: