Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31147 META: Collect together deprecated code changes for Moodle 2.3
  3. MDL-31294

Remove deprecated functions in lib/formslib.php

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.4
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide
      1. grep "addElement('file'"
      2. grep "createElement('file'"
      3. grep MoodleQuickForm_format
      4. grep "addElement('format'"
      5. grep "createElement('format'"
      6. grep setHelpButton
        Make sure none of the above are used.

      navigate pages with forms and make sure forms work fine, especially elements with help button.

      NOTE:
      sethelpButton is left in hidden.php and editor.php, make sure they have debug message.

      Show
      grep "addElement('file'" grep "createElement('file'" grep MoodleQuickForm_format grep "addElement('format'" grep "createElement('format'" grep setHelpButton Make sure none of the above are used. navigate pages with forms and make sure forms work fine, especially elements with help button. NOTE: sethelpButton is left in hidden.php and editor.php, make sure they have debug message.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-31294
    • Pull Master Diff URL:

      Description

      Remove deprecated functions in lib/formslib.php

        Attachments

          Issue Links

          caused a regression

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-47779 Review TODO with associated MDL's

          • Minor - Minor loss of function where workaround is possible
          • Open
          has a non-specific relationship to

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-34508 Remove deprecated function setHelpButton

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has been marked as being related by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-30974 forms API, phpdocs and devdocs

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-31047 clean setHelpButton in moodle form elements, as it was deprecated in 2.0.

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-31069 format form element can be removed in master

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              rajeshtaneja Rajesh Taneja
              Reporter:
              rajeshtaneja Rajesh Taneja
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Aparup Banerjee
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/12