Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31306

When previewing questions, if question type cannot give us a correct response, disable the button "Fill correct responses".

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.2.1
          • Fix Version/s: 2.1.5, 2.2.2
          • Component/s: Questions
          • Labels:
          • Testing Instructions:
            Hide

            1) create at least two questions one essay and one multichoice or shortanswer qtype (manually graded and automatically graded)
            2) preview manually graded one and the button "Fill in correct responses" should be disabled.
            3) preview automatically graded one, click on "Fill in correct responses" button and it should fill in the correct responses.

            Show
            1) create at least two questions one essay and one multichoice or shortanswer qtype (manually graded and automatically graded) 2) preview manually graded one and the button "Fill in correct responses" should be disabled. 3) preview automatically graded one, click on "Fill in correct responses" button and it should fill in the correct responses.
          • Affected Branches:
            MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_21_STABLE, MOODLE_22_STABLE
          • Pull Master Branch:
          • Pull Master Diff URL:

            Description

            When previewing questions, if question type cannot give us a correct response, for instance manually graded (essay, oral response qtype) the button "Fill correct responses" needs to be greyed out. This was working in head (changes were done in question/preview.php), but we did some changes in other files (in function definition, php doc,...)

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Just correcting the branch names.

                  Show
                  timhunt Tim Hunt added a comment - Just correcting the branch names.
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Mahmoud, I think you forgot to do
                  git push origin MOODLE_21_STABLE
                  which makes https://github.com/mkassaei/moodle/compare/MOODLE_21_STABLE...MDL-31306_21 not very helpful. I replaced that with a link to the specific commit.

                  Show
                  timhunt Tim Hunt added a comment - Mahmoud, I think you forgot to do git push origin MOODLE_21_STABLE which makes https://github.com/mkassaei/moodle/compare/MOODLE_21_STABLE...MDL-31306_21 not very helpful. I replaced that with a link to the specific commit.
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Changes look good. Submitting for integration.

                  Show
                  timhunt Tim Hunt added a comment - Changes look good. Submitting for integration.
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  Although the commit comment is not great. You have a typo: "desable"

                  I think better would be

                  MDL-31306 question preview: disable 'Fill correct' for qtypes that can't

                  Note that Moodle commit comments are meant to describe the area of code (like question preview) near the start of the commit comment.

                  I will leave it for now, but try to do better in future.

                  Show
                  timhunt Tim Hunt added a comment - Although the commit comment is not great. You have a typo: "desable" I think better would be MDL-31306 question preview: disable 'Fill correct' for qtypes that can't Note that Moodle commit comments are meant to describe the area of code (like question preview) near the start of the commit comment. I will leave it for now, but try to do better in future.
                  Hide
                  Permalink
                  timhunt Tim Hunt added a comment -

                  TO INTEGRATORS, please amend the commit message

                  Show
                  timhunt Tim Hunt added a comment - TO INTEGRATORS, please amend the commit message
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks guys, this has been integrated now.

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now.
                  Hide
                  Permalink
                  ankit_frenz Ankit Agarwal added a comment -

                  This is working as expected.
                  Great Fix.
                  Passing!
                  Thanks

                  Show
                  ankit_frenz Ankit Agarwal added a comment - This is working as expected. Great Fix. Passing! Thanks
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

                  Nah, joking, many thanks! Closing this a fixed, ciao

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        12/Mar/12