Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31311

Fix duplicate title attributes for iframed file and URL resources

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. Make sure that iframes are selected as an option under Site Administration --> Plugins --> Activity Modules --> URL and Site Administration --> Plugins --> Activity Modules --> File
      2. Navigate to a course, turn editing on, add a new File or URL resource.
      3. Fill in data and select "In Frame" from the Display drop down
      4. Save the resource and click to view it.
      5. View the source and see that the title attribute for both iframe elements is identical and only reflects the module name ('File' or 'URL')

      Show
      1. Make sure that iframes are selected as an option under Site Administration --> Plugins --> Activity Modules --> URL and Site Administration --> Plugins --> Activity Modules --> File 2. Navigate to a course, turn editing on, add a new File or URL resource. 3. Fill in data and select "In Frame" from the Display drop down 4. Save the resource and click to view it. 5. View the source and see that the title attribute for both iframe elements is identical and only reflects the module name ('File' or 'URL')
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-31311-Fix_iframe_titles

      Description

      The title attribute for the navigation frame and the content frames on File and URL resources are not helpful in their current state. They are identical and only reflect the type of resource that is being viewed:

      <frameset rows="$framesize,*">
      <frame src="$navurl" title="$modulename"/>
      <frame src="$exteurl" title="$modulename"/>
      </frameset>

      This is confusing to those relying on screen readers.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              blepoxp Glenn Ansley
              Reporter:
              blepoxp Glenn Ansley
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Aparup Banerjee
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12