Moodle
  1. Moodle
  2. MDL-31317

Notice when restoring a 1.9 backup

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      1. Try to restore the backup-zz-9876.fa08-20080915-0820.zip file from MDL-16513 (or any other 1.9 backup file that does not contain the site identifier)
      2. TEST: Make sure that in the step "3. Settings", there is no PHP notice regarding the undefined index "original_site_identifier_hash"

      Show
      1. Try to restore the backup-zz-9876.fa08-20080915-0820.zip file from MDL-16513 (or any other 1.9 backup file that does not contain the site identifier) 2. TEST: Make sure that in the step "3. Settings", there is no PHP notice regarding the undefined index "original_site_identifier_hash"
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31317-backup-notices

      Description

      If you restore the test backup file attached to MDL-16513 you get

      Notice: Undefined index: original_site_identifier_hash in /home/arborrow/NetBeansProjects/m22/backup/util/helper/backup_general_helper.class.php on line 141

      This is minor, but should be fixed.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            Thanks for reporting that, Tim.

            Show
            Michael de Raadt added a comment - Thanks for reporting that, Tim.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Aparup Banerjee added a comment -

            thanks, this has been integrated into master, 22 and 21 branches now for testing.

            Show
            Aparup Banerjee added a comment - thanks, this has been integrated into master, 22 and 21 branches now for testing.
            Hide
            Jason Fowler added a comment -

            All Good

            Show
            Jason Fowler added a comment - All Good
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Many thanks for your collaboration, this code has been integrated upstream and it's available in all the repositories.

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Many thanks for your collaboration, this code has been integrated upstream and it's available in all the repositories. Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: