Moodle
  1. Moodle
  2. MDL-31319

The new currentpage field in quiz attempts should be backed up

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Quiz
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      1. Create a quiz with at least two pages of questions.
      2. As a student, start an attempt and proceed to any page other than the first page.
      3. Exit from the quiz.
      4. Return to the quiz; verify that you're at the page you last viewed.
      5. Backup the quiz--accept all defaults.
      6. Delete the quiz.
      7. Restore the quiz--again accepting all defaults.
      8. As a student, restart the attempt and verify that you're back at the page you last viewed.

      Show
      1. Create a quiz with at least two pages of questions. 2. As a student, start an attempt and proceed to any page other than the first page. 3. Exit from the quiz. 4. Return to the quiz; verify that you're at the page you last viewed. 5. Backup the quiz--accept all defaults. 6. Delete the quiz. 7. Restore the quiz--again accepting all defaults. 8. As a student, restart the attempt and verify that you're back at the page you last viewed.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
    • Rank:
      37788

      Description

      I forgot to include currentpage as part of the backup task in MDL-3054. It probably should be backed up, especially if MDL-11047 goes forward.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          Charles, thank you again for working on this. I should have caught this during review too.

          Just two things to sort out before this is submitted for integration:

          1. Please can you write some testing instructions.

          2. The commit comment really ought to mention quiz somewhere. I would probably have written

          MDL-31319 quiz attempts: include currentpage in backup

          (See http://docs.moodle.org/dev/Commit_cheat_sheet).

          One think I fixed:

          I think the Pull from Repository URL needs to be a URL that you can use in a git fetch command, not the github browsing URL, so I corrected it. You might like to note that for future.

          Show
          Tim Hunt added a comment - Charles, thank you again for working on this. I should have caught this during review too. Just two things to sort out before this is submitted for integration: 1. Please can you write some testing instructions. 2. The commit comment really ought to mention quiz somewhere. I would probably have written MDL-31319 quiz attempts: include currentpage in backup (See http://docs.moodle.org/dev/Commit_cheat_sheet ). One think I fixed: I think the Pull from Repository URL needs to be a URL that you can use in a git fetch command, not the github browsing URL, so I corrected it. You might like to note that for future.
          Hide
          Charles Fulton added a comment -

          Tim, thanks as always for the helpful feedback. Commit amended and testing instructions included. Note that I didn't get through these myself because I encountered a completely unrelated bug which I'm now researching.

          Show
          Charles Fulton added a comment - Tim, thanks as always for the helpful feedback. Commit amended and testing instructions included. Note that I didn't get through these myself because I encountered a completely unrelated bug which I'm now researching.
          Hide
          Tim Hunt added a comment -

          Thanks Charles. Submitting for integration.

          Show
          Tim Hunt added a comment - Thanks Charles. Submitting for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Aparup Banerjee added a comment -

          thanks, this has been integrated.

          I'm marking this with docs_required ( like MDL-3054 ).

          Show
          Aparup Banerjee added a comment - thanks, this has been integrated. I'm marking this with docs_required ( like MDL-3054 ).
          Hide
          Aparup Banerjee added a comment -

          linking to other docs_required issue.

          Show
          Aparup Banerjee added a comment - linking to other docs_required issue.
          Hide
          Ankit Agarwal added a comment -

          This is working great!!
          Thanks

          Show
          Ankit Agarwal added a comment - This is working great!! Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for your collaboration, this code has been integrated upstream and it's available in all the repositories.

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for your collaboration, this code has been integrated upstream and it's available in all the repositories. Closing, ciao
          Hide
          Mary Cooch added a comment -

          Documented in 2.3 here http://docs.moodle.org/23/en/Using_Quiz (so removing label)

          Show
          Mary Cooch added a comment - Documented in 2.3 here http://docs.moodle.org/23/en/Using_Quiz (so removing label)

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: