Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.2
    • Fix Version/s: None
    • Component/s: General
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE
    • Rank:
      37792

      Description

      still in beta, but it might be interesting to have it in 2.3 anyway

        Issue Links

          Activity

          Hide
          Jonathan Champ added a comment - - edited

          An example of the things fixed since the version in Moodle master:
          Undefined variable $file is unlink()ed; see https://github.com/moodle/moodle/blob/master/lib/minify/lib/Minify/Cache/File.php#L41

          There's been some amount of fixes on upstream as well: https://github.com/mrclay/minify

          Ran into an issue regarding this the other day. When attempting to obtain the exclusive lock in file_put_contents, the cache file is created but left at zero bytes. The second attempt to read the cache file returns the empty file rather than the uncached contents. The fix was merged to upstream.

          Show
          Jonathan Champ added a comment - - edited An example of the things fixed since the version in Moodle master: Undefined variable $file is unlink()ed; see https://github.com/moodle/moodle/blob/master/lib/minify/lib/Minify/Cache/File.php#L41 There's been some amount of fixes on upstream as well: https://github.com/mrclay/minify Ran into an issue regarding this the other day. When attempting to obtain the exclusive lock in file_put_contents, the cache file is created but left at zero bytes. The second attempt to read the cache file returns the empty file rather than the uncached contents. The fix was merged to upstream.
          Hide
          Petr Škoda added a comment -

          this is obsoleted by MDL-32050, we are going to import 2.1.5 to master soon

          Show
          Petr Škoda added a comment - this is obsoleted by MDL-32050 , we are going to import 2.1.5 to master soon

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: