Moodle
  1. Moodle
  2. MDL-30714 Afterburner Logo does not link to the site homepage
  3. MDL-31324

Afterburner custom css settings do not take effect when making changes to custom menu background colours

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select Afterburner from Theme selector
      2. Make sure that Theme Designer Mode is enabled from Themes settings page
      3. Select Afterburner from the list of theme settings pages from -> Site Administration > Appearance > Themes > ...
      4. Add some custom CSS to change the background color of the custommenu in the area provided.
        Example:
        #custommenu { background-color: #ABC;}
      5. Add a custom menu under "Custom menu items" on -> Site Administration > Appearance > Theme Settings
      6. Save settings
      7. Test to see that the colour of the whole of the custom menu has changed.
      Show
      Select Afterburner from Theme selector Make sure that Theme Designer Mode is enabled from Themes settings page Select Afterburner from the list of theme settings pages from -> Site Administration > Appearance > Themes > ... Add some custom CSS to change the background color of the custommenu in the area provided. Example: #custommenu { background-color: #ABC;} Add a custom menu under "Custom menu items" on -> Site Administration > Appearance > Theme Settings Save settings Test to see that the colour of the whole of the custom menu has changed.
    • Workaround:
      Hide

      The CSS custom settings code, which is currently in afterburner_styles.css, need adding to the newly created css file theme/afterburner/style/afterburner_settings.css

      This file name "afterburner_settings" then needs adding to the end of the list of stylesheets in theme/afterburner/config.php.

      Show
      The CSS custom settings code, which is currently in afterburner_styles.css, need adding to the newly created css file theme/afterburner/style/afterburner_settings.css This file name "afterburner_settings" then needs adding to the end of the list of stylesheets in theme/afterburner/config.php.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      37793

      Description

      Because the order of the stylesheets are important to the cascade of the styles, any custom CSS added by the user, in Afterburner's Custom Setting's page, these changes do not take effect because the style-sheet for the menu is read after the custom settings have been set.

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Thanks Mary - good spotting, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Mary - good spotting, this has been integrated now.
          Hide
          Gerard Caulfield added a comment -

          Fixed on 2.2 and Master. Test passed. Thanks for your awesome work.

          Show
          Gerard Caulfield added a comment - Fixed on 2.2 and Master. Test passed. Thanks for your awesome work.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

          Nah, joking, many thanks! Closing this a fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: