Moodle

MDL-31006 changes introduce mentions of the new-in-2.2 context_system class in 2.1

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.1.4
  • Fix Version/s: 2.1.5
  • Component/s: Enrolments
  • Labels:
  • Testing Instructions:
    Hide

    This is one recent regression to test in 21_STABLE only:

    1) log as admin
    2) go to admin->plugins->Manage enrol plugins
    3) try to show/hide, move up/down some plugins
    4) it works as expected, the "Fatal error: Class 'context_system'" error does not happen anymore.

    Show
    This is one recent regression to test in 21_STABLE only: 1) log as admin 2) go to admin->plugins->Manage enrol plugins 3) try to show/hide, move up/down some plugins 4) it works as expected, the "Fatal error: Class 'context_system'" error does not happen anymore.
  • Affected Branches:
    MOODLE_21_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE
  • Pull from Repository:

Description

See http://moodle.org/mod/forum/discuss.php?d=194417 and https://github.com/moodle/moodle/blob/master/admin/enrol.php#L34

Someone needs to review all the MDL-31006 changes ASAP to make sure there are not more instances like this.

Issue Links

is a regression caused by

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-31006 new warnings and notices in PHP 5.4 #1

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

Obviously https://github.com/moodle/moodle/blob/MOODLE_21_STABLE/admin/enrol.php#L34 is a more significant git link!

Show
Tim Hunt added a comment - Obviously https://github.com/moodle/moodle/blob/MOODLE_21_STABLE/admin/enrol.php#L34 is a more significant git link!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment - - edited

My fault!

I backported the original issue (MDL-31006) to 21_STABLE and, while I reviewed all the rest of uses/changes, I missed that completely!

Sending fix to integration...ciao

PS: Note, I've checked that there are no more context_xxxx::instance() uses in 21_STABLE, and also that MDL-31006 did not introduce any other unsupported API change.

Show
Eloy Lafuente (stronk7) added a comment - - edited My fault! I backported the original issue ( MDL-31006 ) to 21_STABLE and, while I reviewed all the rest of uses/changes, I missed that completely! Sending fix to integration...ciao PS: Note, I've checked that there are no more context_xxxx::instance() uses in 21_STABLE, and also that MDL-31006 did not introduce any other unsupported API change.
Hide
Permalink
Mickel Smith added a comment -

I've applied the fix to my Moodle and it now works, thanks for the assistance.

Show
Mickel Smith added a comment - I've applied the fix to my Moodle and it now works, thanks for the assistance.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Eloy - this has been integrated now

Show
Sam Hemelryk added a comment - Thanks Eloy - this has been integrated now
Hide
Permalink
Gerard Caulfield added a comment -

Problem observed on production 2.1 and fixed in integration 2.1

Test passed

thumbs up

Show
Gerard Caulfield added a comment - Problem observed on production 2.1 and fixed in integration 2.1 Test passed thumbs up
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

Nah, joking, many thanks! Closing this a fixed, ciao

Show
Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: