Moodle
  1. Moodle
  2. MDL-31330

MDL-31006 changes introduce mentions of the new-in-2.2 context_system class in 2.1

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.1.4
    • Fix Version/s: 2.1.5
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide

      This is one recent regression to test in 21_STABLE only:

      1) log as admin
      2) go to admin->plugins->Manage enrol plugins
      3) try to show/hide, move up/down some plugins
      4) it works as expected, the "Fatal error: Class 'context_system'" error does not happen anymore.

      Show
      This is one recent regression to test in 21_STABLE only: 1) log as admin 2) go to admin->plugins->Manage enrol plugins 3) try to show/hide, move up/down some plugins 4) it works as expected, the "Fatal error: Class 'context_system'" error does not happen anymore.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:

      Description

      See http://moodle.org/mod/forum/discuss.php?d=194417 and https://github.com/moodle/moodle/blob/master/admin/enrol.php#L34

      Someone needs to review all the MDL-31006 changes ASAP to make sure there are not more instances like this.

        Gliffy Diagrams

          Issue Links

            Activity

            Tim Hunt created issue -
            Tim Hunt made changes -
            Field Original Value New Value
            Fix Version/s STABLE backlog [ 10463 ]
            Priority Minor [ 4 ] Blocker [ 1 ]
            Labels triaged
            Tim Hunt made changes -
            Link This issue is a regression caused by MDL-31006 [ MDL-31006 ]
            Hide
            Tim Hunt added a comment -
            Show
            Tim Hunt added a comment - Obviously https://github.com/moodle/moodle/blob/MOODLE_21_STABLE/admin/enrol.php#L34 is a more significant git link!
            Eloy Lafuente (stronk7) made changes -
            Assignee Petr Škoda (skodak) [ skodak ] Eloy Lafuente (stronk7) [ stronk7 ]
            Hide
            Eloy Lafuente (stronk7) added a comment - - edited

            My fault!

            I backported the original issue (MDL-31006) to 21_STABLE and, while I reviewed all the rest of uses/changes, I missed that completely!

            Sending fix to integration...ciao

            PS: Note, I've checked that there are no more context_xxxx::instance() uses in 21_STABLE, and also that MDL-31006 did not introduce any other unsupported API change.

            Show
            Eloy Lafuente (stronk7) added a comment - - edited My fault! I backported the original issue ( MDL-31006 ) to 21_STABLE and, while I reviewed all the rest of uses/changes, I missed that completely! Sending fix to integration...ciao PS: Note, I've checked that there are no more context_xxxx::instance() uses in 21_STABLE, and also that MDL-31006 did not introduce any other unsupported API change.
            Eloy Lafuente (stronk7) made changes -
            Status Open [ 1 ] Waiting for integration review [ 10010 ]
            Pull from Repository git://github.com/stronk7/moodle.git
            Fix Version/s 2.1.5 [ 11553 ]
            Fix Version/s STABLE backlog [ 10463 ]
            Testing Instructions This is one recent regression to test in 21_STABLE only:

            1) log as admin
            2) go to admin->plugins->Manage enrol plugins
            3) try to show/hide, move up/down some plugins
            4) it works as expected, the "Fatal error: Class 'context_system'" error does not happen anymore.
            Pull 2.1 Branch MDL-31330_21
            Pull 2.1 Diff URL https://github.com/stronk7/moodle/compare/MOODLE_21_STABLE...MDL-31330_21
            Hide
            Mickel Smith added a comment -

            I've applied the fix to my Moodle and it now works, thanks for the assistance.

            Show
            Mickel Smith added a comment - I've applied the fix to my Moodle and it now works, thanks for the assistance.
            Eloy Lafuente (stronk7) made changes -
            Currently in integration Yes [ 10041 ]
            Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Hide
            Sam Hemelryk added a comment -

            Thanks Eloy - this has been integrated now

            Show
            Sam Hemelryk added a comment - Thanks Eloy - this has been integrated now
            Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Gerard Caulfield made changes -
            Tester gerry
            Gerard Caulfield made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            Gerard Caulfield added a comment -

            Problem observed on production 2.1 and fixed in integration 2.1

            Test passed

            thumbs up

            Show
            Gerard Caulfield added a comment - Problem observed on production 2.1 and fixed in integration 2.1 Test passed thumbs up
            Gerard Caulfield made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many.

            Nah, joking, many thanks! Closing this a fixed, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Your nice code represents only 1/46 of the issues that have been sent upstream this week, so thanks, but not many. Nah, joking, many thanks! Closing this a fixed, ciao
            Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 27/Jan/12

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: