Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31332

Some language packs incorrectly define decsep and/or thousandssep

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1
    • Fix Version/s: None
    • Component/s: Language
    • Labels:
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE

      Description

      See http://moodle.org/mod/forum/discuss.php?d=194416 and http://moodle.org/mod/forum/discuss.php?d=194253

      Presumably AMOS can easily extract a list of languages where decsep and/or thousandssep are blank, or equal to each other. These need to be fixed somehow.

      For PL, it defines decsep = , in langconfig, but does not define thousandssep, so it gets , from english, so the two characters end up the same, which breaks the numerical qtype parsing.

      ES_MX does not define either decsep or thousandssep, and so inherit from Spanish, although, according to Luis Vázquez de Lara, the use English-style . for decsep, not European-style ,.

        Gliffy Diagrams

          Activity

          Hide
          timhunt Tim Hunt added a comment -

          David, can you look into this, and at least try to get an idea of the scale of the problem. Thanks.

          Show
          timhunt Tim Hunt added a comment - David, can you look into this, and at least try to get an idea of the scale of the problem. Thanks.
          Hide
          mudrd8mz David Mudrak added a comment -

          I made a script for AMOS that checks this - https://github.com/moodlehq/moodle-local_amos/commit/4c47312f20c3d3745343def0f29f13f64afc891a I set it to be executed every morning and to send me an email if it detects any problems

          Language pack maintainers were informed about the situation by a post at http://lang.moodle.org/mod/forum/discuss.php?d=1449 I asked them to fix their language packs in a week

          At the end of the next week, I will go through all remaining places that suffer the incorrect definition and will set the separators to the value used in the English (or - if I am not too lazy - to the value which is probably correct for each language).

          So, that should fix the primary source of the problem. However, I think that the numerical qtype should be patched to perform some basic test of reasonable separators values and report eventual problems.

          Show
          mudrd8mz David Mudrak added a comment - I made a script for AMOS that checks this - https://github.com/moodlehq/moodle-local_amos/commit/4c47312f20c3d3745343def0f29f13f64afc891a I set it to be executed every morning and to send me an email if it detects any problems Language pack maintainers were informed about the situation by a post at http://lang.moodle.org/mod/forum/discuss.php?d=1449 I asked them to fix their language packs in a week At the end of the next week, I will go through all remaining places that suffer the incorrect definition and will set the separators to the value used in the English (or - if I am not too lazy - to the value which is probably correct for each language). So, that should fix the primary source of the problem. However, I think that the numerical qtype should be patched to perform some basic test of reasonable separators values and report eventual problems.
          Hide
          mudrd8mz David Mudrak added a comment -

          Koen Roggemans is now cleaning all language packs to make sure the decimals and thousands separators are defined correctly in each langconfig file. Once that is done, we can close this.

          Show
          mudrd8mz David Mudrak added a comment - Koen Roggemans is now cleaning all language packs to make sure the decimals and thousands separators are defined correctly in each langconfig file. Once that is done, we can close this.
          Hide
          koen Koen Roggemans added a comment -

          All done.
          Thanks to the email notification I can keep an eye on it in the future

          Show
          koen Koen Roggemans added a comment - All done. Thanks to the email notification I can keep an eye on it in the future
          Hide
          mudrd8mz David Mudrak added a comment -

          Yay! Thanks a lot Koen. I confirm the Jenkins job is back to normal (success) state now. Closing now.

          Show
          mudrd8mz David Mudrak added a comment - Yay! Thanks a lot Koen. I confirm the Jenkins job is back to normal (success) state now. Closing now.
          Hide
          koen Koen Roggemans added a comment -

          Is it possible to send no email when there is no problem David? An exceptional mail is more likely to be noticed then a pile of mails...

          Show
          koen Koen Roggemans added a comment - Is it possible to send no email when there is no problem David? An exceptional mail is more likely to be noticed then a pile of mails...
          Hide
          mudrd8mz David Mudrak added a comment -

          Yes Koen, it is how it works. Jenkins send emails only if the task ends with "failed" status and it sends one e-mail when the job returns to the normal (i.e. successful) state - which is what happened here - see the subject "back to normal".

          Show
          mudrd8mz David Mudrak added a comment - Yes Koen, it is how it works. Jenkins send emails only if the task ends with "failed" status and it sends one e-mail when the job returns to the normal (i.e. successful) state - which is what happened here - see the subject "back to normal".
          Hide
          koen Koen Roggemans added a comment -

          Relief
          Thanks

          Show
          koen Koen Roggemans added a comment - Relief Thanks

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: