Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31333

MDL-30610 changes breaks restore of 1.9 backups (and II)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide
      • Pick the backup 1.9 reference course from MDL-27495 (backup-refcourse-20110701-2127.zip)
      • Restore it into master
      • TEST: The process must end without any fatal error related to workshopform_rubric_upgrade_weight()
      • Go to the Rubric workshop and "Edit assessment form"
      • TEST: The restored rubric workshop shows levels from 0 to 16 filled for some criteria.
      Show
      Pick the backup 1.9 reference course from MDL-27495 (backup-refcourse-20110701-2127.zip) Restore it into master TEST: The process must end without any fatal error related to workshopform_rubric_upgrade_weight() Go to the Rubric workshop and "Edit assessment form" TEST: The restored rubric workshop shows levels from 0 to 16 filled for some criteria.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      After the major cleanup of upgrade code performed by MDL-30610 and its previous regression fix by MDL-31124, it has been detected that there are still missing stuff to be added-back.

      To reproduce:

      1) Pick the reference 1.9 backup file @ MDL-27495 (backup-refcourse-20110701-2127.zip)
      2) Restore it
      3) Boom: workshopform_rubric_upgrade_weight() missing

        Attachments

          Issue Links

          is a regression caused by

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-30610 drop all upgrade and migration scripts early in 2.3dev

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31314 Restoring backups from 1.9 does not set grade_categories.depth

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Integrator:
              Sam Hemelryk
              Tester:
              Gerard Caulfield
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12