Hi Andrew,
Changes Looks good to me. Just wondereing using English strings directly is allowed in the logs? Shouldn't we be using something that can be translated?
Thanks

Ankit, we dont usually translate log or debugging type messages as they seen by relatively few people. The translators have a big back log and have no real way to know which strings are important so we only put strings in the lang files, thus making them translatable, that are going to be seen by lots of people. That essentially means strings within the UI go into a lang file. Log and debugging type messages get hard coded in English.

Thanks for explaining that Andrew.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

This looks good to integrate in the coming cycle.

FTR ref implementation @ http://fisheye.moodle.org/changelog/Moodle?cs=d23fd32be1da9ccdcdf0baf89579952bcb4a92b0

integrated and up for testing across the branches.

Works Great
Thanks for fixing this Andrew.

Well,

I wish I said it every time
you do the things you do.
You always lend a helping hand,
and I'm filled with gratitude.

You are strong and generous
for each and everyone one of us.
I am eternally grateful,
I cannot say thanks enough.

Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao