Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31335

Tidy up use of mtrace from within email_to_user

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Messages
    • Labels:
    • Testing Instructions:
      Hide

      You will need two users. It helps if you turn maxeditingtime down to 1 minute.

      Check that the email recipient is subscribed to a particular forum.

      Check their messaging preferences to make sure that forum post notifications go to email when they are both on and offline.

      On the messaging preferences page also check what email address their email notifications go to.

      As another user post in the subscribed forum.

      Wait for editing time to expire. Run /admin/cron.php

      Check that the cron output contains something like the below. If you dont see this your editing time probably hasnt elapsed yet.

      Processing user 6
      		 
      Sending post 5: test news topic"

      Check that the cron output contains no errors and that your user receives the email notification.

      Show
      You will need two users. It helps if you turn maxeditingtime down to 1 minute. Check that the email recipient is subscribed to a particular forum. Check their messaging preferences to make sure that forum post notifications go to email when they are both on and offline. On the messaging preferences page also check what email address their email notifications go to. As another user post in the subscribed forum. Wait for editing time to expire. Run /admin/cron.php Check that the cron output contains something like the below. If you dont see this your editing time probably hasnt elapsed yet. Processing user 6 Sending post 5: test news topic" Check that the cron output contains no errors and that your user receives the email notification.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31335_mtrace_email
    • Pull Master Diff URL:

      Description

      While working on MDL-31202 Petr noticed that there are several calls to mtrace within email_to_user that should be altered so that they are not called if this function is called from a web page.
      Have a look at Petr's solution for the noted issue for a good example of what should be done.

        Attachments

          Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31202 Forum emails not being sent, fixed by removing broken email address

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              samhemelryk Sam Hemelryk
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Aparup Banerjee
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12