Moodle
  1. Moodle
  2. MDL-33934 META: Issues with MyMobile theme
  3. MDL-31342

WYSWYG (TinyMCE) html editor difficulties when using MyMobile theme

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1, 2.3.4, 2.4.1, 2.5
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
    • Environment:
      iOS
    • Testing Instructions:
      Hide
      1. Select MyMobile theme from Theme selector.
      2. Set MyMobile theme as Mobile and Tablet device types.
      3. Purge all caches.
      4. Log into moodle using mobile / tablet device.
      5. Create or edit anywhere where a WYSWYG (TinyMCE) html editor would appear such that the text extends beyond the end of the current line.
      6. Type anything, then tap outside the WYSWYG (TinyMCE) box.
      7. TEST that when attempting to type anything you get some response.

      Note: On a mobile device, the TinyMCE window might be big due to the icon size. Therefore a better more flexible version should be in place or the turn off TinyMCE option should be implemented. However, this fix will solve a specific issue in the quest towards a complete solution. Therefore I recommend that MDL-31606 be implemented too.

      Show
      Select MyMobile theme from Theme selector. Set MyMobile theme as Mobile and Tablet device types. Purge all caches. Log into moodle using mobile / tablet device. Create or edit anywhere where a WYSWYG (TinyMCE) html editor would appear such that the text extends beyond the end of the current line. Type anything, then tap outside the WYSWYG (TinyMCE) box. TEST that when attempting to type anything you get some response. Note: On a mobile device, the TinyMCE window might be big due to the icon size. Therefore a better more flexible version should be in place or the turn off TinyMCE option should be implemented. However, this fix will solve a specific issue in the quest towards a complete solution. Therefore I recommend that MDL-31606 be implemented too.
    • Workaround:
      Hide
      • Hiding the onscreen keyboard allows you to continue.
      • Hide the onscreen keyboard, then tap back in the WYSWYG editor.
      • Onscreen keyboard reappears and works.

      Note: This does NOT work for Bluetooth keyboards.

      Apply the changes shown in https://github.com/epsd/moodle/compare/master...MDL-31342

      Show
      Hiding the onscreen keyboard allows you to continue. Hide the onscreen keyboard, then tap back in the WYSWYG editor. Onscreen keyboard reappears and works. Note: This does NOT work for Bluetooth keyboards. Apply the changes shown in https://github.com/epsd/moodle/compare/master...MDL-31342
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-31342_master
    • Rank:
      37818

      Description

      We recently switched to using the MyMobile theme for smart phones and tablets. I've found that anytime I type into a WYSWYG html editor (forums, online text assignment, etc.), I run into an issue. If I tap away from the editor - to scroll down or any other reason - I'm unable to continue typing, even if I tap back into the editor.

      1. mdl_31342_cs.png
        40 kB
      2. mdl_31342_ip.PNG
        55 kB
      3. Mobiledemo.jpg
        92 kB
      4. Simple init.jpg
        25 kB

        Issue Links

          Activity

          Hide
          John Stabinger added a comment -

          What I would like to do is have a 'user theme setting' so that the HTML editor is off by default when using the theme, but it can be toggled on/off by the user should they need to.

          I doubt I would be able to fully correct for this issue otherwise, so implementing this would be the best option.

          Show
          John Stabinger added a comment - What I would like to do is have a 'user theme setting' so that the HTML editor is off by default when using the theme, but it can be toggled on/off by the user should they need to. I doubt I would be able to fully correct for this issue otherwise, so implementing this would be the best option.
          Hide
          Dan Rapoza added a comment -

          Yeah, that would work for us. If it means folks could enter without issue, but limited to plain text, that sounds good to me. Most students / faculty post without major formatting anyway.

          Show
          Dan Rapoza added a comment - Yeah, that would work for us. If it means folks could enter without issue, but limited to plain text, that sounds good to me. Most students / faculty post without major formatting anyway.
          Hide
          John Stabinger added a comment -

          What this does is create a theme based user setting. The user can toggle off/on the tinymce editor. This is necessary for smaller devices where the tinymce editor may cause the page to break, and for performance reasons. This is a theme-based setting, so it will not effect the use of tinymce when using the desktop theme.

          To test, if in browser (two column) mode, use the toggle editor button in left column. Check a textarea to if tinymce is off/on. To test on handheld device, click the settings button to access then follow above advice.

          Show
          John Stabinger added a comment - What this does is create a theme based user setting. The user can toggle off/on the tinymce editor. This is necessary for smaller devices where the tinymce editor may cause the page to break, and for performance reasons. This is a theme-based setting, so it will not effect the use of tinymce when using the desktop theme. To test, if in browser (two column) mode, use the toggle editor button in left column. Check a textarea to if tinymce is off/on. To test on handheld device, click the settings button to access then follow above advice.
          Hide
          Jason Fowler added a comment -

          Code looks fine to me

          Show
          Jason Fowler added a comment - Code looks fine to me
          Hide
          Ruslan Kabalin added a comment - - edited

          The proposed solution is just a workaround, it does not solve the original bug. It might be added as a separate feature (separate tracker issue is needed), but this issue have to remain open IMHO.

          Show
          Ruslan Kabalin added a comment - - edited The proposed solution is just a workaround, it does not solve the original bug. It might be added as a separate feature (separate tracker issue is needed), but this issue have to remain open IMHO.
          Hide
          John Stabinger added a comment -

          I would then propose this gets edited to be a feature then, as the bug itself is not theme related and is tinymce related.

          Show
          John Stabinger added a comment - I would then propose this gets edited to be a feature then, as the bug itself is not theme related and is tinymce related.
          Hide
          Andrew Nicols added a comment -

          Because of the nature of this, I personally think it should go to MOODLE_22_STABLE as well as master.

          Show
          Andrew Nicols added a comment - Because of the nature of this, I personally think it should go to MOODLE_22_STABLE as well as master.
          Hide
          Andrew Nicols added a comment -

          Just noticed a stretch of trailing whitespace in theme/mymobile/javascript/custom.js at line 33 which would need to be sorted before Integration.

          Show
          Andrew Nicols added a comment - Just noticed a stretch of trailing whitespace in theme/mymobile/javascript/custom.js at line 33 which would need to be sorted before Integration.
          Hide
          John Stabinger added a comment -

          Aaack. Let me know if you need me to re-submit with the whitespace removed.

          Show
          John Stabinger added a comment - Aaack. Let me know if you need me to re-submit with the whitespace removed.
          Hide
          Jason Fowler added a comment -

          Thank you for catching that Andrew.

          John if you could fix that and repush it that would be great

          Show
          Jason Fowler added a comment - Thank you for catching that Andrew. John if you could fix that and repush it that would be great
          Hide
          Michael de Raadt added a comment -

          Hi, All.

          I'm going to create a second issue to handle the desired new functionality and restore this issue to its original intent so that it can be dealt with in future.

          Show
          Michael de Raadt added a comment - Hi, All. I'm going to create a second issue to handle the desired new functionality and restore this issue to its original intent so that it can be dealt with in future.
          Hide
          Michael de Raadt added a comment -

          I'm moving over the Git details to the linked issue.

          Show
          Michael de Raadt added a comment - I'm moving over the Git details to the linked issue.
          Hide
          Michael de Raadt added a comment -

          Thanks to John and everyone working on this issue.

          Hopefully this separation will allow us to keen the necessary granularity.

          Show
          Michael de Raadt added a comment - Thanks to John and everyone working on this issue. Hopefully this separation will allow us to keen the necessary granularity.
          Hide
          Jason Fowler added a comment - - edited

          Quick change to the work around and related issue to make it more clear which code belongs where.

          Having looked at the issue further, with input from Michael de Raadt, I think the solution provided is more of a work around. I don't know what the final solution would be, but it needs to be more than the ability to toggle the HTML editor

          Show
          Jason Fowler added a comment - - edited Quick change to the work around and related issue to make it more clear which code belongs where. Having looked at the issue further, with input from Michael de Raadt, I think the solution provided is more of a work around. I don't know what the final solution would be, but it needs to be more than the ability to toggle the HTML editor
          Hide
          Gareth J Barnard added a comment - - edited

          I think this issue is because of the 'data-ajax' issue when first loading a page that any JavaScript that is outside of the 'data-role="page"' div is not executed on page load, please see comments of 18th Feb 2013 on MDL-33115. And hence as the TinyMCE is JS based something is going wrong. I just did a test and I think my fix for Collapsed Topics will work with this too. The fix is a simple end tag 'div' move in the layout files, so no contrib code required. To summarise for Moodle 2.3 (what is stated on MDL-33115):

          with layout/general.php change:

                  </div>
              </div><!-- ends page -->
          
              <!-- empty divs with info for the JS to use -->
              <div id="<?php echo sesskey(); ?>" class="mobilesession"></div>
              <div id="<?php p($CFG->wwwroot); ?>" class="mobilesiteurl"></div>
              <div id="<?php echo $dtheme;?>" class="datatheme"></div>
              <div id="<?php echo $dthemeb;?>" class="datathemeb"></div>
              <div id="page-footer"><!-- empty page footer needed by moodle yui for embeds --></div>
              <!-- end js divs -->
          
              <?php echo $OUTPUT->standard_end_of_body_html() ?>
          </body>
          

          to

                  </div>
          
                  <!-- empty divs with info for the JS to use -->
                  <div id="<?php echo sesskey(); ?>" class="mobilesession"></div>
                  <div id="<?php p($CFG->wwwroot); ?>" class="mobilesiteurl"></div>
                  <div id="<?php echo $dtheme;?>" class="datatheme"></div>
                  <div id="<?php echo $dthemeb;?>" class="datathemeb"></div>
                  <div id="page-footer"><!-- empty page footer needed by moodle yui for embeds --></div>
                  <!-- end js divs -->
          
              <?php echo $OUTPUT->standard_end_of_body_html() ?>
              </div><!-- ends page -->
          </body>
          

          And do a similar thing with 'layout/embedded.php'. Thus slightly changing the page structure, but bringing in any footer JavaScript added in by the page requirements manager into the scope of the data-role="page".

          Cheers,

          Gareth

          P.S. I noticed this issue today with M2.4 on the course format's forum using an iPod Touch and had the same issue.

          Show
          Gareth J Barnard added a comment - - edited I think this issue is because of the 'data-ajax' issue when first loading a page that any JavaScript that is outside of the 'data-role="page"' div is not executed on page load, please see comments of 18th Feb 2013 on MDL-33115 . And hence as the TinyMCE is JS based something is going wrong. I just did a test and I think my fix for Collapsed Topics will work with this too. The fix is a simple end tag 'div' move in the layout files, so no contrib code required. To summarise for Moodle 2.3 (what is stated on MDL-33115 ): with layout/general.php change: </div> </div><!-- ends page --> <!-- empty divs with info for the JS to use --> <div id= "<?php echo sesskey(); ?>" class= "mobilesession" ></div> <div id= "<?php p($CFG->wwwroot); ?>" class= "mobilesiteurl" ></div> <div id= "<?php echo $dtheme;?>" class= "datatheme" ></div> <div id= "<?php echo $dthemeb;?>" class= "datathemeb" ></div> <div id= "page-footer" ><!-- empty page footer needed by moodle yui for embeds --></div> <!-- end js divs --> <?php echo $OUTPUT->standard_end_of_body_html() ?> </body> to </div> <!-- empty divs with info for the JS to use --> <div id= "<?php echo sesskey(); ?>" class= "mobilesession" ></div> <div id= "<?php p($CFG->wwwroot); ?>" class= "mobilesiteurl" ></div> <div id= "<?php echo $dtheme;?>" class= "datatheme" ></div> <div id= "<?php echo $dthemeb;?>" class= "datathemeb" ></div> <div id= "page-footer" ><!-- empty page footer needed by moodle yui for embeds --></div> <!-- end js divs --> <?php echo $OUTPUT->standard_end_of_body_html() ?> </div><!-- ends page --> </body> And do a similar thing with 'layout/embedded.php'. Thus slightly changing the page structure, but bringing in any footer JavaScript added in by the page requirements manager into the scope of the data-role="page". Cheers, Gareth P.S. I noticed this issue today with M2.4 on the course format's forum using an iPod Touch and had the same issue.
          Hide
          Mary Evans added a comment -

          @Gareth: I agree with moving the closing tag for page. But I also think #page-header and #page-footer should have been incorporated into the code for header and footer as these markers are need. Why John moved away from that I will never know. You could lose that empty page-header div tag then. That would be one less to worry about!

          Show
          Mary Evans added a comment - @Gareth: I agree with moving the closing tag for page. But I also think #page-header and #page-footer should have been incorporated into the code for header and footer as these markers are need. Why John moved away from that I will never know. You could lose that empty page-header div tag then. That would be one less to worry about!
          Hide
          Mary Evans added a comment -

          Assigning this to you Gareth. Thanks

          Show
          Mary Evans added a comment - Assigning this to you Gareth. Thanks
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans,

          Ok - I'll have a look at what wrapping layout within #page-header and #page-footer does. Is John contactable to ask?

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans , Ok - I'll have a look at what wrapping layout within #page-header and #page-footer does. Is John contactable to ask? Cheers, Gareth
          Hide
          Mary Evans added a comment -

          As far as I know Yes, I'll send you his email.

          Show
          Mary Evans added a comment - As far as I know Yes, I'll send you his email.
          Hide
          Mary Evans added a comment -

          @Gareth: Can put the files through their paces in CodeChecker before rebasing this branch?

          Thanks

          Show
          Mary Evans added a comment - @Gareth: Can put the files through their paces in CodeChecker before rebasing this branch? Thanks
          Hide
          Gareth J Barnard added a comment -

          Mary Evans

          Put the layout files through the code checker and did some reasonable cleaning - not all as the code checker is not bright enough yet. All branches done.

          Found http://developer.yahoo.com/yui/editor/ and wondered if it would be better?

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Mary Evans Put the layout files through the code checker and did some reasonable cleaning - not all as the code checker is not bright enough yet. All branches done. Found http://developer.yahoo.com/yui/editor/ and wondered if it would be better? Cheers, Gareth
          Hide
          Mary Evans added a comment - - edited

          @Gareth: Testers don't add the fix, they test the branch, so it matters not what the patch is fixing only that it works. I'll change the instruction when I've done Peer Reviewing. Thanks

          Show
          Mary Evans added a comment - - edited @Gareth: Testers don't add the fix, they test the branch, so it matters not what the patch is fixing only that it works. I'll change the instruction when I've done Peer Reviewing. Thanks
          Hide
          Gareth J Barnard added a comment -

          Image mdl_31342_cs.png shows the custom settings needed to reduce the size of TinyMCE down to what a mobile / tablet user would want and image mdl_31342_ip.png shows the effect on an iPod Touch.

          Just need to figure out programatically how to set this within the theme.

          Show
          Gareth J Barnard added a comment - Image mdl_31342_cs.png shows the custom settings needed to reduce the size of TinyMCE down to what a mobile / tablet user would want and image mdl_31342_ip.png shows the effect on an iPod Touch. Just need to figure out programatically how to set this within the theme.
          Hide
          Mauno Korpelainen added a comment -

          Gareth,

          if you need to set different editor theme (or otherwise different tinymce init code) for mobiles and tablets you can add to file lib/editor/tinymce/lib.php something like

          if (get_device_type() == "mobile" || get_device_type() == "tablet") {$mtheme = 'simple';} else {$mtheme = 'advanced';}

          for example before

          $params = array(

          and then a couple of rows later

          'theme' => $mtheme,

          This way mobile and tablet devices show simple theme with default simple theme settings and other devices show advanced theme with given settings of advanced theme.

          It is of course possible to use any other settings the same way or to have totally different init code for mobile devices, tablet devices and other devices.

          Show
          Mauno Korpelainen added a comment - Gareth, if you need to set different editor theme (or otherwise different tinymce init code) for mobiles and tablets you can add to file lib/editor/tinymce/lib.php something like if (get_device_type() == "mobile" || get_device_type() == "tablet") {$mtheme = 'simple';} else {$mtheme = 'advanced';} for example before $params = array( and then a couple of rows later 'theme' => $mtheme, This way mobile and tablet devices show simple theme with default simple theme settings and other devices show advanced theme with given settings of advanced theme. It is of course possible to use any other settings the same way or to have totally different init code for mobile devices, tablet devices and other devices.
          Hide
          Mauno Korpelainen added a comment -

          And if you use in lib/editor/tinymce/lib.php
          ...
          'theme' => $mtheme,
          'width' => "auto",
          ...
          tinymce is trying to fit those buttons of simple theme (or advanced theme) to given space.

          Show
          Mauno Korpelainen added a comment - And if you use in lib/editor/tinymce/lib.php ... 'theme' => $mtheme, 'width' => "auto", ... tinymce is trying to fit those buttons of simple theme (or advanced theme) to given space.
          Hide
          Gareth J Barnard added a comment -

          Dear Mauno Korpelainen,

          Thank you I'd started to bump into that file and wondered how I could set the parameters externally not thinking that an internal tweak could be appropriate .

          I'll have a bash and see what transpires.

          Thanks again,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mauno Korpelainen , Thank you I'd started to bump into that file and wondered how I could set the parameters externally not thinking that an internal tweak could be appropriate . I'll have a bash and see what transpires. Thanks again, Gareth
          Hide
          Mary Evans added a comment -

          @Gareth:

          Is this ready to be submitted for Integration Review, if so I can set wheels in motion ready for next pull?

          Show
          Mary Evans added a comment - @Gareth: Is this ready to be submitted for Integration Review, if so I can set wheels in motion ready for next pull?
          Hide
          Mauno Korpelainen added a comment -

          Gareth,

          if you want to override the default init code of tinymce you can as well add a new init code just before </body> tag (not to header) to theme/mymobile/layout/general.php , for example

          <?php if ($mydevice != 'mobile' || $mydevice != 'tablet') { ?>
          <script type="text/javascript">
          tinyMCE.init(

          { mode : "textareas", theme : "simple", width : "auto" }

          );
          </script>
          <?php } ?>

          Then the changes take action only in mymobile theme

          Show
          Mauno Korpelainen added a comment - Gareth, if you want to override the default init code of tinymce you can as well add a new init code just before </body> tag (not to header) to theme/mymobile/layout/general.php , for example <?php if ($mydevice != 'mobile' || $mydevice != 'tablet') { ?> <script type="text/javascript"> tinyMCE.init( { mode : "textareas", theme : "simple", width : "auto" } ); </script> <?php } ?> Then the changes take action only in mymobile theme
          Hide
          Mauno Korpelainen added a comment -

          Attached a screenshot about mymobile using simple theme with auto width (init code before body end tag in layout file general.php)

          Show
          Mauno Korpelainen added a comment - Attached a screenshot about mymobile using simple theme with auto width (init code before body end tag in layout file general.php)
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans,

          In light of new information provided by Mauno I would like to quickly shrink the TinyMCE editor with an exact mode and smaller number of menu items to be more usuable.

          Then submit for integration, as a smaller interface will be better for the tester to test.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans , In light of new information provided by Mauno I would like to quickly shrink the TinyMCE editor with an exact mode and smaller number of menu items to be more usuable. Then submit for integration, as a smaller interface will be better for the tester to test. Cheers, Gareth
          Hide
          Gareth J Barnard added a comment -

          Thanks for the extra info Mauno

          Show
          Gareth J Barnard added a comment - Thanks for the extra info Mauno
          Hide
          Mary Evans added a comment -

          In that case, Gareth, I'll end peer review, and sign it back to you to continue development so that you can continue improving this.
          Thanks

          Show
          Mary Evans added a comment - In that case, Gareth, I'll end peer review, and sign it back to you to continue development so that you can continue improving this. Thanks
          Hide
          Mauno Korpelainen added a comment -

          In that previous code you should of course have

          <?php if ($mydevice == 'mobile' || $mydevice == 'tablet') { ?>
          <script type="text/javascript">
          tinyMCE.init(

          { ... }

          );
          </script>
          <?php }

          ?>

          and you could make sure that setting

          $USER->htmleditor

          is respected... ( users can set this to '0' if they want to use standard text forms and '1' for HTML editor in their profiles )

          I was testing last night a different mobile editor theme and it is actually a good option too because there are no limits in modifying a custom editor theme. Personally I would like to use some other buttons also in mobiles in addition to those in simple theme, so I might use as a first step solution advanced theme with some chosen buttons in init code of mobiles because advanced theme has those other settings specially added to advanced theme and simple theme does not have similar (advanced) settings.

          Ideally (in my opinion) next versions of moodle could have separate settings for mobiles in site administration and these could be changed (if allowed) by some user preferences/plugin settings/theme settings etc.

          Show
          Mauno Korpelainen added a comment - In that previous code you should of course have <?php if ($mydevice == 'mobile' || $mydevice == 'tablet') { ?> <script type="text/javascript"> tinyMCE.init( { ... } ); </script> <?php } ?> and you could make sure that setting $USER->htmleditor is respected... ( users can set this to '0' if they want to use standard text forms and '1' for HTML editor in their profiles ) I was testing last night a different mobile editor theme and it is actually a good option too because there are no limits in modifying a custom editor theme. Personally I would like to use some other buttons also in mobiles in addition to those in simple theme, so I might use as a first step solution advanced theme with some chosen buttons in init code of mobiles because advanced theme has those other settings specially added to advanced theme and simple theme does not have similar (advanced) settings. Ideally (in my opinion) next versions of moodle could have separate settings for mobiles in site administration and these could be changed (if allowed) by some user preferences/plugin settings/theme settings etc.
          Hide
          Gareth J Barnard added a comment -

          Dear Mauno,

          I'm messing around with the MyMobile theme and including a script at the bottom of the page either with the page requirements manager or a straight import and cannot get it to operate. IMHO this is getting messy with user editor checking etc. Because if they were using a HTML Editor but it was another then conflicts etc. So, my gut is saying to make a change to the tinyMCE lib.php and reduce the menu options available in the advanced mode for mobiles / tablets as they do not need things like 'paste from Word'.

          Then a fuller progressional argument for improving TinyMCE in Moodle for fuller user / theme configuration can be born on the back of this.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mauno, I'm messing around with the MyMobile theme and including a script at the bottom of the page either with the page requirements manager or a straight import and cannot get it to operate. IMHO this is getting messy with user editor checking etc. Because if they were using a HTML Editor but it was another then conflicts etc. So, my gut is saying to make a change to the tinyMCE lib.php and reduce the menu options available in the advanced mode for mobiles / tablets as they do not need things like 'paste from Word'. Then a fuller progressional argument for improving TinyMCE in Moodle for fuller user / theme configuration can be born on the back of this. Cheers, Gareth
          Hide
          Gareth J Barnard added a comment -

          Notes:

          To have MyMobile define it's own custom options though the creation of a tinymce_mymobile class it would have to have a pattern of being discovered in 'all_update_init_params()' of '/lib/editor/tinymce/classes/plugin.php' in its call to 'get_plugin_list()' with a parameter of 'tinymce' in '/ib/moodlelib.php', but with that parameter 'themes' are not taken into account because they are 'special'. So, need to have a clever advanced 'get_init_params()' in '/lib/editor/tinymce/lib.php'.

          Show
          Gareth J Barnard added a comment - Notes: To have MyMobile define it's own custom options though the creation of a tinymce_mymobile class it would have to have a pattern of being discovered in 'all_update_init_params()' of '/lib/editor/tinymce/classes/plugin.php' in its call to 'get_plugin_list()' with a parameter of 'tinymce' in '/ib/moodlelib.php', but with that parameter 'themes' are not taken into account because they are 'special'. So, need to have a clever advanced 'get_init_params()' in '/lib/editor/tinymce/lib.php'.
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans and Mauno Korpelainen,

          I've done some changes to the master branch in terms of TinyMCE adaptation. Mobiles use a simple interface, tablets a reduced advanced interface and everything else no change. What do you think?

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans and Mauno Korpelainen , I've done some changes to the master branch in terms of TinyMCE adaptation. Mobiles use a simple interface, tablets a reduced advanced interface and everything else no change. What do you think? Cheers, Gareth
          Hide
          Mary Evans added a comment -

          Just thinking, surely this extra work to change the way TinyMCE works should be fixed in MDL-31606

          Whereas the original fix for this issue is as you had it previously, isn't it?

          Show
          Mary Evans added a comment - Just thinking, surely this extra work to change the way TinyMCE works should be fixed in MDL-31606 Whereas the original fix for this issue is as you had it previously, isn't it?
          Hide
          Mauno Korpelainen added a comment -

          Garreth,

          the main idea there is perfect. I was just testing with old 2.2 lib.php and noticed that mobiles can't use most plugins and some tablets may have similar problems. And HTML inlinepopup was not optimal for mobiles because it was too big size and you need to scroll down to find the Update button...

          Anyway, I tested this kind of settings for mobiles (note - not simple theme but advanced theme with selected buttons). Note also that if this goes to core safari plugin was removed from core tinymce 3 years ago and you could add lists plugin to safari-plugins place to avoid Webkit-list bugs:

          if (get_device_type() == "mobile" || get_device_type() == "tablet")

          { $params = array( 'mode' => "exact", 'elements' => $elementid, 'relative_urls' => false, 'document_base_url' => $CFG->httpswwwroot, 'content_css' => $contentcss, 'language' => $lang, 'directionality' => $directionality, 'theme' => 'advanced', 'width' => "auto", 'skin' => "o2k7", 'skin_variant' => "silver", 'apply_source_formatting' => true, 'remove_script_host' => false, 'entity_encoding' => "raw", 'plugins' => "lists,inlinepopups", 'theme_advanced_layout_manager' => "SimpleLayout", 'theme_advanced_toolbar_align' => "left", 'theme_advanced_buttons1' => "bold,italic,underline,strikethrough,bullist,numlist,outdent,indent", 'theme_advanced_buttons1_add' => "undo,code", 'theme_advanced_buttons2' => "", 'theme_advanced_buttons3' => "", 'theme_advanced_resize_horizontal' => true, 'theme_advanced_resizing' => true, 'theme_advanced_resizing_min_height' => 30, 'theme_advanced_toolbar_location' => "top", 'theme_advanced_statusbar_location' => "bottom" ); }

          else {$params = array( the original settings here...);
          }

          Your idea to use different settings for tablets is of course better - just check which plugins work in tablets and which don't.

          Show
          Mauno Korpelainen added a comment - Garreth, the main idea there is perfect. I was just testing with old 2.2 lib.php and noticed that mobiles can't use most plugins and some tablets may have similar problems. And HTML inlinepopup was not optimal for mobiles because it was too big size and you need to scroll down to find the Update button... Anyway, I tested this kind of settings for mobiles (note - not simple theme but advanced theme with selected buttons). Note also that if this goes to core safari plugin was removed from core tinymce 3 years ago and you could add lists plugin to safari-plugins place to avoid Webkit-list bugs: if (get_device_type() == "mobile" || get_device_type() == "tablet") { $params = array( 'mode' => "exact", 'elements' => $elementid, 'relative_urls' => false, 'document_base_url' => $CFG->httpswwwroot, 'content_css' => $contentcss, 'language' => $lang, 'directionality' => $directionality, 'theme' => 'advanced', 'width' => "auto", 'skin' => "o2k7", 'skin_variant' => "silver", 'apply_source_formatting' => true, 'remove_script_host' => false, 'entity_encoding' => "raw", 'plugins' => "lists,inlinepopups", 'theme_advanced_layout_manager' => "SimpleLayout", 'theme_advanced_toolbar_align' => "left", 'theme_advanced_buttons1' => "bold,italic,underline,strikethrough,bullist,numlist,outdent,indent", 'theme_advanced_buttons1_add' => "undo,code", 'theme_advanced_buttons2' => "", 'theme_advanced_buttons3' => "", 'theme_advanced_resize_horizontal' => true, 'theme_advanced_resizing' => true, 'theme_advanced_resizing_min_height' => 30, 'theme_advanced_toolbar_location' => "top", 'theme_advanced_statusbar_location' => "bottom" ); } else {$params = array( the original settings here...); } Your idea to use different settings for tablets is of course better - just check which plugins work in tablets and which don't.
          Hide
          Mauno Korpelainen added a comment -

          Attached a screenshot of example toolbar for mobiles (advanced theme with advanced settings but only some selected buttons for mobiles).

          Show
          Mauno Korpelainen added a comment - Attached a screenshot of example toolbar for mobiles (advanced theme with advanced settings but only some selected buttons for mobiles).
          Hide
          Mauno Korpelainen added a comment -

          Some more info why 'lists' plugin is necessary in MDL-38329 or for example in http://tinymcesupport.com/tutorials/lists-better-lists-plugin

          Show
          Mauno Korpelainen added a comment - Some more info why 'lists' plugin is necessary in MDL-38329 or for example in http://tinymcesupport.com/tutorials/lists-better-lists-plugin
          Hide
          Petr Škoda added a comment -

          Hello, I personally do not like the approach used in the linked patch - I believe we should not be hardcoding configuration like this, instead we could for example add 3 different toolbar options (normal, mobile, tablet) with reasonable defaults and let admins decide what is best for their users. Also please never do unrelated whitespace tweaks together with code changes.

          Show
          Petr Škoda added a comment - Hello, I personally do not like the approach used in the linked patch - I believe we should not be hardcoding configuration like this, instead we could for example add 3 different toolbar options (normal, mobile, tablet) with reasonable defaults and let admins decide what is best for their users. Also please never do unrelated whitespace tweaks together with code changes.
          Hide
          Mauno Korpelainen added a comment -

          Petr,

          yes - different editor settings that could be edited in site administration menu separately for normal devices, tablets and mobiles is the best solution if it can be implemented. And if no site settings are changed some reasonable default settings separately for these devices

          Show
          Mauno Korpelainen added a comment - Petr, yes - different editor settings that could be edited in site administration menu separately for normal devices, tablets and mobiles is the best solution if it can be implemented. And if no site settings are changed some reasonable default settings separately for these devices
          Hide
          Gareth J Barnard added a comment -

          Dear all,

          Upon reflection and careful consideration I have decided not to form a TinyMCE layout change within this tracker but only concentrate on the key fix.

          The proposed solution only changed the interface depending on the device type by manipulating existing hard coded values. It went beyond MDL-31606 in respect to being for all themes of the portable device genre. And given that MDL-38329 needs fixing as a separate issue.

          Perhaps the best solution is an implementation of Petr's idea of '3 different toolbar options (normal, mobile, tablet)' combined with theme selection in code (and via user customiseable setting if desired) of the best option for a given theme. After all, it is the layout space and audience target of the theme that is at issue, so perhaps for the theme to control and manage.

          Therefore, I have reverted the master branch and will submit for peer review.

          Thank you all for your input, I think it's time to migrate those ideas to other trackers dedicated to TinyMCE.

          Thanks,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear all, Upon reflection and careful consideration I have decided not to form a TinyMCE layout change within this tracker but only concentrate on the key fix. The proposed solution only changed the interface depending on the device type by manipulating existing hard coded values. It went beyond MDL-31606 in respect to being for all themes of the portable device genre. And given that MDL-38329 needs fixing as a separate issue. Perhaps the best solution is an implementation of Petr's idea of '3 different toolbar options (normal, mobile, tablet)' combined with theme selection in code (and via user customiseable setting if desired) of the best option for a given theme. After all, it is the layout space and audience target of the theme that is at issue, so perhaps for the theme to control and manage. Therefore, I have reverted the master branch and will submit for peer review. Thank you all for your input, I think it's time to migrate those ideas to other trackers dedicated to TinyMCE. Thanks, Gareth
          Hide
          Mary Evans added a comment - - edited

          @Petr: It was on my instruction that Gareth ran those files through Codechecker and fixed the problems. I was told to do this recently myself so I thought it was important?

          Show
          Mary Evans added a comment - - edited @Petr: It was on my instruction that Gareth ran those files through Codechecker and fixed the problems. I was told to do this recently myself so I thought it was important?
          Hide
          Petr Škoda added a comment -

          Each commit should contain only related chanches, no extra cleanup. The codechecker should be used for new code, it is not going to make your code any better, just subjectively nicer. When doing fixes try to match the surrounding coding style and cleaup things in separate commits.

          Show
          Petr Škoda added a comment - Each commit should contain only related chanches, no extra cleanup. The codechecker should be used for new code, it is not going to make your code any better, just subjectively nicer. When doing fixes try to match the surrounding coding style and cleaup things in separate commits.
          Hide
          Gareth J Barnard added a comment -

          Ok, can this be circulated to all peer reviewers and integrators please?

          And can there be a 'CodeChecker-a-thon' like 'Hack-a-thon' (http://docs.moodle.org/dev/Hack-a-thon_2013)? Such that new code checker code matches the same style of core and encourages new developers to adopt the new style and not learn bad habits that then need to be corrected.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Ok, can this be circulated to all peer reviewers and integrators please? And can there be a 'CodeChecker-a-thon' like 'Hack-a-thon' ( http://docs.moodle.org/dev/Hack-a-thon_2013)? Such that new code checker code matches the same style of core and encourages new developers to adopt the new style and not learn bad habits that then need to be corrected. Cheers, Gareth
          Hide
          Mary Evans added a comment - - edited

          @Petr: I know it makes the code look more regimented, and I have learnt quite a bit from using Codecheker. However, it's little comments like...

          I'll attach the output I get from jshint to this bug (58 warnings).

          I also see white space errors in "theme/mymobile/settings.php"

          Thanks, Damyon MDL-33934

          ...which can be quite un-nerving at the time, and make you feel it is something important.

          It would be good to have some clarity with this, since I have submitted code and whitespace clean-up, none intentionally, mainly with CSS as my Text Editor is set up to convert tabs to spaces and remove end of line spaces.

          Perhaps Gareth is right in asking for a CodeChecker-a-thon.

          Show
          Mary Evans added a comment - - edited @Petr: I know it makes the code look more regimented, and I have learnt quite a bit from using Codecheker. However, it's little comments like... I'll attach the output I get from jshint to this bug (58 warnings). I also see white space errors in "theme/mymobile/settings.php" Thanks, Damyon MDL-33934 ...which can be quite un-nerving at the time, and make you feel it is something important. It would be good to have some clarity with this, since I have submitted code and whitespace clean-up, none intentionally, mainly with CSS as my Text Editor is set up to convert tabs to spaces and remove end of line spaces. Perhaps Gareth is right in asking for a CodeChecker-a-thon.
          Hide
          Petr Škoda added a comment -

          I said do not mix bugfix and whitepace cleanup in ONE commit because it obfuscates the real code change. Also there should be no whitespace cleanups in stable branches. You do not need to use the codechecker to create nice readable code, but if you can not do that on your own people start telling you to use the checker because it is easier than trying to describe inconsistencies in your code...

          Show
          Petr Škoda added a comment - I said do not mix bugfix and whitepace cleanup in ONE commit because it obfuscates the real code change. Also there should be no whitespace cleanups in stable branches. You do not need to use the codechecker to create nice readable code, but if you can not do that on your own people start telling you to use the checker because it is easier than trying to describe inconsistencies in your code...
          Hide
          Gareth J Barnard added a comment -

          Dear Petr Škoda,

          After twenty nine years of coding I write beautiful code, so elegant and stylish that it could stride down a cat walk and turn heads. However, it is my style and not the Moodle 'couture' way hence needing to use code-checker to correct the style when I emulate what has gone before. But the Catch-22 of it is that the old code is not Moodle couture. So, what do I do, I code check it and put it all in one commit. I put it in one commit because if I have more than one commit then the integrator dismisses it because it is not 'one' commit - again, something Joseph Heller could have written.

          So, therefore to encourage new developers to learn how to create Moodle couture there should be a lead-by-example and existing code should be cleaned up, stable or otherwise. Consistency by example, inconsistency through lack of standards application.

          And pragmatically, why are stable branches not cleaned when code checker is being employed as a whipping stick?

          If all of this is documented in a standards way and I've somehow missed it then fair enough. Either because of lack of hunting or something else. But the question to ask is 'why' I've missed it. Have I not been given sufficient training? If so, why not and whom is responsible? Is there a part of the process that needs to be amended?

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Petr Škoda , After twenty nine years of coding I write beautiful code, so elegant and stylish that it could stride down a cat walk and turn heads. However, it is my style and not the Moodle 'couture' way hence needing to use code-checker to correct the style when I emulate what has gone before. But the Catch-22 of it is that the old code is not Moodle couture. So, what do I do, I code check it and put it all in one commit. I put it in one commit because if I have more than one commit then the integrator dismisses it because it is not 'one' commit - again, something Joseph Heller could have written. So, therefore to encourage new developers to learn how to create Moodle couture there should be a lead-by-example and existing code should be cleaned up, stable or otherwise. Consistency by example, inconsistency through lack of standards application. And pragmatically, why are stable branches not cleaned when code checker is being employed as a whipping stick? If all of this is documented in a standards way and I've somehow missed it then fair enough. Either because of lack of hunting or something else. But the question to ask is 'why' I've missed it. Have I not been given sufficient training? If so, why not and whom is responsible? Is there a part of the process that needs to be amended? Cheers, Gareth
          Hide
          Gareth J Barnard added a comment -

          P.S. MDL-33934 is a bug fix. Bug fixes are applied to stable branches. So why is Mary being told code check it when code checker does not apply to stable branches? And I know you said "easier than trying to describe inconsistencies in your code" but if code-checker is then employed as recommended to clean the code then it's just been employed by the developer to clean the very code that is not allowed to be cleaned by code-checker because it's a stable branch. Catch-22.

          Show
          Gareth J Barnard added a comment - P.S. MDL-33934 is a bug fix. Bug fixes are applied to stable branches. So why is Mary being told code check it when code checker does not apply to stable branches? And I know you said "easier than trying to describe inconsistencies in your code" but if code-checker is then employed as recommended to clean the code then it's just been employed by the developer to clean the very code that is not allowed to be cleaned by code-checker because it's a stable branch. Catch-22.
          Hide
          Gareth J Barnard added a comment -

          P.P.S. Rant over. Lets make things better

          Show
          Gareth J Barnard added a comment - P.P.S. Rant over. Lets make things better
          Hide
          Mary Evans added a comment -

          Indeed!

          Show
          Mary Evans added a comment - Indeed!
          Hide
          Petr Škoda added a comment -

          Let me summarise my advice again:

          1. please read our http://docs.moodle.org/dev/Coding_style guide
          2. learn the general git commit etiquette
          3. do not touch stable unless there is a real bug, fix only that and nothing else
          4. please try to not blame others for the lack of documentation, please help us improve it instead

          Anyway thanks for your contribution, +1 for the mobile theme changes in master branch.

          Show
          Petr Škoda added a comment - Let me summarise my advice again: 1. please read our http://docs.moodle.org/dev/Coding_style guide 2. learn the general git commit etiquette 3. do not touch stable unless there is a real bug, fix only that and nothing else 4. please try to not blame others for the lack of documentation, please help us improve it instead Anyway thanks for your contribution, +1 for the mobile theme changes in master branch.
          Hide
          Mary Evans added a comment -

          In light of this discussion, these fixes can only go into Moodle (master).

          Show
          Mary Evans added a comment - In light of this discussion, these fixes can only go into Moodle (master).
          Hide
          Gareth J Barnard added a comment -

          Dear Petr Škoda,

          Please could I kindly summerise:

          1. I have.
          2. I have, but the hard way.
          3. Ok, but please can all reviewers / integrators be consistent on this.
          4. You misinterpret my comments, I'm not blaming others and I am offering more beyond what I am already doing. Perhaps it is it's exposure that needs improving.

          For point 4, I found http://dev.moodle.org/ and http://www.synergy-learning.com/blog/synergy-news/moodle-developer-training/ - so is there or could there be a 'Moodle Developers Certificate' just like the 'Course creators certificate' as seen by the icon on the forums? I'm totally willing to contribute to this.

          I know how much you have given to Moodle through the commits and work, so please take this as a discussion rather than a criticism. If I've made mistakes then I need to understand why I have made mistakes and because of what, then perform corrective measures to rectify that mistake.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Petr Škoda , Please could I kindly summerise: 1. I have. 2. I have, but the hard way. 3. Ok, but please can all reviewers / integrators be consistent on this. 4. You misinterpret my comments, I'm not blaming others and I am offering more beyond what I am already doing. Perhaps it is it's exposure that needs improving. For point 4, I found http://dev.moodle.org/ and http://www.synergy-learning.com/blog/synergy-news/moodle-developer-training/ - so is there or could there be a 'Moodle Developers Certificate' just like the 'Course creators certificate' as seen by the icon on the forums? I'm totally willing to contribute to this. I know how much you have given to Moodle through the commits and work, so please take this as a discussion rather than a criticism. If I've made mistakes then I need to understand why I have made mistakes and because of what, then perform corrective measures to rectify that mistake. Cheers, Gareth
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans,

          Is there a way we could get the two stable branches in as really need this?

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans , Is there a way we could get the two stable branches in as really need this? Cheers, Gareth
          Hide
          Mary Evans added a comment - - edited

          I left the branches in so we can only wait and see what Sam Hemelryk says.

          Sam is pretty good and I don't see any real problems with the fix as you have it as it will help solve this issue.

          It's currently in integration now so lets see where we get with it, and what we can learn from it.

          Lets face it we need to get the MyMobile theme working in 2.4 so the sooner this gets sorted the quicker we can fix all those other trackers that have been reported.

          Show
          Mary Evans added a comment - - edited I left the branches in so we can only wait and see what Sam Hemelryk says. Sam is pretty good and I don't see any real problems with the fix as you have it as it will help solve this issue. It's currently in integration now so lets see where we get with it, and what we can learn from it. Lets face it we need to get the MyMobile theme working in 2.4 so the sooner this gets sorted the quicker we can fix all those other trackers that have been reported.
          Hide
          Aparup Banerjee added a comment -

          Hi All,
          interesting discussion here .

          i've integrated this into master.

          As this one single commit does contain other white space fixes besides the actual bug fix - it is more difficult to back port this in a safe manner.
          please see http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport to follow through with backporting this.
          Can i also suggest leaving out other cleaning up from stable branches which can introduce uncaught risks making it riskier to backport.

          It is true though, this does help make integration easier to manage : http://docs.moodle.org/dev/Commit_cheat_sheet#Split_your_work_into_a_logical_set_of_patches.

          Show
          Aparup Banerjee added a comment - Hi All, interesting discussion here . i've integrated this into master. As this one single commit does contain other white space fixes besides the actual bug fix - it is more difficult to back port this in a safe manner. please see http://docs.moodle.org/dev/Integration_Review#Process_for_requesting_a_non_bug-fix_backport to follow through with backporting this. Can i also suggest leaving out other cleaning up from stable branches which can introduce uncaught risks making it riskier to backport. It is true though, this does help make integration easier to manage : http://docs.moodle.org/dev/Commit_cheat_sheet#Split_your_work_into_a_logical_set_of_patches .
          Hide
          Aparup Banerjee added a comment -

          (missed hitting the 'integrated' button)

          Show
          Aparup Banerjee added a comment - (missed hitting the 'integrated' button)
          Hide
          Mary Evans added a comment -

          I'll set up new tracker to deal with stable branches.
          Thanks Aparup.

          Show
          Mary Evans added a comment - I'll set up new tracker to deal with stable branches. Thanks Aparup.
          Hide
          Gareth J Barnard added a comment -

          Ok, lesson learnt, but to save me a shed load of extra work can all branches be pulled as it is really clear what is being changed. Otherwise, I'll have to undo the comment changes, reapply all changes, rebase, squash, test. Then peer review, reintegrate.... All for the sake of a few comments that have nothing to do with the actual functionality when user's are suffering because of a lack of a fix.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Ok, lesson learnt, but to save me a shed load of extra work can all branches be pulled as it is really clear what is being changed. Otherwise, I'll have to undo the comment changes, reapply all changes, rebase, squash, test. Then peer review, reintegrate.... All for the sake of a few comments that have nothing to do with the actual functionality when user's are suffering because of a lack of a fix. Cheers, Gareth
          Hide
          Mary Evans added a comment - - edited

          It's OK Gareth I'll do these just the fix and nothing else. Also it's not as bleak as you are making out. I blame me for asking to codecheck these in the first place. But as you have found, and me too, that none of that was necessary.

          The only need for the codechecker, as I see it, is in new themes, and looking at the themes in the plugins directory, any theme that is deemed worthy of being associated with Moodle.

          The fact that most people will clone a theme and then style it and share it will mean that they also inherit the baldly formatted Moodle code too.

          Now that I know the state of things I'll try and fix Moodle (master) so that this will become less likely in future.

          I just hope this has not put you off helping out with the MyMobile theme, which has, to date, been invaluable.

          Show
          Mary Evans added a comment - - edited It's OK Gareth I'll do these just the fix and nothing else. Also it's not as bleak as you are making out. I blame me for asking to codecheck these in the first place. But as you have found, and me too, that none of that was necessary. The only need for the codechecker, as I see it, is in new themes, and looking at the themes in the plugins directory, any theme that is deemed worthy of being associated with Moodle. The fact that most people will clone a theme and then style it and share it will mean that they also inherit the baldly formatted Moodle code too. Now that I know the state of things I'll try and fix Moodle (master) so that this will become less likely in future. I just hope this has not put you off helping out with the MyMobile theme, which has, to date, been invaluable.
          Hide
          Gareth J Barnard added a comment -

          Dear Mary,

          Thank you. How can I get credit for the commits though? For kudos in the community.

          You have not put me off helping out with the MyMobile theme as I wish to continue to learn jQuery and jQueryMobile as they seem to be CV friendly these days.

          I have suggested at this year's Hack-a-thon that contrib code be code-checked and prizes for doing so. And themes do fall under this umbrella.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary, Thank you. How can I get credit for the commits though? For kudos in the community. You have not put me off helping out with the MyMobile theme as I wish to continue to learn jQuery and jQueryMobile as they seem to be CV friendly these days. I have suggested at this year's Hack-a-thon that contrib code be code-checked and prizes for doing so. And themes do fall under this umbrella. Cheers, Gareth
          Hide
          Mary Evans added a comment - - edited

          @Gareth:

          You are very welcome to do the stable branch (MOODLE_24_STABLE and MOODLE_23_STABLE) fixes in MDL-38422 with pleasure, I just offered to do them as I got the impression/or thought you had had enough! LOL

          Show
          Mary Evans added a comment - - edited @Gareth: You are very welcome to do the stable branch (MOODLE_24_STABLE and MOODLE_23_STABLE) fixes in MDL-38422 with pleasure, I just offered to do them as I got the impression/or thought you had had enough! LOL
          Hide
          Gareth J Barnard added a comment -

          Dear Mary Evans,

          Thanks, I have had almost enough, just hoping that the changes would be accepted as is. As we are only dealing with comments. Just the same pa-larva as asking for a colon in single line comments.

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - Dear Mary Evans , Thanks, I have had almost enough, just hoping that the changes would be accepted as is. As we are only dealing with comments. Just the same pa-larva as asking for a colon in single line comments. Cheers, Gareth
          Hide
          Gareth J Barnard added a comment -

          P.S. The 'good thing' is that I intend to collate all of the learning tips into a Moodle 2.4+ developers certificate course and raise an MDLSITE issue to request it beyond what is there already.

          Show
          Gareth J Barnard added a comment - P.S. The 'good thing' is that I intend to collate all of the learning tips into a Moodle 2.4+ developers certificate course and raise an MDLSITE issue to request it beyond what is there already.
          Hide
          Aparup Banerjee added a comment -

          Btw, i think its OK to fast track simple issues - peer-reviews can be skipped for easy fixes and/or already discussed fixes.

          Show
          Aparup Banerjee added a comment - Btw, i think its OK to fast track simple issues - peer-reviews can be skipped for easy fixes and/or already discussed fixes.
          Hide
          Mary Evans added a comment -

          Hi Aparup,

          Who is going to test this, as I don't see any name added yet?
          This makes me nervous! LOL

          Show
          Mary Evans added a comment - Hi Aparup, Who is going to test this, as I don't see any name added yet? This makes me nervous! LOL
          Hide
          Adrian Greeve added a comment -

          Tested on the master integration branch on my iphone.
          Typing inside the text area, focusing out side of that and then returning to do more editing worked fine.

          Test passed.

          Show
          Adrian Greeve added a comment - Tested on the master integration branch on my iphone. Typing inside the text area, focusing out side of that and then returning to do more editing worked fine. Test passed.
          Hide
          Aparup Banerjee added a comment -

          Wednesdays DavidMo comes in and assigns them, so don't start getting nervous before then

          Show
          Aparup Banerjee added a comment - Wednesdays DavidMo comes in and assigns them, so don't start getting nervous before then
          Hide
          Mary Evans added a comment -

          Thanks guys!

          Show
          Mary Evans added a comment - Thanks guys!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

          Thanks!

          PS: Yay, legacy template messages. Yes, you're ok, we don't have CVS anymore!

          Show
          Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks! PS: Yay, legacy template messages. Yes, you're ok, we don't have CVS anymore!
          Hide
          Gareth J Barnard added a comment -

          Part two of this is MDL-38422.

          Show
          Gareth J Barnard added a comment - Part two of this is MDL-38422 .

            People

            • Votes:
              2 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: