Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select Splash theme in the normal way via Theme selector.
      2. Test every area, login, frontpage, course pages, topic, weekly, reports, admin reports, quiz, activities, resources etc., for consistency of design.
      3. Test blocks both docked and un-docked for pagelayout, again for consistency of design.
      4. Test Splash Custom theme settings in Appearance > Themes > Splash
      5. Test to see that the embedded page works correctly by adding a resource page that contains an embedded file such as a PDF.
      Show
      Select Splash theme in the normal way via Theme selector. Test every area, login, frontpage, course pages, topic, weekly, reports, admin reports, quiz, activities, resources etc., for consistency of design. Test blocks both docked and un-docked for pagelayout, again for consistency of design. Test Splash Custom theme settings in Appearance > Themes > Splash Test to see that the embedded page works correctly by adding a resource page that contains an embedded file such as a PDF.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31351_master
    • Rank:
      37868

      Description

      This is a total update of theme_splash intended for Moodle 2.3, as the changes applied may affect customised versions of this theme that are in use on production sites.

        Activity

        Caroline Kennedy created issue -
        Caroline Kennedy made changes -
        Field Original Value New Value
        Pull 2.2 Diff URL https://github.com/carolinekennedy/moodle/commit/eb3be1ec83c4ccc1ccc156316a3b18f4cc6bfa27
        Pull 2.2 Branch MDL-31351-SplashTheme
        Pull from Repository https://github.com/carolinekennedy/moodle
        Caroline Kennedy made changes -
        Pull Master Diff URL https://github.com/carolinekennedy/moodle/commit/b6dc469cce90f4576091b7387190f493cce2ef98
        Pull Master Branch MDL-31351-SplashTheme
        Labels Patch
        Helen Foster made changes -
        Fix Version/s STABLE backlog [ 10463 ]
        Labels Patch Patch triaged
        Mary Evans made changes -
        Assignee Patrick Malley [ ptrkmkl ] Mary Evans [ lazydaisy ]
        Mary Evans made changes -
        Status Open [ 1 ] Waiting for peer review [ 10012 ]
        Peer reviewer lazydaisy
        Mary Evans made changes -
        Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
        Aparup Banerjee made changes -
        Currently in integration Yes [ 10041 ]
        Mary Evans made changes -
        Pull Master Diff URL git://github.com/lazydaisy/moodle/compare/master...MDL-31351 https://github.com/lazydaisy/moodle/compare/master...MDL-31351
        Fix Version/s 2.3 [ 10657 ]
        Fix Version/s STABLE backlog [ 10463 ]
        Affects Version/s 2.2.1 [ 11456 ]
        Affects Version/s 2.2.2 [ 11552 ]
        Eloy Lafuente (stronk7) made changes -
        Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
        Integrator stronk7
        Eloy Lafuente (stronk7) made changes -
        Status Integration review in progress [ 10004 ] Reopened [ 4 ]
        Eloy Lafuente (stronk7) made changes -
        Currently in integration Yes [ 10041 ]
        Mary Evans made changes -
        Description I'll attach a link to the updated files in a few minutes.
        Mary Evans made changes -
        Assignee Mary Evans [ lazydaisy ] John Stabinger [ epsd ]
        Mary Evans made changes -
        Mary Evans made changes -
        Mary Evans made changes -
        Fix Version/s 2.1.5 [ 11553 ]
        Fix Version/s 2.2.2 [ 11552 ]
        Peer reviewer lazydaisy samhemelryk
        Affects Version/s 2.2 [ 10656 ]
        Affects Version/s 2.1 [ 10370 ]
        Affects Version/s 2.3 [ 10657 ]
        Mary Evans made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Mary Evans made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Mary Evans made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Mary Evans made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Mary Evans made changes -
        Mary Evans made changes -
        Assignee John Stabinger [ epsd ] Mary Evans [ lazydaisy ]
        Mary Evans made changes -
        Status Reopened [ 4 ] Development in progress [ 3 ]
        Mary Evans made changes -
        Pull Master Diff URL https://github.com/carolinekennedy/moodle/compare/master...MDL-31351-SplashTheme_master https://github.com/lazydaisy/moodle/compare/master/...MDL-31351
        Pull Master Branch MDL-31351-SplashTheme_master MDL-31351
        Fix Version/s 2.2.2 [ 11552 ]
        Fix Version/s 2.1.5 [ 11553 ]
        Testing Instructions # Select Splash theme in the normal way via Theme selector.
        # Test ever area, login, frontpage, course pages, topic, weekly, reports, admin reports, quiz, activities, resources etc., for consistency of design.
        # Test blocks both docked and un-docked for pagelayout, again for consistency of design.
        # Test Splash Custom theme settings in Appearance > Themes > Splash
        Description This is a total update of theme_splash intended for Moodle 2.3, as the changes applied may affect customised versions of this theme that are in use on production sites.

        Pull 2.2 Diff URL https://github.com/carolinekennedy/moodle/compare/master...MDL-31351-SplashTheme
        Pull 2.2 Branch MDL-31351-SplashTheme
        Pull from Repository git://github.com/carolinekennedy/moodle git://github.com/lazydaisy/moodle
        Labels Patch triaged triaged
        Attachment MDL-31351-Red-Splash.jpg [ 26523 ]
        Attachment MDL-31351-Green-Splash.jpg [ 26524 ]
        Attachment MDL-31351-Blue-Splash.jpg [ 26525 ]
        Attachment MDL-31351-Orange-Splash.jpg [ 26526 ]
        Affects Version/s 2.3 [ 10657 ]
        Affects Version/s DEV backlog [ 10464 ]
        Affects Version/s 2.1 [ 10370 ]
        Affects Version/s 2.2 [ 10656 ]
        Mary Evans made changes -
        Status Development in progress [ 3 ] Waiting for peer review [ 10012 ]
        Peer reviewer samhemelryk stronk7
        Mary Evans made changes -
        Testing Instructions # Select Splash theme in the normal way via Theme selector.
        # Test ever area, login, frontpage, course pages, topic, weekly, reports, admin reports, quiz, activities, resources etc., for consistency of design.
        # Test blocks both docked and un-docked for pagelayout, again for consistency of design.
        # Test Splash Custom theme settings in Appearance > Themes > Splash
        # Select Splash theme in the normal way via Theme selector.
        # Test ever area, login, frontpage, course pages, topic, weekly, reports, admin reports, quiz, activities, resources etc., for consistency of design.
        # Test blocks both docked and un-docked for pagelayout, again for consistency of design.
        # Test Splash Custom theme settings in Appearance > Themes > Splash
        # Test to see that the embedded page works correctly by adding a resource page that contains and embedded file such as a PDF.
        Mary Evans made changes -
        Testing Instructions # Select Splash theme in the normal way via Theme selector.
        # Test ever area, login, frontpage, course pages, topic, weekly, reports, admin reports, quiz, activities, resources etc., for consistency of design.
        # Test blocks both docked and un-docked for pagelayout, again for consistency of design.
        # Test Splash Custom theme settings in Appearance > Themes > Splash
        # Test to see that the embedded page works correctly by adding a resource page that contains and embedded file such as a PDF.
        # Select Splash theme in the normal way via Theme selector.
        # Test every area, login, frontpage, course pages, topic, weekly, reports, admin reports, quiz, activities, resources etc., for consistency of design.
        # Test blocks both docked and un-docked for pagelayout, again for consistency of design.
        # Test Splash Custom theme settings in Appearance > Themes > Splash
        # Test to see that the embedded page works correctly by adding a resource page that contains and embedded file such as a PDF.
        Mary Evans made changes -
        Status Waiting for peer review [ 10012 ] Waiting for integration review [ 10010 ]
        Mary Evans made changes -
        Status Waiting for integration review [ 10010 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Mary Evans made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Mary Evans made changes -
        Status Reopened [ 4 ] Development in progress [ 3 ]
        Mary Evans made changes -
        Pull Master Diff URL https://github.com/lazydaisy/moodle/compare/master...MDL-31351
        Pull Master Branch MDL-31351
        Affects Version/s DEV backlog [ 10464 ]
        Mary Evans made changes -
        Mary Evans made changes -
        Testing Instructions # Select Splash theme in the normal way via Theme selector.
        # Test every area, login, frontpage, course pages, topic, weekly, reports, admin reports, quiz, activities, resources etc., for consistency of design.
        # Test blocks both docked and un-docked for pagelayout, again for consistency of design.
        # Test Splash Custom theme settings in Appearance > Themes > Splash
        # Test to see that the embedded page works correctly by adding a resource page that contains and embedded file such as a PDF.
        # Select Splash theme in the normal way via Theme selector.
        # Test every area, login, frontpage, course pages, topic, weekly, reports, admin reports, quiz, activities, resources etc., for consistency of design.
        # Test blocks both docked and un-docked for pagelayout, again for consistency of design.
        # Test Splash Custom theme settings in Appearance > Themes > Splash
        # Test to see that the embedded page works correctly by adding a resource page that contains an embedded file such as a PDF.
        Mary Evans made changes -
        Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
        Mary Evans made changes -
        Status Waiting for integration review [ 10010 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Mary Evans made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Mary Evans made changes -
        Status Reopened [ 4 ] Development in progress [ 3 ]
        Mary Evans made changes -
        Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
        Eloy Lafuente (stronk7) made changes -
        Currently in integration Yes [ 10041 ]
        Eloy Lafuente (stronk7) made changes -
        Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
        Eloy Lafuente (stronk7) made changes -
        Labels triaged docs_required triaged ui_change
        Eloy Lafuente (stronk7) made changes -
        Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
        Michael de Raadt made changes -
        Tester nebgor
        Aparup Banerjee made changes -
        Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
        Aparup Banerjee made changes -
        Status Testing in progress [ 10011 ] Tested [ 10006 ]
        Eloy Lafuente (stronk7) made changes -
        Status Tested [ 10006 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Currently in integration Yes [ 10041 ]
        Integration date 01/Mar/12
        Helen Foster made changes -
        Labels docs_required triaged ui_change triaged ui_change

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: