[MDL-31359] lesson: essay question shows html characters on review - Moodle Tracker

XML

Word

Printable

Type: Bug
Status: Closed
Priority: Major
Resolution: Duplicate
Affects Version/s: 2.2.1, 2.6
Fix Version/s: None
Component/s: Lesson
Labels:
- partner
- patch
- triaged
Environment:
RHEL/ virtual machine/ production server
iMac/ PHP MYSQL development server

Database:

MySQL
Affected Branches:
MOODLE_22_STABLE, MOODLE_26_STABLE
Workaround:

Hide

Changed line 2031 of /<mooodle dir>/mod/lesson/locallib.php
from
$result->feedback .= '<div class="correctanswer generalbox"><em>'.get_string("youranswer", "lesson").'</em> '. $result->studentanswer; // already in clean html

to

$result->feedback .= '<div class="correctanswer generalbox"><p><em>'.get_string("youranswer", "lesson").'</em></p>'. html_entity_decode($result->studentanswer) ;

nb the 'your answer' string is wrapped in a paragraph tag to format correctly.

Show
Changed line 2031 of /<mooodle dir>/mod/lesson/locallib.php from $result->feedback .= '<div class="correctanswer generalbox"><em>'.get_string("youranswer", "lesson").'</em> '. $result->studentanswer; // already in clean html to $result->feedback .= '<div class="correctanswer generalbox"><p><em>'.get_string("youranswer", "lesson").'</em></p>'. html_entity_decode($result->studentanswer) ; nb the 'your answer' string is wrapped in a paragraph tag to format correctly.
Testing Instructions:

Hide

create a lesson with display default feedback option set to true.
create a question page of type essay
view the essay question as student, enter an answer.
see the text under 'your answer'

Show
create a lesson with display default feedback option set to true. create a question page of type essay view the essay question as student, enter an answer. see the text under 'your answer'

when a student uses the essay question in a lesson the summary page displays the html characters of their response eg,
<p>Here is my essay</p>

duplicates

MDL-43386 Grade essay student response formatting not correct.

MDL-30639 Lesson answers display HTML tags

has been marked as being related by

MDL-30867 Lesson essay question formatting is inconsistent and in fact horribly broken.

is duplicated by

MDL-40492 email graded essays sends HTML tags

MDL-34940 Answer review in essay question type shows HTML tags from TinyMCE editor in lesson module

will be (partly) resolved by

MDL-43386 Grade essay student response formatting not correct.

(1 will be (partly) resolved by)

Participants:: Jean-Michel Vedrine, Josh Johnston, Michael de Raadt, Peter Gee, Rossiani Wijaya

Component watchers:: Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie